logos-storage/plonky2
1
0
Fork 0
mirror of https://github.com/logos-storage/plonky2.git synced 2026-01-02 13:53:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Remove TODOs about from_values taking a reference

Browse Source
This commit is contained in:
David Palm 2023-11-30 15:10:34 +01:00
parent 37918cccfd
commit e68195fc0d
No known key found for this signature in database
GPG Key ID: AC8A213E894DB26D
3 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
evm/src/keccak/keccak_stark.rs
View File

@ -722,8 +722,6 @@ mod tests {
stark.generate_trace(input, 8, &mut timing)
);
// TODO: Cloning this isn't great; consider having `from_values` accept a reference,
// or having `compute_permutation_z_polys` read trace values from the `PolynomialBatch`.
let cloned_trace_poly_values = timed!(timing, "clone", trace_poly_values.clone());
let trace_commitments = timed!(

2
evm/src/prover.rs
View File

@ -102,8 +102,6 @@ where
timing,
&format!("compute trace commitment for {:?}", table),
PolynomialBatch::<F, C, D>::from_values(
// TODO: Cloning this isn't great; consider having `from_values` accept a reference,
// or having `compute_permutation_z_polys` read trace values from the `PolynomialBatch`.
trace.clone(),
rate_bits,
false,

2
starky/src/prover.rs
View File

@ -55,8 +55,6 @@ where
timing,
"compute trace commitment",
PolynomialBatch::<F, C, D>::from_values(
// TODO: Cloning this isn't great; consider having `from_values` accept a reference,
// or having `compute_permutation_z_polys` read trace values from the `PolynomialBatch`.
trace_poly_values.clone(),
rate_bits,
false,