From e68195fc0d4613f32e3874ca198a8be6acbb6ec0 Mon Sep 17 00:00:00 2001 From: David Palm Date: Thu, 30 Nov 2023 15:10:34 +0100 Subject: [PATCH] chore: Remove TODOs about `from_values` taking a reference --- evm/src/keccak/keccak_stark.rs | 2 -- evm/src/prover.rs | 2 -- starky/src/prover.rs | 2 -- 3 files changed, 6 deletions(-) diff --git a/evm/src/keccak/keccak_stark.rs b/evm/src/keccak/keccak_stark.rs index 9870b906..e81d2f8a 100644 --- a/evm/src/keccak/keccak_stark.rs +++ b/evm/src/keccak/keccak_stark.rs @@ -722,8 +722,6 @@ mod tests { stark.generate_trace(input, 8, &mut timing) ); - // TODO: Cloning this isn't great; consider having `from_values` accept a reference, - // or having `compute_permutation_z_polys` read trace values from the `PolynomialBatch`. let cloned_trace_poly_values = timed!(timing, "clone", trace_poly_values.clone()); let trace_commitments = timed!( diff --git a/evm/src/prover.rs b/evm/src/prover.rs index fe8ad517..c61361d6 100644 --- a/evm/src/prover.rs +++ b/evm/src/prover.rs @@ -102,8 +102,6 @@ where timing, &format!("compute trace commitment for {:?}", table), PolynomialBatch::::from_values( - // TODO: Cloning this isn't great; consider having `from_values` accept a reference, - // or having `compute_permutation_z_polys` read trace values from the `PolynomialBatch`. trace.clone(), rate_bits, false, diff --git a/starky/src/prover.rs b/starky/src/prover.rs index 23808e0f..866bb635 100644 --- a/starky/src/prover.rs +++ b/starky/src/prover.rs @@ -55,8 +55,6 @@ where timing, "compute trace commitment", PolynomialBatch::::from_values( - // TODO: Cloning this isn't great; consider having `from_values` accept a reference, - // or having `compute_permutation_z_polys` read trace values from the `PolynomialBatch`. trace_poly_values.clone(), rate_bits, false,