Minor

starky2/src/cross_table_lookups.rs

@@ -64,13 +64,13 @@ pub fn cross_table_lookup_zs<F: RichField, C: GenericConfig<D, F = F>, const D:
                 let gamma = challenger.get_challenge();
                 let z_looking = partial_products(
                     &trace_poly_values[*looking_table as usize],
-                    &looking_columns,
+                    looking_columns,
                     beta,
                     gamma,
                 );
                 let z_looked = partial_products(
                     &trace_poly_values[*looked_table as usize],
-                    &looked_columns,
+                    looked_columns,
                     beta,
                     gamma,
                 );
@@ -103,7 +103,7 @@ fn partial_products<F: Field>(
     let mut res = Vec::new();
     for i in 0..trace[0].len() {
         partial_prod *=
-            gamma + reduce_with_powers(columns.iter().map(|&j| &trace[i].values[j]), beta);
+            gamma + reduce_with_powers(columns.iter().map(|&j| &trace[j].values[i]), beta);
         res.push(partial_prod);
     }
     res.into()

starky2/src/prover.rs

@@ -345,6 +345,7 @@ where
         "Opening point is in the subgroup."
     );
 
+    // TODO: Add openings of lookup Z polynomials.
     let openings = StarkOpeningSet::new(
         zeta,
         g,

starky2/src/verifier.rs

@@ -68,8 +68,8 @@ where
         quotient_polys,
     } = &proof.openings;
     let vars = StarkEvaluationVars {
-        local_values: &local_values,
-        next_values: &next_values,
+        local_values,
+        next_values,
         public_inputs: &public_inputs
             .into_iter()
             .map(F::Extension::from_basefield)