From 99b6ac4ff23ca99076b2557649c1ec7c9c3c3f0a Mon Sep 17 00:00:00 2001 From: wborgeaud Date: Fri, 6 May 2022 16:59:25 +0200 Subject: [PATCH] Minor --- starky2/src/cross_table_lookups.rs | 6 +++--- starky2/src/prover.rs | 1 + starky2/src/verifier.rs | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/starky2/src/cross_table_lookups.rs b/starky2/src/cross_table_lookups.rs index 5ad5680e..69d76811 100644 --- a/starky2/src/cross_table_lookups.rs +++ b/starky2/src/cross_table_lookups.rs @@ -64,13 +64,13 @@ pub fn cross_table_lookup_zs, const D: let gamma = challenger.get_challenge(); let z_looking = partial_products( &trace_poly_values[*looking_table as usize], - &looking_columns, + looking_columns, beta, gamma, ); let z_looked = partial_products( &trace_poly_values[*looked_table as usize], - &looked_columns, + looked_columns, beta, gamma, ); @@ -103,7 +103,7 @@ fn partial_products( let mut res = Vec::new(); for i in 0..trace[0].len() { partial_prod *= - gamma + reduce_with_powers(columns.iter().map(|&j| &trace[i].values[j]), beta); + gamma + reduce_with_powers(columns.iter().map(|&j| &trace[j].values[i]), beta); res.push(partial_prod); } res.into() diff --git a/starky2/src/prover.rs b/starky2/src/prover.rs index 7413dcba..74c036af 100644 --- a/starky2/src/prover.rs +++ b/starky2/src/prover.rs @@ -345,6 +345,7 @@ where "Opening point is in the subgroup." ); + // TODO: Add openings of lookup Z polynomials. let openings = StarkOpeningSet::new( zeta, g, diff --git a/starky2/src/verifier.rs b/starky2/src/verifier.rs index 9ac05d96..05718ee0 100644 --- a/starky2/src/verifier.rs +++ b/starky2/src/verifier.rs @@ -68,8 +68,8 @@ where quotient_polys, } = &proof.openings; let vars = StarkEvaluationVars { - local_values: &local_values, - next_values: &next_values, + local_values, + next_values, public_inputs: &public_inputs .into_iter() .map(F::Extension::from_basefield)