From 064b3c07a829deefadb5e71a974971da845e5ab8 Mon Sep 17 00:00:00 2001
From: wborgeaud <williamborgeaud@gmail.com>
Date: Tue, 22 Feb 2022 16:18:41 +0100
Subject: [PATCH] Forgot to set permutation cap

---
 starky/src/prover.rs             | 2 --
 starky/src/recursive_verifier.rs | 6 ++++++
 starky/src/stark.rs              | 1 -
 starky/src/verifier.rs           | 1 -
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/starky/src/prover.rs b/starky/src/prover.rs
index 5cfcf6ea..ac6689c2 100644
--- a/starky/src/prover.rs
+++ b/starky/src/prover.rs
@@ -294,8 +294,6 @@ where
                 permutation_check_data,
                 &mut consumer,
             );
-            // stark.eval_packed_base(vars, &mut consumer);
-            // TODO: Add in constraints for permutation arguments.
             // TODO: Fix this once we use a genuine `PackedField`.
             let mut constraints_evals = consumer.accumulators();
             // We divide the constraints evaluations by `Z_H(x)`.
diff --git a/starky/src/recursive_verifier.rs b/starky/src/recursive_verifier.rs
index cc547396..608d6dc1 100644
--- a/starky/src/recursive_verifier.rs
+++ b/starky/src/recursive_verifier.rs
@@ -295,5 +295,11 @@ pub fn set_stark_proof_target<F, C: GenericConfig<D, F = F>, W, const D: usize>(
         &proof.openings.to_fri_openings(),
     );
 
+    if let (Some(permutation_zs_cap_target), Some(permutation_zs_cap)) =
+        (&proof_target.permutation_zs_cap, &proof.permutation_zs_cap)
+    {
+        witness.set_cap_target(&permutation_zs_cap_target, &permutation_zs_cap);
+    }
+
     set_fri_proof_target(witness, &proof_target.opening_proof, &proof.opening_proof);
 }
diff --git a/starky/src/stark.rs b/starky/src/stark.rs
index a2a2f7fd..72614574 100644
--- a/starky/src/stark.rs
+++ b/starky/src/stark.rs
@@ -16,7 +16,6 @@ use crate::vars::StarkEvaluationTargets;
 use crate::vars::StarkEvaluationVars;
 
 /// Represents a STARK system.
-// TODO: Add a `constraint_degree` fn that returns the maximum constraint degree.
 pub trait Stark<F: RichField + Extendable<D>, const D: usize>: Sync {
     /// The total number of columns in the trace.
     const COLUMNS: usize;
diff --git a/starky/src/verifier.rs b/starky/src/verifier.rs
index 6bb1ac4e..44d3f9c7 100644
--- a/starky/src/verifier.rs
+++ b/starky/src/verifier.rs
@@ -102,7 +102,6 @@ where
         permutation_data,
         &mut consumer,
     );
-    // TODO: Add in constraints for permutation arguments.
     let vanishing_polys_zeta = consumer.accumulators();
 
     // Check each polynomial identity, of the form `vanishing(x) = Z_H(x) quotient(x)`, at zeta.