270 Commits

Author SHA1 Message Date
Arnaud
fcd4cb8672
Pass the resubscribe internal in new function and remove unneeded try except 2025-03-30 12:38:50 +02:00
Arnaud
3265595aae
Restore new lines 2025-03-30 12:18:31 +02:00
Arnaud
400099e9f7
Remove extra dot in test label 2025-03-27 09:23:20 +01:00
Arnaud
9c8097db3c
Use seconds instead of milliseconds 2025-03-27 09:16:50 +01:00
Arnaud
64f3d0d5f1
Restore privateAccess because logEvents moved to JsonRpcSubscriptions 2025-03-27 09:14:09 +01:00
Arnaud
ac156b484a
Fix try except format 2025-03-27 09:13:21 +01:00
Arnaud
56a63f820c
Fix wording 2025-03-27 09:10:16 +01:00
Arnaud
21f3044237
Remove useless private access 2025-03-27 09:08:34 +01:00
Arnaud
cf7fde013b
Add lock when subscribing to blocks 2025-03-27 09:07:14 +01:00
Arnaud
44d6cf49d2
Update log filters comment 2025-03-27 09:02:02 +01:00
Arnaud
266ef540e8
Handle the concurrency issues when updating the logFilters and add tests 2025-03-27 09:00:12 +01:00
Arnaud
f06c3a785e
Remove the ws_resubscribe flag from the config 2025-03-27 08:45:51 +01:00
Arnaud
e86f636725
Update wording 2025-03-26 14:55:42 +01:00
Arnaud
338ecada3e
Update wording 2025-03-26 12:51:35 +01:00
Arnaud
67ad09dad2
Add nimbledeps to git ignore 2025-03-26 09:14:58 +01:00
Arnaud
8f802d7405
Provide better message 2025-03-26 09:14:46 +01:00
Arnaud
359f04e7ec
Rename the symbol for better clarity 2025-03-20 16:16:52 +01:00
Arnaud
d1b54beec5
Add documentation for the resubscribe symbol 2025-03-20 15:56:03 +01:00
Arnaud
4c19e14853
Add resubscribe flag 2025-03-20 15:45:18 +01:00
Arnaud
c48ff9b84d
Move logFilters to JsonRpcSubscriptions 2025-03-19 13:40:37 +01:00
Arnaud
7081e6922f
Re-activate styleCheck 2025-03-18 08:42:52 +01:00
Arnaud
5d07b5dbcf
Define raises for async pragma 2025-03-18 08:12:24 +01:00
Eric
b505ef1ab8
Raise SignerError instead of propagating AsyncLockError (#109) 2025-03-13 14:45:31 +11:00
Eric
d2b11a8657
fix(async): propagate async cancellation (#105)
* fix(async): propagate CancelledErrors

* remove CatchableError from contract macro async raises list

* remove mistakenly added ContractError
2025-02-17 20:31:24 +11:00
Arnaud
26342d3e27
Update to nim 2 x (#103)
* Update dependencies for Nim 2.x

* Use refc as memory management and disable styleCheck because of testutils

* Fix ambiguous import

* Change Address init because eth introduced Byte20 type for Address type

* use uint64 instead of init64

* Rename properties after a change in eth to be closer to the spec

* Use Opt type instead of Option

* Add 2.0.12 version to CI

* Increment the version

* Update the Nim version in CI

* Update to Nim 2.0.14

* Use Nim 2.x commit hash for contractabi

* Remove stable on CI because we don't want to test with Nim 2.2.x

* Update Nim minimum version to 2.0.14

* fix version deps

* remove fq typename

* Add debug flag

* Define maximumtaggedversions

* Update readme

---------

Co-authored-by: Eric <5089238+emizzle@users.noreply.github.com>
2025-02-14 14:18:19 +11:00
Marcin Czenko
0f98528758 adds tests for BlockTag 2024-12-10 17:41:42 +01:00
Marcin Czenko
c7c57113ce adds number getter for BlockTags with number 2024-12-10 17:41:42 +01:00
Adam Uhlíř
037bef0256
chore: fix async raises warnings (#100) 2024-12-09 16:22:25 +01:00
Marcin Czenko
04d3548553
version 1.0.0
This is a braking change. Subscription callbacks wrap the arguments in the Result type.
Corrects the preceding commit marked with wrong version number (0.10.2).
1.0.0
2024-12-02 17:15:42 +01:00
Marcin Czenko
2808a05488
version 0.10.2 2024-11-28 16:15:40 +01:00
Marcin Czenko
5c93971f97 fix the test after rebasing 2024-11-28 16:08:51 +01:00
Marcin Czenko
c0cc437aa2 applies review comments 2024-11-28 16:08:51 +01:00
Marcin Czenko
4642545309 makes sure that a key on subscriptionMapping exists before trying to access it 2024-11-28 16:08:51 +01:00
Adam Uhlíř
d88e4614b1
feat: subscriptions get passed result questionable (#91)
Co-authored-by: Eric <5089238+emizzle@users.noreply.github.com>
2024-11-28 14:48:10 +01:00
Eric
04c00e2d91
Updates non-versioned deps to their versioned counterparts (#97)
Also bumps ethers patch version
v0.10.1
2024-11-28 13:26:58 +11:00
Mark Spanbroek
1ae2cd4a35
version 0.10.0
This is a breaking change. Calling .confirm(0)
is no longer supported; you need at least 1
confirmation.
0.10.0
2024-11-13 10:14:09 +01:00
Mark Spanbroek
e9d862ceca do not crash when we cannot get block number
Co-Authored-By: Eric <5089238+emizzle@users.noreply.github.com>
2024-11-13 10:09:40 +01:00
Mark Spanbroek
35aebdb46f cleanup 2024-11-13 10:09:40 +01:00
Mark Spanbroek
f15d55f513 do not crash polling when just unsubscribed 2024-11-13 10:09:40 +01:00
Mark Spanbroek
c6a59b5187 resubscribe when error in polling 2024-11-13 10:09:40 +01:00
Mark Spanbroek
5a9895b792 disallow .confirm(0)
reason: it didn't wait for any blocks to be mined,
not even the block that includes the transaction.
2024-11-13 10:09:40 +01:00
Mark Spanbroek
c9275b1f6c cleanup 2024-11-13 10:09:40 +01:00
Mark Spanbroek
40dee9b525 disable chronicles logging in tests 2024-11-13 10:09:40 +01:00
Eric
0ce6abf0fe
fix(nonce): indentation mistake after last merge (#92)
* fix an indentation mistake after last merge

* add assertion to ensure nonce is not populated

* assert populated nonce is populated, not transaction
2024-11-01 16:49:06 +01:00
Adam Uhlíř
80b2ead97c
fix: block filters can be also recreated (#85)
* fix: block filters can be also recreated

* refactor: rename filter to logFilter
2024-10-30 17:26:27 +01:00
Eric
d60cedbb98
chore: bump ethers to forked deps (#89) 2024-10-30 17:12:24 +01:00
Slava
4607817057
ci: add matrix status job (#83) 2024-10-28 15:27:50 +02:00
Eric
6523e70eaf
fix: items(JsonNode) symbol not found (#87)
* chore: export subscriptions

This has a knock-on effect of nim-serde not being imported into subscriptions when JsonRpcProvider.new is called from a consumer that does not export nim-serde.

* import/export serde

* Replace all instances of std/json with pkg/serde
2024-10-28 14:06:20 +11:00
Eric
765379a662
fix: nonce too high (#81)
* fix nonce issues by locking populate and send transaction

Concurrent asynchronous population of transactions cause issues with nonces not being in sync with the transaction count for an account on chain. This was being mitigated by tracking a "last seen" nonce and locking inside of `populateTransaction` so that the nonce could be populated in a concurrent fashion. However, if there was an async cancellation before the transaction was sent, then the nonce would become out of sync. One solution was to decrease the nonce if a cancellation occurred. The other solution, in this commit, is simply to lock the populate and sendTransaction calls together, so that there will not be concurrent nonce discrepancies. This removes the need for "lastSeenNonce" and is overall more simple.

* remove lastSeenNonce

Internal nonce tracking is no longer needed since populate/sendTransaction is now locked. Even if cancelled midway, the nonce will get a refreshed value from the number of transactions from chain.

* chronos v4 exception tracking

* Add tests
2024-10-25 15:08:00 +11:00
Eric
b68bea9909
fix: modify unsubscribe cleanup routine and tests (#84)
* fix: modify unsubscribe cleanup routine

Ignore exceptions (other than CancelledError) if uninstallation of the filter fails. If it's the last step in the subscription cleanup, then filter changes for this filter will no longer be polled so if the filter continues to live on in geth for whatever reason, then it doesn't matter.

This includes a number of fixes:
- `CancelledError` is now caught inside of `getChanges`. This was causing conditions during `subscriptions.close`, where the `CancelledError` would get consumed by the `except CatchableError`, if there was an ongoing `poll` happening at the time of close.
- After creating a new filter inside of `getChanges`, the new filter is polled for changes before returning.
- `getChanges` also does not swallow `CatchableError` by returning an empty array, and instead re-raises the error if it is not `filter not found`.
- The tests were simplified by accessing the private fields of `PollingSubscriptions`. That way, there wasn't a race condition for the `newFilterId` counter inside of the mock.
- The `MockRpcHttpServer` was simplified by keeping track of the active filters only, and invalidation simply removes the filter. The tests then only needed to rely on the fact that the filter id changed in the mapping.
- Because of the above changes, we no longer needed to sleep inside of the tests, so the sleeps were removed, and the polling interval could be changed to 1ms, which not only makes the tests faster, but would further highlight any race conditions if present.

* docs: rpc custom port documentation

---------

Co-authored-by: Adam Uhlíř <adam@uhlir.dev>
2024-10-25 14:58:45 +11:00