Converts specific errors to RpcNetworkError, which can be bubbled to applications at a higher level and retried on the network (eg with exponential backoff) until resolved or timed out.
Changes:
- supports Nim 2.0.x and 2.2.x
- no longer supports Nim versions 1.6.x
- better handling of async exceptions
- block number can be retrieved from a block tag
- workaround for hardhat websocket subscription timeouts
- supports estimating gas for contract calls
* Move logFilters to JsonRpcSubscriptions
* Add resubscribe flag
* Add documentation for the resubscribe symbol
* Rename the symbol for better clarity
* Provide better message
* Add nimbledeps to git ignore
* Update wording
* Update wording
* Remove the ws_resubscribe flag from the config
* Handle the concurrency issues when updating the logFilters and add tests
* Update log filters comment
* Add lock when subscribing to blocks
* Remove useless private access
* Fix wording
* Fix try except format
* Restore privateAccess because logEvents moved to JsonRpcSubscriptions
* Use seconds instead of milliseconds
* Remove extra dot in test label
* Restore new lines
* Pass the resubscribe internal in new function and remove unneeded try except
* Remove ws_resubscribe default value making testing easier
* Remove unneeded condition
* Add new line
* Fix nim syntax
* Update symbol description
* Log warning when the resubscription interval is more than 300 seconds
* Catch errors in close method
* Redefine raises for async pragma in close methods
* Provide better error message
* Update dependencies for Nim 2.x
* Use refc as memory management and disable styleCheck because of testutils
* Fix ambiguous import
* Change Address init because eth introduced Byte20 type for Address type
* use uint64 instead of init64
* Rename properties after a change in eth to be closer to the spec
* Use Opt type instead of Option
* Add 2.0.12 version to CI
* Increment the version
* Update the Nim version in CI
* Update to Nim 2.0.14
* Use Nim 2.x commit hash for contractabi
* Remove stable on CI because we don't want to test with Nim 2.2.x
* Update Nim minimum version to 2.0.14
* fix version deps
* remove fq typename
* Add debug flag
* Define maximumtaggedversions
* Update readme
---------
Co-authored-by: Eric <5089238+emizzle@users.noreply.github.com>
This is a braking change. Subscription callbacks wrap the arguments in the Result type.
Corrects the preceding commit marked with wrong version number (0.10.2).
* chore: export subscriptions
This has a knock-on effect of nim-serde not being imported into subscriptions when JsonRpcProvider.new is called from a consumer that does not export nim-serde.
* import/export serde
* Replace all instances of std/json with pkg/serde
* fix nonce issues by locking populate and send transaction
Concurrent asynchronous population of transactions cause issues with nonces not being in sync with the transaction count for an account on chain. This was being mitigated by tracking a "last seen" nonce and locking inside of `populateTransaction` so that the nonce could be populated in a concurrent fashion. However, if there was an async cancellation before the transaction was sent, then the nonce would become out of sync. One solution was to decrease the nonce if a cancellation occurred. The other solution, in this commit, is simply to lock the populate and sendTransaction calls together, so that there will not be concurrent nonce discrepancies. This removes the need for "lastSeenNonce" and is overall more simple.
* remove lastSeenNonce
Internal nonce tracking is no longer needed since populate/sendTransaction is now locked. Even if cancelled midway, the nonce will get a refreshed value from the number of transactions from chain.
* chronos v4 exception tracking
* Add tests
* fix: modify unsubscribe cleanup routine
Ignore exceptions (other than CancelledError) if uninstallation of the filter fails. If it's the last step in the subscription cleanup, then filter changes for this filter will no longer be polled so if the filter continues to live on in geth for whatever reason, then it doesn't matter.
This includes a number of fixes:
- `CancelledError` is now caught inside of `getChanges`. This was causing conditions during `subscriptions.close`, where the `CancelledError` would get consumed by the `except CatchableError`, if there was an ongoing `poll` happening at the time of close.
- After creating a new filter inside of `getChanges`, the new filter is polled for changes before returning.
- `getChanges` also does not swallow `CatchableError` by returning an empty array, and instead re-raises the error if it is not `filter not found`.
- The tests were simplified by accessing the private fields of `PollingSubscriptions`. That way, there wasn't a race condition for the `newFilterId` counter inside of the mock.
- The `MockRpcHttpServer` was simplified by keeping track of the active filters only, and invalidation simply removes the filter. The tests then only needed to rely on the fact that the filter id changed in the mapping.
- Because of the above changes, we no longer needed to sleep inside of the tests, so the sleeps were removed, and the polling interval could be changed to 1ms, which not only makes the tests faster, but would further highlight any race conditions if present.
* docs: rpc custom port documentation
---------
Co-authored-by: Adam Uhlíř <adam@uhlir.dev>
