logos-storage/nim-datastore
1
0
Fork 0
mirror of https://github.com/logos-storage/nim-datastore.git synced 2026-01-05 23:23:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

add some more docs - design notes

Browse Source
This commit is contained in:
Jaremy Creechley 2023-09-11 17:27:20 -07:00
parent a40c1b23bb
commit 57a1918ac4
No known key found for this signature in database
GPG Key ID: 4E66FB67B21D3300
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
datastore/threads/threadbackend.nim
View File

@ -50,6 +50,11 @@ push: {.upraises: [].}
## potentially get the signal. In this case the `TResult` would still be empty.
## It shouldn't corrupt memory, but the `threadproxyds` TResult would return "empty".
##
## Note I'm not sure if using ThreadSignalPtr's directly and closing them would work
## as File sockets are just int's on Linux/Mac and can be racey. It may be possible
## that if both sides don't `close` the AsyncFD that are used, you'd just get events
## from another pipe/socketpair which shares the same AsyncFD int's. Probably a solution
## to this but needs some more consideration.
##
type