From 57a1918ac4047d610011c7077aea44588dcc4d69 Mon Sep 17 00:00:00 2001 From: Jaremy Creechley Date: Mon, 11 Sep 2023 17:27:20 -0700 Subject: [PATCH] add some more docs - design notes --- datastore/threads/threadbackend.nim | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/datastore/threads/threadbackend.nim b/datastore/threads/threadbackend.nim index 181724f..c708950 100644 --- a/datastore/threads/threadbackend.nim +++ b/datastore/threads/threadbackend.nim @@ -50,6 +50,11 @@ push: {.upraises: [].} ## potentially get the signal. In this case the `TResult` would still be empty. ## It shouldn't corrupt memory, but the `threadproxyds` TResult would return "empty". ## +## Note I'm not sure if using ThreadSignalPtr's directly and closing them would work +## as File sockets are just int's on Linux/Mac and can be racey. It may be possible +## that if both sides don't `close` the AsyncFD that are used, you'd just get events +## from another pipe/socketpair which shares the same AsyncFD int's. Probably a solution +## to this but needs some more consideration. ## type