33 Commits

Author SHA1 Message Date
M Alghazwi
51e3f0ffeb apply goldilocks changes in plonky2 v1.0.2 2025-05-27 10:26:53 +02:00
Kevin Jue
c01f530fe1
fix: Support range checking non aligned bitwidth values (#47)
* initial commit

* most of the code done

* made global poseidon chip

* changed decompSize and added some panics

* made all gl chip as pointers

* working code

* revert go.mod and go.sum

* cleanup and comments

* cleaned up range checker selection

* renamed gnarkRangeCheckSelector to gnarkRangeCheckerSelector

* addressed PR comment

* addressed overflow issue identified by Veridise

* added some comments

* fixed some comment typos

* restore change made from commit hash 85d20ce and 9617141
2024-01-04 13:56:13 -08:00
Kevin Jue
c82e6f3747
Merge pull request #44 from succinctlabs/kevjue/bit_decomp_range_checker
feat: added support to optionally use bit decompose range checker
2024-01-02 14:37:00 -08:00
Kevin Jue
503429f92f
Merge pull request #45 from succinctlabs/kevjue/assert_leading_zeros_optimizations
perf: assertLeadingZeros constraint optimizations
2024-01-02 13:40:14 -08:00
Kevin Jue
d241f54f48 address veridise feedback for V-SCT-VUL-007 and V-SCT-VUL-011 (hasInv needed to be constrained) 2023-12-26 07:49:55 -08:00
Kevin Jue
daad394f73 constraint optimizations for assertLeadingZeros 2023-12-22 11:42:53 -08:00
Kevin Jue
1a0372621c removed Exp in goldilocks/base.go per V-SCT-VUL-016 2023-12-21 14:20:23 -08:00
Kevin Jue
9be0171580 added support to optionally use bit decompose range checker 2023-12-21 12:23:28 -08:00
Kevin Jue
f256ca69f3 fix for V-SCT-VUL-027 2023-12-19 12:22:19 -08:00
Kevin Jue
ac49898dd1 fix for V-SCT-VUL-016 2023-12-18 18:02:01 -08:00
Kevin Jue
96171410b0 fix for V-SCT-VUL-015 2023-12-18 17:58:56 -08:00
Kevin Jue
2043890a76 fix for V-SCT-VUL-014 2023-12-18 17:23:58 -08:00
Kevin Jue
cc51ec1815 fix for V-SCT-VUL-007 and V-SCT-VUL-011 2023-12-18 16:09:08 -08:00
Kevin Jue
297a82025f fix for V-SCT-VUL-002 and V-SCT-VUL-003 2023-12-18 15:42:09 -08:00
Kevin Jue
a6707ed714 fix for V-SCT-VUL-004 2023-12-18 13:04:43 -08:00
Kevin Jue
2c361fa5e3 fix for V-SCT-VUL-003 2023-12-18 12:54:36 -08:00
Kevin Jue
85d20ce656 fix for V-SCT-VUL-002 2023-12-18 12:46:53 -08:00
Kevin Jue
9e963933f9 fix for V-SCT-VUL-001 2023-12-18 12:35:12 -08:00
puma314
89b5a01e4b
feat: Plonk optimizations (#39)
* Fixed poseidion hash TOOD in fri/fri.go

* optimized goldilocks

* Another optimization

* Down to 16 million

* Finished TODOs
2023-10-13 14:00:54 -07:00
puma314
940c81b212
Significant refactor and all tests passing, as well as optimized range check for Goldilocks (#37) 2023-10-11 18:02:46 -07:00
puma314
0c677ddd0d
Revert "Range check optimizations" 2023-10-11 17:39:52 -07:00
Uma Roy
8b96b0fd87 Removed extraneous range check 2023-10-11 17:38:57 -07:00
Uma Roy
5d53737841 Moved to variables 2023-10-11 12:01:26 -07:00
Uma Roy
3b8611c6ac Rename back 2023-10-11 11:37:45 -07:00
Uma Roy
d8b919a403 Fixed underconstrained in range check and added dummy mode to benchmark.go 2023-10-11 00:28:20 -07:00
Uma Roy
e026e73359 Added reduce to benchmark 2023-10-10 22:56:44 -07:00
Uma Roy
90e2f5f1b1 Added benchmark 2023-10-10 22:54:16 -07:00
Uma Roy
1c0235b35a Renamed symbol a bunch in goldilocks, goldilocks tests pass 2023-10-10 22:32:54 -07:00
Uma Roy
07cf7bd857 Upgraded dependencies 2023-10-10 22:15:01 -07:00
Kevin Jue
7bd0035e65
range check inputted plonky2 proof (#29)
* gl

* stage 1 optimizations

* working optimized poseidon

* Fix posedion tests

* in progress gate type refactor

* working gates

* working e2e

* hm'

* hm2

* debug saga continues

* more debugging cry

* more debug

* it finally works

* optimizations

* more optimizations

* new changes

* more optimizations

* more cleanup

* some refactoring

* new files

* flattening of packages

* working commit

* more refactor

* more flattening

* more flattening

* more more refactor

* more optimizations

* more optimizations

* more optimizations

* plonk benchmark

* plonk

* fix r1cs

* resolve kevin's comments

* Update goldilocks/base.go

Co-authored-by: Kevin Jue <kjue235@gmail.com>

* Update goldilocks/base.go

Co-authored-by: Kevin Jue <kjue235@gmail.com>

* Update goldilocks/base.go

Co-authored-by: Kevin Jue <kjue235@gmail.com>

* Update goldilocks/quadratic_extension.go

Co-authored-by: Kevin Jue <kjue235@gmail.com>

* added range check for the inputted proof

* removed the go.mod replace directive

* removed some hacky code

* removed duplicate import

* renamed rangecheckQEVariable to rangecheckQE

* resolved conflict

---------

Co-authored-by: John Guibas <john@succinct.xyz>
2023-07-24 16:18:37 -07:00
John Guibas
b670530e7f
Use optimized goldilocks in codebase (#26)
* gl

* stage 1 optimizations

* working optimized poseidon

* Fix posedion tests

* in progress gate type refactor

* working gates

* working e2e

* hm'

* hm2

* debug saga continues

* more debugging cry

* more debug

* it finally works

* optimizations

* more optimizations

* new changes

* more optimizations

* more cleanup

* some refactoring

* new files

* flattening of packages

* working commit

* more refactor

* more flattening

* more flattening

* more more refactor

* more optimizations

* more optimizations

* more optimizations

* plonk benchmark

* plonk

* fix r1cs

* resolve kevin's comments

* Update goldilocks/base.go

Co-authored-by: Kevin Jue <kjue235@gmail.com>

* Update goldilocks/base.go

Co-authored-by: Kevin Jue <kjue235@gmail.com>

* Update goldilocks/base.go

Co-authored-by: Kevin Jue <kjue235@gmail.com>

* Update goldilocks/quadratic_extension.go

Co-authored-by: Kevin Jue <kjue235@gmail.com>

* fix: resolve kevin's confusion

---------

Co-authored-by: Kevin Jue <kjue235@gmail.com>
2023-07-24 16:08:17 -07:00
jtguibas
a058df6099 small refactor of names 2022-10-10 17:59:55 -07:00
jtguibas
96bfd45884 goldilocks and poseidon 2022-10-07 16:59:02 -07:00