logos-storage/gnark-plonky2-verifier
1
0
Fork 0
mirror of https://github.com/logos-storage/gnark-plonky2-verifier.git synced 2026-01-06 15:13:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

address veridise feedback for V-SCT-VUL-007 and V-SCT-VUL-011 (hasInv needed to be constrained)

Browse Source
This commit is contained in:
Kevin Jue 2023-12-26 07:49:55 -08:00
parent 1a0372621c
commit d241f54f48
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
goldilocks/base.go
View File

@ -224,13 +224,14 @@ func ReduceHint(_ *big.Int, inputs []*big.Int, results []*big.Int) error {
// Computes the inverse of a field element x such that x * x^-1 = 1.
func (p *Chip) Inverse(x Variable) (Variable, frontend.Variable) {
result, err := p.api.Compiler().NewHint(InverseHint, 2, x.Limb)
result, err := p.api.Compiler().NewHint(InverseHint, 1, x.Limb)
if err != nil {
panic(err)
}
inverse := NewVariable(result[0])
hasInv := frontend.Variable(result[1])
isZero := p.api.IsZero(x.Limb)
hasInv := p.api.Sub(1, isZero)
p.RangeCheck(inverse)
product := p.Mul(inverse, x)
@ -260,12 +261,6 @@ func InverseHint(_ *big.Int, inputs []*big.Int, results []*big.Int) error {
result := big.NewInt(0)
results[0] = resultGl.BigInt(result)
hasInvInt64 := int64(0)
if !inputGl.IsZero() {
hasInvInt64 = 1
}
results[1] = big.NewInt(hasInvInt64)
return nil
}