logos-messaging/waku-react
1
0
Fork 0
mirror of https://github.com/logos-messaging/waku-react.git synced 2026-01-05 15:43:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

add TODOs

Browse Source
This commit is contained in:
Sasha 2023-02-23 13:03:02 +01:00
parent 450418db23
commit 554ef2ace8
No known key found for this signature in database
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/useCreateWaku.ts
View File

@ -50,6 +50,7 @@ const useCreateNode = <N extends Waku, T = {}>(
return () => { return () => {
cancelled = true; cancelled = true;
}; };
// TODO: missing any dependencies, it will prevent consecutive update if options change
}, []); }, []);
return { return {

9
src/useStoreMessages.ts
View File

@ -33,12 +33,12 @@ export const useStoreMessages = (
const [messages, setMessage] = React.useState<IDecodedMessage[]>([]); const [messages, setMessage] = React.useState<IDecodedMessage[]>([]);
const pushMessage = React.useCallback( const pushMessage = React.useCallback(
(messages: IDecodedMessage[]): void => { (newMessages: IDecodedMessage[]): void => {
if (!messages || !messages.length) { if (!newMessages || !newMessages.length) {
return; return;
} }
setMessage((prev) => [...prev, ...messages]); setMessage((prev) => [...prev, ...newMessages]);
}, },
[setMessage], [setMessage],
); );
@ -83,7 +83,8 @@ export const useStoreMessages = (
return () => { return () => {
cancelled = true; cancelled = true;
}; };
}, [node, decoder, options, pushMessage, setError, setLoading]); // TODO: missing dependency on options, it will prevent consecutive update if options change
}, [node, decoder, pushMessage, setError, setLoading]);
return { return {
error, error,