From 554ef2ace8dddedae4ad32ed1c81e6314523aebe Mon Sep 17 00:00:00 2001
From: Sasha <oleksandr@status.im>
Date: Thu, 23 Feb 2023 13:03:02 +0100
Subject: [PATCH] add TODOs

---
 src/useCreateWaku.ts    | 1 +
 src/useStoreMessages.ts | 9 +++++----
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/useCreateWaku.ts b/src/useCreateWaku.ts
index a55adbe..57fbf61 100644
--- a/src/useCreateWaku.ts
+++ b/src/useCreateWaku.ts
@@ -50,6 +50,7 @@ const useCreateNode = <N extends Waku, T = {}>(
     return () => {
       cancelled = true;
     };
+    // TODO: missing any dependencies, it will prevent consecutive update if options change
   }, []);
 
   return {
diff --git a/src/useStoreMessages.ts b/src/useStoreMessages.ts
index 239f6bf..7dff9fe 100644
--- a/src/useStoreMessages.ts
+++ b/src/useStoreMessages.ts
@@ -33,12 +33,12 @@ export const useStoreMessages = (
   const [messages, setMessage] = React.useState<IDecodedMessage[]>([]);
 
   const pushMessage = React.useCallback(
-    (messages: IDecodedMessage[]): void => {
-      if (!messages || !messages.length) {
+    (newMessages: IDecodedMessage[]): void => {
+      if (!newMessages || !newMessages.length) {
         return;
       }
 
-      setMessage((prev) => [...prev, ...messages]);
+      setMessage((prev) => [...prev, ...newMessages]);
     },
     [setMessage],
   );
@@ -83,7 +83,8 @@ export const useStoreMessages = (
     return () => {
       cancelled = true;
     };
-  }, [node, decoder, options, pushMessage, setError, setLoading]);
+    // TODO: missing dependency on options, it will prevent consecutive update if options change
+  }, [node, decoder, pushMessage, setError, setLoading]);
 
   return {
     error,