logos-messaging/nim-ffi
1
0
Fork 0
mirror of https://github.com/logos-messaging/nim-ffi.git synced 2026-06-22 09:20:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: pass -d:ffiAllowSignalHandler to direct test builds

Browse Source 
The compile-time guard added in d4c87c1 rejects builds that set
neither -d:noSignalHandler nor -d:ffiAllowSignalHandler. The nimble
tasks already pass the flag, but CI compiles the test files with a
direct `nim c -r`, which bypasses those flags and tripped the guard.
These test binaries own their own process, so opt them into signal
handling explicitly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Ivan FB 2026-06-18 21:20:10 +02:00
parent e22b887d7c
commit a3b80f5f18
No known key found for this signature in database
GPG Key ID: DF0C67A04C543270
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/ci.yml vendored
View File

@ -75,7 +75,7 @@ jobs:
if [ "$RUNNER_OS" == "Windows" ]; then
export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH"
fi
nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN tests/test_alloc.nim
nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN -d:ffiAllowSignalHandler tests/test_alloc.nim
- name: Run FFI context tests (${{ matrix.mm }})
shell: bash
@ -83,7 +83,7 @@ jobs:
if [ "$RUNNER_OS" == "Windows" ]; then
export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH"
fi
nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN tests/test_ffi_context.nim
nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN -d:ffiAllowSignalHandler tests/test_ffi_context.nim
- name: Run GC compatibility tests (${{ matrix.mm }})
shell: bash
@ -91,4 +91,4 @@ jobs:
if [ "$RUNNER_OS" == "Windows" ]; then
export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH"
fi
nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN tests/test_gc_compat.nim
nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN -d:ffiAllowSignalHandler tests/test_gc_compat.nim