From a3b80f5f18f7aff56064d27ef069a47e58d3188a Mon Sep 17 00:00:00 2001 From: Ivan FB Date: Thu, 18 Jun 2026 21:20:10 +0200 Subject: [PATCH] ci: pass -d:ffiAllowSignalHandler to direct test builds The compile-time guard added in d4c87c1 rejects builds that set neither -d:noSignalHandler nor -d:ffiAllowSignalHandler. The nimble tasks already pass the flag, but CI compiles the test files with a direct `nim c -r`, which bypasses those flags and tripped the guard. These test binaries own their own process, so opt them into signal handling explicitly. Co-Authored-By: Claude Opus 4.8 --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ac5f716..f2b38c1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -75,7 +75,7 @@ jobs: if [ "$RUNNER_OS" == "Windows" ]; then export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH" fi - nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN tests/test_alloc.nim + nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN -d:ffiAllowSignalHandler tests/test_alloc.nim - name: Run FFI context tests (${{ matrix.mm }}) shell: bash @@ -83,7 +83,7 @@ jobs: if [ "$RUNNER_OS" == "Windows" ]; then export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH" fi - nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN tests/test_ffi_context.nim + nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN -d:ffiAllowSignalHandler tests/test_ffi_context.nim - name: Run GC compatibility tests (${{ matrix.mm }}) shell: bash @@ -91,4 +91,4 @@ jobs: if [ "$RUNNER_OS" == "Windows" ]; then export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH" fi - nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN tests/test_gc_compat.nim + nim c -r --mm:${{ matrix.mm }} -d:chronicles_log_level=WARN -d:ffiAllowSignalHandler tests/test_gc_compat.nim