mirror of
https://github.com/logos-messaging/logos-messaging-nim.git
synced 2026-08-25 15:31:16 +00:00
Egor Rachkovskii
2fb625f463
The job set NODE_2 but not NODE_1, so the two docker store peers in test_send_lightpush_and_edge.py (S11 and S25) silently fell back to the DEFAULT_NWAKU literal, wakuorg/nwaku:v0.38.1, instead of the image built by this run. Both tests are docker_required, so they run in the subset that does receive node_image; they were the only NODE_1 readers in the suite and the only ones missing out. An empty node_image keeps working: get_env_var treats "" as unset, so the non-docker subset and fork PRs still land on v0.38.1, exactly as NODE_2 already did. DEFAULT_NWAKU is left as the hardcoded literal it is. Nothing reachable from tests/wrappers_tests reads it except as the NODE_1/NODE_2 fallback - src/steps/sharding.py and src/steps/rln.py are its only direct consumers and neither is imported here - so making it env-driven would add a knob with no effect. ADDITIONAL_NODES is likewise unused: its only readers, setup_additional_publishing_nodes and setup_additional_store_nodes, have no callers anywhere in tests-e2e.
51 lines
1.5 KiB
YAML
51 lines
1.5 KiB
YAML
name: e2e-api-tests
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
subset:
|
|
description: "Which wrapper subset to run: 'non-docker' or 'docker'."
|
|
type: string
|
|
required: false
|
|
default: "non-docker"
|
|
node_image:
|
|
description: "Node image used for the docker peers (docker subset only)."
|
|
type: string
|
|
required: false
|
|
default: ""
|
|
|
|
jobs:
|
|
api-e2e:
|
|
runs-on: ubuntu-22.04
|
|
timeout-minutes: 45
|
|
name: api-e2e
|
|
env:
|
|
NODE_1: ${{ inputs.node_image }}
|
|
NODE_2: ${{ inputs.node_image }}
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
|
|
# Consumes the shared library built by ci.yml's `build` job (same run).
|
|
- name: Download liblogosdelivery.so
|
|
uses: actions/download-artifact@v4
|
|
with:
|
|
name: liblogosdelivery
|
|
path: tests-e2e/vendor/logos-delivery-python-bindings/lib
|
|
|
|
- name: Set up Python
|
|
uses: actions/setup-python@v5
|
|
with:
|
|
python-version: '3.12'
|
|
cache: 'pip'
|
|
cache-dependency-path: tests-e2e/requirements.txt
|
|
|
|
- name: Install Python deps
|
|
run: pip install -r tests-e2e/requirements.txt
|
|
|
|
- name: Run API/e2e tests (${{ inputs.subset }} subset)
|
|
working-directory: tests-e2e
|
|
run: |
|
|
echo "docker peer image: ${NODE_2:-public default (DEFAULT_NWAKU)}"
|
|
pytest tests/wrappers_tests -m "${{ inputs.subset == 'docker' && 'docker_required' || 'not docker_required' }}" --reruns 2
|