logos-messaging/logos-messaging-nim
1
0
Fork 0
mirror of https://github.com/logos-messaging/logos-messaging-nim.git synced 2026-07-31 12:33:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(conf): default QUIC off on the messaging path (#4084)

Browse Source 
The structured path was the only place defaulting quicSupport to true
(kernel default is false). Booting that QUIC listener SIGSEGVs in
lsquic setupSSLContext, so keep QUIC opt-in until the transport is
validated.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Igor Sirotin 2026-07-30 21:34:49 +01:00 committed by GitHub
parent ba28e32e58
commit f8b036594e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
logos_delivery/api/conf/messaging_conf.nim
View File

@ -134,7 +134,7 @@ proc toWakuNodeConf*(
conf.websocketPort = self.websocketPort.get(Port(0))
conf.quicPort = self.quicPort.get(Port(0))
conf.websocketSupport = self.websocketSupport.get(false)
conf.quicSupport = self.quicSupport.get(true)
conf.quicSupport = self.quicSupport.get(false)
return ok(conf)

8
tests/api/test_conf.nim
View File

@ -45,27 +45,27 @@ suite "MessagingClientConf - field mapping + transport policy":
kc.numShardsInNetwork == 4
kc.maxMessageSize == "150KiB"
test "messaging transport defaults: ephemeral ports, websocket off, quic on":
test "messaging transport defaults: ephemeral ports, websocket off, quic off":
let kc = MessagingClientConf().toWakuNodeConf(LogosDeliveryMode.Core).valueOr:
raiseAssert error
check:
kc.tcpPort == Port(0)
kc.discv5UdpPort == Port(0)
kc.websocketSupport == false
kc.quicSupport == true
kc.quicSupport == false
test "explicit transport overrides win":
let mc = MessagingClientConf(
p2pTcpPort: Opt.some(Port(1234)),
websocketSupport: Opt.some(true),
quicSupport: Opt.some(false),
quicSupport: Opt.some(true),
)
let kc = mc.toWakuNodeConf(LogosDeliveryMode.Core).valueOr:
raiseAssert error
check:
kc.tcpPort == Port(1234)
kc.websocketSupport == true
kc.quicSupport == false
kc.quicSupport == true
suite "MessagingClientConf - preset resolution":
test "resolvePreset lifts only messaging-exclusive fields, not kernel-mirrored ones":