logos-messaging/logos-messaging-nim
1
0
Fork 0
mirror of https://github.com/logos-messaging/logos-messaging-nim.git synced 2026-07-31 12:33:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(conf): add localStoragePath to MessagingClientConf (#4083)

Browse Source 
The structured shapes had no way to set the node's storage directory:
localStoragePath is kernel-only and the structured parser rejects bare
kernel fields. Hosts (logos-delivery-module) inject a per-instance path
and need a place the structured grammar accepts.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Igor Sirotin 2026-07-30 21:32:35 +01:00 committed by GitHub
parent 504336efdb
commit ba28e32e58
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
logos_delivery/api/conf/messaging_conf.nim
View File

@ -45,6 +45,8 @@ type MessagingClientConf* = object
## Store retention policy (e.g. "time:3600;size:1GB").
storeMaxNumDbConnections* {.name: "store-max-num-db-connections".}: Opt[int]
## Maximum number of simultaneous store database connections.
localStoragePath* {.name: "local-storage-path".}: Opt[string]
## Path to store local data.
logLevel* {.name: "log-level".}: Opt[logging.LogLevel]
## Process log level (TRACE..FATAL); applied by the kernel on node creation.
logFormat* {.name: "log-format".}: Opt[logging.LogFormat]
@ -98,6 +100,8 @@ proc toWakuNodeConf*(
conf.storeMaxNumDbConnections = self.storeMaxNumDbConnections.get()
if self.storenode.isSome():
conf.storenode = self.storenode.get()
if self.localStoragePath.isSome():
conf.localStoragePath = self.localStoragePath.get()
if self.clusterId.isSome():
conf.clusterId = self.clusterId

7
tests/api/test_conf.nim
View File

@ -154,6 +154,13 @@ suite "parseLogosDeliveryConf - JSON parsing":
WakuNodeConf(lc.kernelConf).clusterId == Opt.some(7'u16) # kernel field
lc.messagingConf.get().reliabilityEnabled == Opt.some(true) # messaging-only
test "localStoragePath override maps to the kernel":
let lc = parseLogosDeliveryConf(
"""{"mode": "Core", "messagingOverrides": {"localStoragePath": "/tmp/inst-1/data"}}"""
).valueOr:
raiseAssert error
check WakuNodeConf(lc.kernelConf).localStoragePath == "/tmp/inst-1/data"
test "messaging overrides are recorded verbatim, unset fields left none":
let lc = parseLogosDeliveryConf("""{"messagingOverrides": {"clusterId": 7}}""").valueOr:
raiseAssert error