logos-messaging/logos-messaging-interop-tests
1
0
Fork 0
mirror of https://github.com/logos-messaging/logos-messaging-interop-tests.git synced 2026-07-09 09:59:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: port Nim checksum fix to test_common.yml

Browse Source 
PR #188 fixed the locked-Nim checksum mismatch when building
liblogosdelivery, but only in pr_tests.yml. The scheduled
"master Nim -> Nim Waku Interop Tests" job runs test_common.yml,
which still installs an unpinned nimble (recomputes the locked Nim
checksum differently) and runs a bare `nimble install -y` that pulls
Nim from the lock. Both reproduce the same mismatch, so the daily run
keeps failing.

Apply the same two #188 changes here: pin nimble@0.22.3 (the nimble
that generated logos-delivery's nimble.lock) and drop the redundant
`nimble install -y` + `make setup`, relying on `make liblogosdelivery`
whose `nimble setup --localdeps` prerequisite resolves the deps.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Ivan FB 2026-06-05 11:01:40 +02:00
parent ec86cc4775
commit 3dff264826
No known key found for this signature in database
GPG Key ID: DF0C67A04C543270
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
.github/workflows/test_common.yml vendored
View File

@ -117,6 +117,10 @@ jobs:
echo "$HOME/.nimble/bin" >> "$GITHUB_PATH"
export PATH="$HOME/.nimble/bin:$PATH"
choosenim 2.2.4
# Pin the nimble that generated logos-delivery's nimble.lock. A newer
# nimble recomputes the locked Nim package checksum differently, which
# makes `nimble setup --localdeps` abort with a checksum mismatch.
(cd /tmp && nimble install "nimble@0.22.3" -y)
nim --version
nimble --version
@ -137,13 +141,10 @@ jobs:
ln -sf waku.nimble waku.nims
# install Nim deps
nimble install -y
# do the real setup, do not fake .nimble-setup
make setup
# now build the shared library
# `make liblogosdelivery` resolves the locked deps via
# `nimble setup --localdeps` (build-deps prerequisite); a bare
# `nimble install -y` here is redundant and pulls Nim from the lock,
# which is what triggered the checksum mismatch.
make liblogosdelivery
SO_PATH="$(find . -type f -name 'liblogosdelivery.so' | head -n 1)"