From 3dff2648268adc71f540207dc4cabd4ebc21fee4 Mon Sep 17 00:00:00 2001 From: Ivan FB Date: Fri, 5 Jun 2026 11:01:40 +0200 Subject: [PATCH] ci: port Nim checksum fix to test_common.yml PR #188 fixed the locked-Nim checksum mismatch when building liblogosdelivery, but only in pr_tests.yml. The scheduled "master Nim -> Nim Waku Interop Tests" job runs test_common.yml, which still installs an unpinned nimble (recomputes the locked Nim checksum differently) and runs a bare `nimble install -y` that pulls Nim from the lock. Both reproduce the same mismatch, so the daily run keeps failing. Apply the same two #188 changes here: pin nimble@0.22.3 (the nimble that generated logos-delivery's nimble.lock) and drop the redundant `nimble install -y` + `make setup`, relying on `make liblogosdelivery` whose `nimble setup --localdeps` prerequisite resolves the deps. Co-Authored-By: Claude Opus 4.8 --- .github/workflows/test_common.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test_common.yml b/.github/workflows/test_common.yml index 695b3e019..9c35b562a 100644 --- a/.github/workflows/test_common.yml +++ b/.github/workflows/test_common.yml @@ -117,6 +117,10 @@ jobs: echo "$HOME/.nimble/bin" >> "$GITHUB_PATH" export PATH="$HOME/.nimble/bin:$PATH" choosenim 2.2.4 + # Pin the nimble that generated logos-delivery's nimble.lock. A newer + # nimble recomputes the locked Nim package checksum differently, which + # makes `nimble setup --localdeps` abort with a checksum mismatch. + (cd /tmp && nimble install "nimble@0.22.3" -y) nim --version nimble --version @@ -137,13 +141,10 @@ jobs: ln -sf waku.nimble waku.nims - # install Nim deps - nimble install -y - - # do the real setup, do not fake .nimble-setup - make setup - - # now build the shared library + # `make liblogosdelivery` resolves the locked deps via + # `nimble setup --localdeps` (build-deps prerequisite); a bare + # `nimble install -y` here is redundant and pulls Nim from the lock, + # which is what triggered the checksum mismatch. make liblogosdelivery SO_PATH="$(find . -type f -name 'liblogosdelivery.so' | head -n 1)"