logos-messaging/libchat
1
0
Fork 0
mirror of https://github.com/logos-messaging/libchat.git synced 2026-07-09 01:19:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update constructor calls

Browse Source
This commit is contained in:
Jazz Turner-Baggs 2026-07-07 15:13:17 -07:00
parent 8997957639
commit ccaa0806b4
No known key found for this signature in database
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/conversations/src/core.rs
View File

@ -226,7 +226,7 @@ impl<'a, S: ExternalServices + 'static> Core<S> {
&mut self,
participants: &[IdentIdRef],
) -> Result<ConversationId, ChatError> {
self.create_group_convo_v2(participants)
self.create_group_convo_v2(participants, "UnamedGroup", "")
}
pub fn create_group_convo_v1(
@ -255,11 +255,13 @@ impl<'a, S: ExternalServices + 'static> Core<S> {
pub fn create_group_convo_v2(
&mut self,
participants: &[IdentIdRef],
name: &str,
desc: &str,
) -> Result<ConversationId, ChatError> {
// TODO: (P1) Ensure errors are handled properly. This is a high chance for
// desynchronized state: MlsGroup persistence, conversation persistence, and
// invite delivery all happen separately.
let mut convo = GroupV2Convo::new(&mut self.services)?;
let mut convo = GroupV2Convo::new(&mut self.services, name, desc)?;
convo.add_member(&mut self.services, participants)?;
let convo_id = convo.id().to_string();

8
core/integration_tests_core/tests/test_group_v2.rs
View File

@ -18,7 +18,7 @@ fn groupv2_2way_roundtrip() {
let particpants = &[&harness.raya().addr()];
let convo_id = harness
.saro()
.create_group_convo_v2(particpants)
.create_group_convo_v2(particpants, "", "")
.expect("saro create group");
// Carry the invite through (commit, WelcomeReady, routing to Raya's inbox,
@ -56,7 +56,7 @@ fn core_client() {
let particpants = &[&harness.raya().addr()];
let convo_id = harness
.saro()
.create_group_convo_v2(particpants)
.create_group_convo_v2(particpants, "", "")
.expect("Saro create");
// Carry the invite through (commit, WelcomeReady, routing to Raya's inbox,
@ -114,7 +114,7 @@ fn core_client_batch_add() {
let particpants = &[&harness.raya().addr(), &harness.pax().addr()];
harness
.saro()
.create_group_convo_v2(particpants)
.create_group_convo_v2(particpants, "", "")
.expect("Saro create");
// Carry the invite through (commit, WelcomeReady, routing to Raya's inbox,
@ -144,7 +144,7 @@ fn core_client_four_members_two_epochs() {
let particpants = &[&harness.raya().addr(), &harness.pax().addr()];
let convo_id = harness
.saro()
.create_group_convo_v2(particpants)
.create_group_convo_v2(particpants, "", "")
.expect("Saro create");
// Carry the invite through (commit, WelcomeReady, routing to Raya's inbox,