From ccaa0806b4bb60e807dfed5f445103706554d09d Mon Sep 17 00:00:00 2001 From: Jazz Turner-Baggs <473256+jazzz@users.noreply.github.com> Date: Tue, 7 Jul 2026 15:13:17 -0700 Subject: [PATCH] Update constructor calls --- core/conversations/src/core.rs | 6 ++++-- core/integration_tests_core/tests/test_group_v2.rs | 8 ++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/core/conversations/src/core.rs b/core/conversations/src/core.rs index 495b1e2..31814e8 100644 --- a/core/conversations/src/core.rs +++ b/core/conversations/src/core.rs @@ -226,7 +226,7 @@ impl<'a, S: ExternalServices + 'static> Core { &mut self, participants: &[IdentIdRef], ) -> Result { - self.create_group_convo_v2(participants) + self.create_group_convo_v2(participants, "UnamedGroup", "") } pub fn create_group_convo_v1( @@ -255,11 +255,13 @@ impl<'a, S: ExternalServices + 'static> Core { pub fn create_group_convo_v2( &mut self, participants: &[IdentIdRef], + name: &str, + desc: &str, ) -> Result { // TODO: (P1) Ensure errors are handled properly. This is a high chance for // desynchronized state: MlsGroup persistence, conversation persistence, and // invite delivery all happen separately. - let mut convo = GroupV2Convo::new(&mut self.services)?; + let mut convo = GroupV2Convo::new(&mut self.services, name, desc)?; convo.add_member(&mut self.services, participants)?; let convo_id = convo.id().to_string(); diff --git a/core/integration_tests_core/tests/test_group_v2.rs b/core/integration_tests_core/tests/test_group_v2.rs index f000423..c7b3d26 100644 --- a/core/integration_tests_core/tests/test_group_v2.rs +++ b/core/integration_tests_core/tests/test_group_v2.rs @@ -18,7 +18,7 @@ fn groupv2_2way_roundtrip() { let particpants = &[&harness.raya().addr()]; let convo_id = harness .saro() - .create_group_convo_v2(particpants) + .create_group_convo_v2(particpants, "", "") .expect("saro create group"); // Carry the invite through (commit, WelcomeReady, routing to Raya's inbox, @@ -56,7 +56,7 @@ fn core_client() { let particpants = &[&harness.raya().addr()]; let convo_id = harness .saro() - .create_group_convo_v2(particpants) + .create_group_convo_v2(particpants, "", "") .expect("Saro create"); // Carry the invite through (commit, WelcomeReady, routing to Raya's inbox, @@ -114,7 +114,7 @@ fn core_client_batch_add() { let particpants = &[&harness.raya().addr(), &harness.pax().addr()]; harness .saro() - .create_group_convo_v2(particpants) + .create_group_convo_v2(particpants, "", "") .expect("Saro create"); // Carry the invite through (commit, WelcomeReady, routing to Raya's inbox, @@ -144,7 +144,7 @@ fn core_client_four_members_two_epochs() { let particpants = &[&harness.raya().addr(), &harness.pax().addr()]; let convo_id = harness .saro() - .create_group_convo_v2(particpants) + .create_group_convo_v2(particpants, "", "") .expect("Saro create"); // Carry the invite through (commit, WelcomeReady, routing to Raya's inbox,