logos-logoscore-cli/tests/test_integration.cpp

// Daemon-backed integration tests.
//
// Unlike test_cli.cpp (which only pokes the binary in no-daemon / inline
// mode), these spin up a *real* logosctl daemon in the background against
// a real test-module directory and drive it through the client subcommands
// — the same shape as logos-logoscore-py's integration suite.
//
// Coverage:
//   * Error paths (ErrorPathTest): unknown-module load, calling methods on
//     unknown / unloaded modules, unknown method on a loaded module,
//     module-info on an unknown module, and — since core_service started
//     reading the SDK's error channel instead of inferring failure from a
//     null result — that a MISSING method, a FAILED call and a provider
//     REFUSAL each report their own code, the last of which flips a
//     user-visible exit code from 0 to 4. One fresh daemon per test (the
//     "module known but not loaded" precondition needs pristine state).
//   * Full test_basic_module API + concurrency (LoadedModuleTest): every
//     Q_INVOKABLE return/parameter type (void, bool, int, QString,
//     LogosResult, QVariant, QJsonArray, QStringList), 0..5-arg fan-out,
//     the async delay helper, the event subscription round-trip via
//     `watch`, and many simultaneous clients hitting one daemon. The
//     whole suite shares ONE daemon (SetUpTestSuite) with the module
//     loaded once — per-test daemons made the check take many minutes.
//     Mirrors logos-logoscore-py/tests/integration/test_basic_module_methods.py
//     and logos-test-modules/test-basic-module — keep them in sync.
//
// Negative `call`/`module-info` cases: this CLI/SDK revision has no fast
// "not loaded / not found" guard — the request rides the SDK's ~100s RPC
// timeout (surfacing as RPC_FAILED / non-zero exit, the exact code not
// stable across revisions). So those are `timeout`-bounded and asserted
// as "must not succeed" rather than waiting ~100s for an exact code.
//
// Three of them ARE pinned to an exact code now, because they no longer depend
// on a timeout: an unknown method on a LOADED module resolves against the
// module's own method list (METHOD_NOT_FOUND), a rejected token comes back on
// the error channel (METHOD_FAILED + error.code "unauthorized"), and a provider
// that ran and refused comes back through the RESULT and is folded
// (METHOD_FAILED + error.code "dispatch_failed"). All three answer in well
// under a second, and the last is pinned to the process EXIT CODE as well,
// since that is what the change alters for a user.
//
// Requires LOGOSCTL_BINARY + LOGOSCTL_TEST_MODULES_DIR (the flake's
// `tests` check wires both, plus LOGOS_HOST_PATH so modules can load).
// Absent ⇒ everything GTEST_SKIPs so the suite stays green locally.

#include <gtest/gtest.h>

#include <logos_json.h>

#include <algorithm>
#include <cerrno>
#include <chrono>
#include <csignal>
#include <cstdio>
#include <cstdlib>
#include <filesystem>
#include <fstream>
#include <map>
#include <optional>
#include <sstream>
#include <string>
#include <thread>
#include <vector>

#include <fcntl.h>
#include <sys/socket.h>
#include <sys/stat.h>
#include <sys/un.h>
#include <sys/wait.h>
#include <unistd.h>

namespace fs = std::filesystem;

namespace {

std::string slurp(const fs::path& p)
{
    std::ifstream ifs(p);
    if (!ifs) return {};
    return std::string((std::istreambuf_iterator<char>(ifs)),
                       std::istreambuf_iterator<char>());
}

// Pull the last well-formed JSON object out of captured client output.
// `call --json` prints one compact envelope line on stdout, but a stray
// qWarning on stderr (captured via 2>&1) could precede it — scan from
// the end for the first line that parses as a JSON object.
nlohmann::json lastJsonObject(const std::string& out)
{
    std::vector<std::string> lines;
    std::string line;
    for (char c : out) {
        if (c == '\n') { lines.push_back(line); line.clear(); }
        else line += c;
    }
    if (!line.empty()) lines.push_back(line);
    for (auto it = lines.rbegin(); it != lines.rend(); ++it) {
        if (it->empty()) continue;
        try {
            nlohmann::json d = nlohmann::json::parse(*it);
            if (d.is_object()) return d;
        } catch (...) {}
    }
    return nlohmann::json::object();
}

// A real logosctl daemon in an isolated config/HOME, plus helpers to
// drive clients against it. Not a gtest fixture so it can be owned
// per-test (error paths) or once per suite (the API/concurrency matrix).
class LogosctlDaemon {
public:
    bool envReady(std::string& why) {
        const char* b = std::getenv("LOGOSCTL_BINARY");
        const char* m = std::getenv("LOGOSCTL_TEST_MODULES_DIR");
        if (!b || !fs::exists(b)) { why = "LOGOSCTL_BINARY not set/found"; return false; }
        if (!m || !fs::exists(m)) { why = "LOGOSCTL_TEST_MODULES_DIR not set/found"; return false; }
        binary     = fs::canonical(b);
        modulesDir = fs::canonical(m);
        return true;
    }

    void start(const std::string& tag) {
        base      = fs::temp_directory_path() / ("logosctl_it_" + tag + "_" + std::to_string(getpid()));
        configDir = base / "config";
        homeDir   = base / "home";
        daemonLog = base / "daemon.log";
        fs::create_directories(configDir);
        fs::create_directories(homeDir);
        if (!socketDir.empty()) fs::create_directories(socketDir);

        // logosctl has no -m: module directories are session configuration.
        // Write the config the daemon will read rather than passing a flag it
        // would reject (and then fail to start over).
        fs::create_directories(configDir / "daemon");
        {
            std::ofstream cfg(configDir / "daemon" / "config.yaml", std::ios::trunc);
            cfg << "version: 2\n"
                << "modules_dirs:\n"
                << "  - \"" << modulesDir.string() << "\"\n";
            if (!extraConfig.empty()) cfg << extraConfig;
        }
        pid = spawnBg({"daemon", "start"}, daemonLog);
    }

    // fork + setsid + exec a logosctl subprocess (daemon or watch) with
    // this daemon's isolated env; stdout+stderr → logFile, stdin
    // detached. setsid ⇒ the pid leads a process group so the whole
    // tree (incl. logos_host children) tears down together.
    pid_t spawnBg(const std::vector<std::string>& cliArgs, const fs::path& logFile) {
        pid_t p = fork();
        if (p < 0) return -1;
        if (p == 0) {
            setsid();
            setenv("LOGOSCTL_CONFIG_DIR", configDir.c_str(), 1);
            setenv("HOME", homeDir.c_str(), 1);
            // Daemon-side knobs. Deliberately NOT applied to run() below:
            // these configure the process under test, not the client that
            // drives it.
            for (const auto& kv : extraEnv)
                setenv(kv.first.c_str(), kv.second.c_str(), 1);
            // QLocalServer resolves a bare server name against QDir::tempPath(),
            // which honours $TMPDIR — so this decides where the node's sockets
            // land. Tests that assert on socket files set it to get a private
            // directory instead of sharing the machine-wide temp dir (where a
            // dev box's leftovers would swamp the assertions).
            if (!socketDir.empty()) setenv("TMPDIR", socketDir.c_str(), 1);
            FILE* lf = std::fopen(logFile.c_str(), "w");
            if (lf) { dup2(fileno(lf), STDOUT_FILENO); dup2(fileno(lf), STDERR_FILENO); }
            int dn = open("/dev/null", O_RDONLY);
            if (dn >= 0) dup2(dn, STDIN_FILENO);
            std::vector<char*> argv;
            argv.push_back(const_cast<char*>("logosctl"));
            for (const auto& a : cliArgs) argv.push_back(const_cast<char*>(a.c_str()));
            argv.push_back(nullptr);
            execv(binary.c_str(), argv.data());
            dprintf(STDERR_FILENO, "execv failed: errno=%d\n", errno);
            _exit(127);
        }
        return p;
    }

    bool waitReady() {
        // Bound each probe: a partially-started daemon (client config
        // written, RPC not yet answering) would otherwise make `status`
        // block the full SDK timeout per iteration, blowing the ~20s
        // readiness budget into minutes.
        for (int i = 0; i < 200; ++i) {
            int st = 0;
            if (pid > 0 && waitpid(pid, &st, WNOHANG) == pid) { pid = -1; return false; }
            if (run("status", nullptr, /*timeoutSecs=*/5) == 0) return true;
            std::this_thread::sleep_for(std::chrono::milliseconds(100));
        }
        return false;
    }

    // Run `logosctl <args> --json` against this daemon. timeoutSecs>0
    // wraps it in coreutils `timeout` (exit 124 if it fires). Safe to
    // call concurrently from multiple threads — each call is its own
    // process and FILE*, sharing no mutable state on this object.
    int run(const std::string& args, std::string* out, int timeoutSecs = 0) const {
        std::string cmd =
            "LOGOSCTL_CONFIG_DIR='" + configDir.string() + "' " +
            "HOME='" + homeDir.string() + "' ";
        // The client dials the same bare socket name, so it must resolve
        // QDir::tempPath() to the same place the daemon bound in.
        if (!socketDir.empty()) cmd += "TMPDIR='" + socketDir.string() + "' ";
        if (timeoutSecs > 0) cmd += "timeout " + std::to_string(timeoutSecs) + " ";
        cmd += "'" + binary.string() + "' " + args + " --json 2>&1";
        FILE* pipe = popen(cmd.c_str(), "r");
        if (!pipe) return -1;
        char buf[256];
        std::string captured;
        while (fgets(buf, sizeof(buf), pipe)) captured += buf;
        if (out) *out = captured;
        int status = pclose(pipe);
        return WEXITSTATUS(status);
    }

    void killGroup(pid_t p) {
        if (p <= 0) return;
        kill(-p, SIGTERM);
        for (int i = 0; i < 30; ++i) {
            int st = 0;
            if (waitpid(p, &st, WNOHANG) == p) return;
            std::this_thread::sleep_for(std::chrono::milliseconds(100));
        }
        kill(-p, SIGKILL);
        int st = 0;
        waitpid(p, &st, 0);
    }

    void shutdown() {
        killGroup(pid);
        pid = -1;
        std::error_code ec;
        if (!base.empty()) fs::remove_all(base, ec);
    }

    fs::path binary, modulesDir, base, configDir, homeDir, daemonLog;
    // Optional private socket directory ($TMPDIR for the node). Empty ⇒
    // inherit the ambient temp dir, which is what every non-socket test wants.
    fs::path socketDir;
    // Extra YAML appended to the daemon's config.yaml, verbatim. Set before
    // start(). logosctl has no daemon flags — the session's config IS the
    // surface — so this is how a test varies one daemon setting. The
    // access-policy tests are the reason it exists: the SAME binaries, the
    // SAME modules, with the policy as the only variable between two runs.
    std::string extraConfig;
    // Extra environment for the DAEMON process only (see spawnBg) — the knob
    // the shutdown test needs, which is not a config-file setting.
    std::map<std::string, std::string> extraEnv;
    pid_t    pid = -1;
};

// ── socket-file helpers (shared by the socket-lifecycle tests) ─────────────

// Unix socket paths are hard-capped by sockaddr_un::sun_path — 104 bytes on
// macOS, 108 on Linux — and the node appends "/logos_<module>_<12 hex>" to
// $TMPDIR. The longest name in play is "logos_capability_module_" + 12 hex
// = 36 chars, so the directory itself has to stay well under the cap or every
// listen() fails with HostNotFoundError.
//
// macOS's default temp dir (/var/folders/<18 chars>/<18 chars>/T) is already
// ~50 chars, and a per-test subdirectory under it overflows — so prefer the
// ambient temp dir only while it fits, and fall back to a short /tmp path.
// Returns an empty path when neither fits, which the fixture turns into a skip
// rather than a confusing bind failure.
constexpr std::size_t kSunPathCap  = 104;  // the stricter of the two platforms
constexpr std::size_t kLongestName = 40;   // "/logos_capability_module_<12hex>" + slack

fs::path shortSocketDir(const std::string& tag)
{
    const std::string leaf = "lsit_" + std::to_string(getpid()) + "_" + tag;
    for (const fs::path& parent : {fs::temp_directory_path(), fs::path("/tmp")}) {
        const fs::path cand = parent / leaf;
        if (cand.string().size() + kLongestName < kSunPathCap) return cand;
    }
    return {};
}

// Names of the unix-socket files in `dir` starting with "logos_".
// Only S_ISSOCK entries count, so a regular file sharing the prefix is
// excluded from the tally the assertions are written against.
std::vector<std::string> socketNames(const fs::path& dir)
{
    std::vector<std::string> out;
    std::error_code ec;
    for (const auto& e : fs::directory_iterator(dir, ec)) {
        const std::string name = e.path().filename().string();
        if (name.rfind("logos_", 0) != 0) continue;
        struct stat st{};
        if (::lstat(e.path().c_str(), &st) != 0) continue;
        if (S_ISSOCK(st.st_mode)) out.push_back(name);
    }
    std::sort(out.begin(), out.end());
    return out;
}

// Bind a unix socket at `p` and listen. Returns the fd (>=0) or -1.
int bindListen(const fs::path& p)
{
    int fd = ::socket(AF_UNIX, SOCK_STREAM, 0);
    if (fd < 0) return -1;
    sockaddr_un addr{};
    addr.sun_family = AF_UNIX;
    const std::string s = p.string();
    if (s.size() >= sizeof(addr.sun_path)) { ::close(fd); return -1; }
    std::snprintf(addr.sun_path, sizeof(addr.sun_path), "%s", s.c_str());
    ::unlink(s.c_str());
    if (::bind(fd, reinterpret_cast<sockaddr*>(&addr), sizeof(addr)) != 0
        || ::listen(fd, 1) != 0) {
        ::close(fd);
        return -1;
    }
    return fd;
}

// Reap a spawned subprocess (e.g. `watch`) on every exit path —
// including a fatal gtest assertion that `return`s out of the test —
// so background watchers can't leak past the test.
struct ProcGuard {
    LogosctlDaemon* d;
    pid_t pid;
    ~ProcGuard() { if (d && pid > 0) d->killGroup(pid); }
};

constexpr int kNegativeBudgetSecs = 12;

} // namespace

// ═══════════════════════════════════════════════════════════════════════════
// Error paths — fresh daemon per test (needs pristine "not loaded" state)
// ═══════════════════════════════════════════════════════════════════════════

class ErrorPathTest : public ::testing::Test {
protected:
    LogosctlDaemon d;

    void SetUp() override {
        std::string why;
        if (!d.envReady(why)) GTEST_SKIP() << why;
        d.start(::testing::UnitTest::GetInstance()->current_test_info()->name());
        ASSERT_TRUE(d.waitReady())
            << "daemon did not become reachable.\n--- daemon log ---\n"
            << slurp(d.daemonLog);
    }
    void TearDown() override { d.shutdown(); }
};

TEST_F(ErrorPathTest, NoLoadNegativePaths) {
    std::string out;

    // Daemon reachable + module discoverable but not loaded.
    ASSERT_EQ(d.run("status", &out), 0) << out;
    ASSERT_EQ(d.run("list-modules", &out), 0) << out;
    EXPECT_NE(out.find("test_basic"), std::string::npos)
        << "test_basic_module should be discoverable.\n" << out;
    ASSERT_EQ(d.run("list-modules --loaded", &out), 0) << out;
    EXPECT_EQ(out.find("test_basic_module"), std::string::npos)
        << "module must start unloaded.\n" << out;

    // Loading an unknown module must fail.
    EXPECT_NE(d.run("load-module definitely_not_a_real_module_xyz",
                     &out, kNegativeBudgetSecs), 0)
        << "load-module unknown should not succeed.\n" << out;

    // Calling a method on an unknown module must fail.
    EXPECT_NE(d.run("call definitely_not_a_real_module_xyz whatever",
                     &out, kNegativeBudgetSecs), 0)
        << "call on unknown module should not succeed.\n" << out;

    // Calling a method on a known-but-unloaded module must fail.
    EXPECT_NE(d.run("call test_basic_module returnTrue",
                     &out, kNegativeBudgetSecs), 0)
        << "call on unloaded module should not succeed.\n" << out;

    // module-info on an unknown module must fail.
    EXPECT_NE(d.run("module-info definitely_not_a_real_module_xyz",
                     &out, kNegativeBudgetSecs), 0)
        << "module-info on unknown module should not succeed.\n" << out;
}

// Regression for #59: the version, sourced from each module's embedded
// metadata, must appear in list-modules / module-info / load-module — and,
// critically, for modules that are merely KNOWN (not yet loaded), since that
// reads from on-disk metadata rather than a running plugin. test_basic_module
// declares version 1.0.0 in its metadata.json.
TEST_F(ErrorPathTest, ReportsModuleVersion) {
    std::string out;
    const std::string kVersion = "\"version\":\"1.0.0\"";

    // Unloaded module: version is read from metadata, so it is present even
    // before the module is loaded.
    ASSERT_EQ(d.run("list-modules", &out), 0) << out;
    EXPECT_NE(out.find("test_basic_module"), std::string::npos) << out;
    EXPECT_NE(out.find(kVersion), std::string::npos)
        << "list-modules must report the metadata version for a known module.\n"
        << out;

    ASSERT_EQ(d.run("module-info test_basic_module", &out), 0) << out;
    EXPECT_NE(out.find(kVersion), std::string::npos)
        << "module-info must report the module version.\n" << out;
    // module-info is now backed by the generic modules-info dump, so the
    // dependency graph is reported too (test_basic_module has no deps).
    EXPECT_NE(out.find("\"dependencies\""), std::string::npos)
        << "module-info must include the dependencies array.\n" << out;
    // Uptime is loaded-only: an unloaded module reports no uptime_seconds.
    EXPECT_EQ(out.find("uptime_seconds"), std::string::npos)
        << "unloaded module-info must not report uptime_seconds.\n" << out;

    // Loading it returns the version too, and list-modules keeps reporting it.
    ASSERT_EQ(d.run("load-module test_basic_module", &out, kNegativeBudgetSecs), 0)
        << "test_basic_module must load (LOGOS_HOST_PATH wired?).\n" << out;
    EXPECT_NE(out.find(kVersion), std::string::npos)
        << "load-module response must include the version.\n" << out;

    ASSERT_EQ(d.run("list-modules", &out), 0) << out;
    EXPECT_NE(out.find(kVersion), std::string::npos)
        << "list-modules must still report the version once loaded.\n" << out;

    // Once loaded, uptime is derived from the load timestamp and reported.
    ASSERT_EQ(d.run("module-info test_basic_module", &out), 0) << out;
    EXPECT_NE(out.find("uptime_seconds"), std::string::npos)
        << "loaded module-info must report uptime_seconds.\n" << out;
}

TEST_F(ErrorPathTest, UnknownMethodOnLoadedModule) {
    std::string out;
    ASSERT_EQ(d.run("load-module test_basic_module", &out), 0)
        << "test_basic_module must load (LOGOS_HOST_PATH wired?).\n" << out
        << "\n--- daemon log ---\n" << slurp(d.daemonLog);

    EXPECT_NE(d.run("call test_basic_module thisMethodDoesNotExist",
                     &out, kNegativeBudgetSecs), 0)
        << "unknown method on a loaded module should not succeed.\n" << out;

    // …and it says WHY. A provider answers an unknown method with a bare null
    // and no transport error (logos_protocol.h: "NOT reported, and it is not an
    // oversight"), so this envelope can only come from core_service asking the
    // module for its method list — which makes it the end-to-end proof that the
    // introspection fallback works against a real module over a real transport.
    // Before the error-channel switch this read METHOD_FAILED / "Call to
    // test_basic_module.thisMethodDoesNotExist failed." with no list.
    const nlohmann::json env = lastJsonObject(out);
    EXPECT_EQ(env.value("code", std::string{}), "METHOD_NOT_FOUND") << out;
    // .value(), not operator[]: on a const json a missing key is UB, and this
    // assertion has to survive the envelope NOT carrying the field.
    const nlohmann::json avail =
        env.value("available_methods", nlohmann::json());
    ASSERT_TRUE(avail.is_array()) << out;
    EXPECT_NE(std::find(avail.begin(), avail.end(), nlohmann::json("returnTrue")),
              avail.end())
        << "available_methods must be the module's real list.\n" << out;
    EXPECT_EQ(std::find(avail.begin(), avail.end(),
                        nlohmann::json("thisMethodDoesNotExist")),
              avail.end()) << out;

    // A real method still works fast — proves the failure above was
    // method-scoped, not a wedged daemon.
    ASSERT_EQ(d.run("call test_basic_module returnTrue", &out), 0) << out;
    EXPECT_NE(out.find("true"), std::string::npos) << out;
}

// A call that genuinely FAILED still reports METHOD_FAILED — and now names the
// transport's own reason, because the reason arrives on an error channel rather
// than being inferred from the value.
//
// The vehicle is a self-call: core_service refuses a token it did not mint, so
// this is a fast, deterministic "unauthorized" with no waiting on a timeout.
// The value it comes back with is null — the SAME null a method that returns
// nothing would produce — so this and a legitimately-null return are exactly
// the pair that used to be indistinguishable.
TEST_F(ErrorPathTest, FailedCallReportsTheErrorChannelNotTheValue) {
    std::string out;
    ASSERT_NE(d.run("call core_service getModuleStats", &out,
                    kNegativeBudgetSecs), 0)
        << "a rejected call must not report success.\n" << out;

    const nlohmann::json env = lastJsonObject(out);
    EXPECT_EQ(env.value("status", std::string{}), "error") << out;
    EXPECT_EQ(env.value("code", std::string{}), "METHOD_FAILED") << out;
    // The diagnosis, machine-readable. Empty before the switch: the old code
    // had only a null value to look at and nothing to say about it.
    const nlohmann::json diag = env.value("error", nlohmann::json());
    ASSERT_TRUE(diag.is_object()) << out;
    EXPECT_EQ(diag.value("code", std::string{}), "unauthorized") << out;
    EXPECT_FALSE(diag.value("message", std::string{}).empty()) << out;
}

// The whole point, on a live transport: two calls that both come back null are
// now told apart, and by different means — one by the error channel, one by
// asking the module what it exposes.
//
// What is NOT covered here, deliberately and worth knowing: a method that
// legitimately RETURNS null. No module in the fixture set has one — the
// qt-generator refuses an optional return outright, and nothing declares
// `-> any` and answers null. That case is pinned in tests/test_call_envelope.cpp
// instead, where the decision itself lives.
TEST_F(ErrorPathTest, MissingMethodAndFailedCallAreDistinguishable) {
    std::string out;
    ASSERT_EQ(d.run("load-module test_basic_module", &out), 0) << out;

    ASSERT_NE(d.run("call test_basic_module thisMethodDoesNotExist", &out,
                    kNegativeBudgetSecs), 0) << out;
    const std::string missing = lastJsonObject(out).value("code", std::string{});

    ASSERT_NE(d.run("call core_service getModuleStats", &out,
                    kNegativeBudgetSecs), 0) << out;
    const std::string failed = lastJsonObject(out).value("code", std::string{});

    EXPECT_EQ(missing, "METHOD_NOT_FOUND");
    EXPECT_EQ(failed,  "METHOD_FAILED");
    EXPECT_NE(missing, failed)
        << "these collapsed into one code before core_service read the error "
           "channel; keeping them apart is the entire point.";
}

// THE THIRD KIND OF FAILURE, end to end: a provider that RAN and REFUSED.
//
// This one does not travel on the transport's error channel at all. A strict
// decode failure inside the generated dispatch answers the canonical
// {"code":"dispatch_failed","message":...,"origin":...} envelope as its RESULT
// value (logos-protocol cpp/logos_codec.h, "DECODE STRICTNESS"; the reason it is
// not folded by the transport is stated at cpp/logos_protocol.h, under
// lp_invoke_async). core_service has to recognise it and fold it into the error
// channel itself — core_service::callEnvelope, via dispatchRejection
// (src/core_service/call_envelope.cpp).
//
// WHY THIS TEST EXISTS. The fold changes a USER-VISIBLE exit code: a refusal
// used to be reported as a SUCCESSFUL call whose result happened to be a
// three-key map, so `logosctl call` exited 0. It now exits 4. That is exactly
// the kind of change unit tests cannot vouch for on their own — the unit suite
// (tests/test_call_envelope.cpp, DispatchRejectionIsMethodFailed) hands
// callEnvelope a hand-written refusal object, which proves the decision but not
// that any real provider ever produces that shape. `echoInt` with a
// non-numeric argument does: the CLI's auto-typing sends the bare string
// "notanumber" and int64_t has no lenient decode.
TEST_F(ErrorPathTest, ProviderRefusalIsFoldedIntoTheErrorChannel) {
    std::string out;
    ASSERT_EQ(d.run("load-module test_basic_module", &out), 0) << out;

    // CONTROL FIRST, so a red assertion below cannot be blamed on the module or
    // the transport: the same method, a well-formed argument, succeeds.
    ASSERT_EQ(d.run("call test_basic_module echoInt 42", &out), 0) << out;
    EXPECT_NE(out.find("42"), std::string::npos) << out;

    // The refusal. Exit 4 (METHOD_FAILED), not 0 — this is the flip.
    EXPECT_EQ(d.run("call test_basic_module echoInt notanumber", &out,
                    kNegativeBudgetSecs), 4)
        << "a provider refusal must be reported as a failed call, not as a "
           "successful one returning a three-key map.\n" << out;

    const nlohmann::json env = lastJsonObject(out);
    EXPECT_EQ(env.value("status", std::string{}), "error") << out;
    EXPECT_EQ(env.value("code", std::string{}), "METHOD_FAILED") << out;

    // The provider's own code survives the fold, which is what distinguishes a
    // refusal from a transport failure for a JSON consumer. It must NOT have
    // been flattened into the generic "call_failed".
    const nlohmann::json diag = env.value("error", nlohmann::json());
    ASSERT_TRUE(diag.is_object()) << out;
    EXPECT_EQ(diag.value("code", std::string{}), "dispatch_failed") << out;
    EXPECT_FALSE(diag.value("message", std::string{}).empty()) << out;

    // And the refusal was argument-scoped: the daemon and the module are still
    // live afterwards. Before the fold this call was reported as a SUCCESS, so
    // nothing about the surrounding state was ever in question — now that it is
    // an error path, it is worth pinning that it is not a wedging one.
    ASSERT_EQ(d.run("call test_basic_module echoInt 7", &out), 0) << out;
    EXPECT_NE(out.find("7"), std::string::npos) << out;
}

// Crash-isolation: modules run in a separate logos_host subprocess
// (logos_core_start spawns it in remote mode). A faulty module that
// SIGSEGVs must take down only that host process — the logosctl
// daemon itself must keep answering clients. Uses test_basic_module's
// crashOnDemand() (a null-pointer deref). Fresh-daemon-per-test
// because killing the host pollutes shared state for everything else.
//
// "Daemon survived" alone is too weak — a missing/renamed method or
// an error-returning stub also exits non-zero. Belt + braces:
//   (1) precondition: module-info lists crashOnDemand → we're really
//       calling the method we think we are;
//   (2) positive crash evidence: after the call, the daemon observes
//       the host die and flips the module out of "loaded" state
//       (module_manager.cpp's onTerminated → registry.markUnloaded).
//       A method that merely returned an error would leave it loaded.
TEST_F(ErrorPathTest, CrashedModuleDoesNotKillDaemon) {
    std::string out;

    // Module loads and is callable — baseline that the daemon + host
    // are healthy before we intentionally crash one of them.
    ASSERT_EQ(d.run("load-module test_basic_module", &out), 0)
        << "test_basic_module must load before crash test.\n" << out
        << "\n--- daemon log ---\n" << slurp(d.daemonLog);
    ASSERT_EQ(d.run("call test_basic_module returnTrue", &out), 0)
        << "module must be callable pre-crash.\n" << out;
    EXPECT_NE(out.find("true"), std::string::npos) << out;

    // Precondition (1): the method we're about to call really exists
    // on the loaded module — otherwise the "non-zero exit" assertion
    // below would pass for the wrong reason (method-not-found, not
    // host crash). Pulls the methods list from module-info --json.
    ASSERT_EQ(d.run("module-info test_basic_module", &out), 0)
        << "module-info should succeed for a loaded module.\n" << out;
    nlohmann::json pre = lastJsonObject(out);
    ASSERT_EQ(pre.value("status", std::string{}), "loaded")
        << "module should be loaded before the crash.\n" << out;
    nlohmann::json methods = pre.value("methods", nlohmann::json::array());
    bool hasCrash = false;
    for (const auto& v : methods) {
        if (v.value("name", std::string{}) == "crashOnDemand") {
            hasCrash = true;
            break;
        }
    }
    ASSERT_TRUE(hasCrash)
        << "test_basic_module must expose crashOnDemand — otherwise "
           "this test would pass for the wrong reason (method-not-found).\n"
        << out;

    // Crash the host. The RPC will not return cleanly: either the
    // peer dies mid-call (RPC_FAILED, non-zero exit) or the SDK
    // burns its full timeout. `timeout` keeps us bounded in either
    // case — we only assert "must not succeed", not a specific code.
    EXPECT_NE(d.run("call test_basic_module crashOnDemand",
                    &out, kNegativeBudgetSecs), 0)
        << "crashOnDemand must not return success.\n" << out;

    // Positive crash evidence (2): the daemon's SIGCHLD handler runs
    // asynchronously, so poll for up to ~5s waiting to observe the
    // module flip out of "loaded" (markUnloaded). If crashOnDemand
    // had merely returned an error envelope without dying, the host
    // would still be alive and module-info would keep reporting
    // status=="loaded" — failing this assertion.
    std::string lastStatus = "<none>";
    bool unloaded = false;
    for (int i = 0; i < 50; ++i) {
        if (d.run("module-info test_basic_module", &out, /*timeoutSecs=*/5) == 0) {
            lastStatus = lastJsonObject(out).value("status", std::string{});
            if (lastStatus != "loaded") { unloaded = true; break; }
        }
        std::this_thread::sleep_for(std::chrono::milliseconds(100));
    }
    EXPECT_TRUE(unloaded)
        << "daemon never observed the host crash — module still reports "
        << "status='" << lastStatus << "' (expected anything but 'loaded'). "
        << "Either crashOnDemand didn't actually crash, or the daemon's "
        << "subprocess supervisor stopped detecting host exits.\n"
        << "--- daemon log ---\n" << slurp(d.daemonLog);

    // Original isolation assertion: a quick `status` round-trip proves
    // the daemon is still serving clients after the host subprocess
    // died. If the daemon went down with the module, `status` would
    // either fail to connect or `timeout` would fire.
    ASSERT_EQ(d.run("status", &out, /*timeoutSecs=*/10), 0)
        << "daemon must survive a module crash.\n" << out
        << "\n--- daemon log ---\n" << slurp(d.daemonLog);

    // `list-modules` exercises a different code path than `status`
    // (catalog scan vs. liveness check) — both must keep working.
    ASSERT_EQ(d.run("list-modules", &out, /*timeoutSecs=*/10), 0)
        << "list-modules must still work after a module crash.\n" << out;
    EXPECT_NE(out.find("test_basic"), std::string::npos)
        << "module must remain discoverable after its host crashed.\n" << out;
}

// Auth-token regression: the client must present a token core_service
// accepts on every RPC.
//
// The daemon issues one `auto` bearer token at boot and registers its raw
// value in its TokenManager (under "cli_client"). core_service validates an
// incoming token *by value* (ModuleProxy::isAuthorized scans every stored
// token), so the client only authenticates if it actually *transmits* that
// token. But the SDK picks which token to send by the TARGET name —
// getToken(objectName) with objectName == "core_service" — so the client
// must have the bearer token filed under the "core_service" key
// (RpcClient::connect, src/client/client.cpp). With that registration
// missing, getToken("core_service") misses, the SDK falls into the
// capability_module requestModule fallback (which can't mint a token for
// the in-process core_service), an unrecognized token reaches the daemon,
// and EVERY business RPC is rejected — list-modules, load-module, call,
// status, stop all fail. (Pre-enforcement SDKs ignored the token, hiding
// this; once ModuleProxy started enforcing, the gap became fatal.)
//
// This test pins that path: a load + a real method call must succeed, AND
// the daemon log must carry no "rejecting unauthorized" line — so a
// regression that breaks the client's token registration fails here loudly,
// not as some unrelated RPC error.
TEST_F(ErrorPathTest, ClientAuthenticatesToCoreService) {
    std::string out;

    // list-modules is the cheapest authenticated core_service RPC (no
    // module load involved). If the client isn't presenting a token
    // core_service accepts, this already fails.
    ASSERT_EQ(d.run("list-modules", &out), 0)
        << "list-modules (an authenticated core_service RPC) must succeed — "
           "the client must present a token core_service accepts.\n" << out
        << "\n--- daemon log ---\n" << slurp(d.daemonLog);

    // A real business dispatch end-to-end: load the module, then call a
    // method on it. Both legs are authenticated core_service RPCs; the
    // second also drives core_service -> module. A broken client token
    // registration makes load-module fail outright.
    ASSERT_EQ(d.run("load-module test_basic_module", &out), 0)
        << "load-module must succeed for an authenticated client "
           "(LOGOS_HOST_PATH wired?).\n" << out
        << "\n--- daemon log ---\n" << slurp(d.daemonLog);

    ASSERT_EQ(d.run("call test_basic_module returnTrue", &out), 0)
        << "an authenticated call must round-trip and succeed.\n" << out
        << "\n--- daemon log ---\n" << slurp(d.daemonLog);
    EXPECT_NE(out.find("true"), std::string::npos) << out;

    // Root-cause pin: prove the calls above weren't authorized by some
    // unrelated accident. core_service logs exactly this string when it
    // rejects an unrecognized token (ModuleProxy::callRemoteMethod). Its
    // presence means the client sent a token core_service didn't accept —
    // i.e. the very regression this test guards against.
    const std::string log = slurp(d.daemonLog);
    EXPECT_EQ(log.find("rejecting unauthorized"), std::string::npos)
        << "core_service rejected a client token as unauthorized — the "
           "client is not presenting a token it accepts (check the "
           "core_service token registration in RpcClient::connect).\n"
           "--- daemon log ---\n" << log;
}

// ═══════════════════════════════════════════════════════════════════════════
// Full API + concurrency — ONE shared daemon, module loaded once
// ═══════════════════════════════════════════════════════════════════════════

class LoadedModuleTest : public ::testing::Test {
protected:
    static LogosctlDaemon* s_d;
    static bool s_skip;
    static std::string s_skipWhy;

    static void SetUpTestSuite() {
        s_d = new LogosctlDaemon();
        if (!s_d->envReady(s_skipWhy)) { s_skip = true; return; }
        s_d->start("loaded_suite");
        ASSERT_TRUE(s_d->waitReady())
            << "daemon did not become reachable.\n--- daemon log ---\n"
            << slurp(s_d->daemonLog);
        // Load once for the whole suite. If it fails (e.g. the daemon's
        // modules dir is missing capability_module so the request hangs
        // on capability negotiation), skip the API/concurrency tests
        // with the daemon log attached rather than letting every test
        // burn the ~20s RPC timeout into a hard failure.
        std::string out;
        if (s_d->run("load-module test_basic_module", &out, 30) != 0) {
            s_skip = true;
            s_skipWhy = "test_basic_module failed to load — skipping API/"
                        "concurrency suite.\n" + out +
                        "\n--- daemon log ---\n" + slurp(s_d->daemonLog);
        }
    }

    static void TearDownTestSuite() {
        // shutdown() is a no-op when the daemon was never started
        // (env missing) — pid<=0 and base empty — so it's always safe.
        if (s_d) { s_d->shutdown(); delete s_d; s_d = nullptr; }
    }

    void SetUp() override {
        if (s_skip) GTEST_SKIP() << s_skipWhy;
    }

    // `call test_basic_module <method> [args]` → `result` of the success
    // envelope {"status":"ok","module":...,"result":<v>}.
    nlohmann::json call(const std::string& method, const std::string& args = "") {
        std::string out;
        const std::string cmd =
            "call test_basic_module " + method + (args.empty() ? "" : " " + args);
        EXPECT_EQ(s_d->run(cmd, &out), 0) << cmd << "\n" << out;
        nlohmann::json env = lastJsonObject(out);
        EXPECT_EQ(env.value("status", std::string{}), "ok")
            << cmd << "\n" << out;
        return env.value("result", nlohmann::json{});
    }
};

LogosctlDaemon* LoadedModuleTest::s_d = nullptr;
bool LoadedModuleTest::s_skip = false;
std::string LoadedModuleTest::s_skipWhy;

// ── void / bool / int (void surfaces as `true` — call_executor.cpp) ──────────

TEST_F(LoadedModuleTest, VoidAndBoolReturns) {
    EXPECT_TRUE(call("doNothing").get<bool>());
    EXPECT_TRUE(call("doNothingWithArgs", "hello 7").get<bool>());
    EXPECT_TRUE(call("returnTrue").get<bool>());
    EXPECT_FALSE(call("returnFalse").get<bool>());
    EXPECT_TRUE(call("isPositive", "5").get<bool>());
    EXPECT_FALSE(call("isPositive", "-3").get<bool>());
    EXPECT_FALSE(call("isPositive", "0").get<bool>());
}

TEST_F(LoadedModuleTest, IntReturns) {
    EXPECT_EQ(call("returnInt").get<int>(), 42);
    EXPECT_EQ(call("addInts", "2 3").get<int>(), 5);
    EXPECT_EQ(call("stringLength", "abcdef").get<int>(), 6);
    EXPECT_EQ(call("echoInt", "123").get<int>(), 123);
    EXPECT_EQ(call("byteArraySize", "abcde").get<int>(), 5);
}

TEST_F(LoadedModuleTest, StringReturns) {
    EXPECT_EQ(call("returnString").get<std::string>(), "test_basic_module");
    EXPECT_EQ(call("echo", "roundtrip").get<std::string>(), "roundtrip");
    EXPECT_EQ(call("concat", "foo bar").get<std::string>(), "foobar");
    EXPECT_EQ(call("urlToString", "https://example.com/p").get<std::string>(),
              "https://example.com/p");
}

TEST_F(LoadedModuleTest, LogosResultShapes) {
    nlohmann::json ok = call("successResult");
    EXPECT_TRUE(ok["success"].get<bool>());
    EXPECT_EQ(ok["value"].get<std::string>(), "operation succeeded");
    EXPECT_TRUE(ok["error"].is_null());

    nlohmann::json err = call("errorResult");
    EXPECT_FALSE(err["success"].get<bool>());
    EXPECT_TRUE(err["value"].is_null());
    EXPECT_EQ(err["error"].get<std::string>(), "deliberate error for testing");

    nlohmann::json m = call("resultWithMap")["value"];
    EXPECT_EQ(m["name"].get<std::string>(), "test");
    EXPECT_EQ(m["count"].get<int>(), 42);
    EXPECT_TRUE(m["active"].get<bool>());

    nlohmann::json lst = call("resultWithList")["value"];
    ASSERT_EQ(lst.size(), 2u);
    EXPECT_EQ(lst[0]["label"].get<std::string>(), "first");
    EXPECT_EQ(lst[1]["id"].get<int>(), 2);

    nlohmann::json vOk = call("validateInput", "hello");
    EXPECT_TRUE(vOk["success"].get<bool>());
    EXPECT_EQ(vOk["value"]["length"].get<int>(), 5);

    nlohmann::json vErr = call("validateInput", "''");
    EXPECT_FALSE(vErr["success"].get<bool>());
    EXPECT_EQ(vErr["error"].get<std::string>(), "input cannot be empty");
}

TEST_F(LoadedModuleTest, VariantAndCollectionReturns) {
    EXPECT_EQ(call("returnVariantInt").get<int>(), 99);
    EXPECT_EQ(call("returnVariantString").get<std::string>(), "variant_string");

    nlohmann::json vm = call("returnVariantMap");
    EXPECT_EQ(vm["key"].get<std::string>(), "value");
    EXPECT_EQ(vm["number"].get<int>(), 7);

    nlohmann::json vl = call("returnVariantList");
    ASSERT_EQ(vl.size(), 3u);
    EXPECT_EQ(vl[0].get<std::string>(), "alpha");
    EXPECT_EQ(vl[2].get<std::string>(), "gamma");

    nlohmann::json ja = call("returnJsonArray");
    ASSERT_EQ(ja.size(), 3u);
    EXPECT_EQ(ja[0].get<int>(), 1);
    EXPECT_EQ(ja[2].get<int>(), 3);

    nlohmann::json mk = call("makeJsonArray", "x y");
    ASSERT_EQ(mk.size(), 2u);
    EXPECT_EQ(mk[1].get<std::string>(), "y");

    nlohmann::json sl = call("returnStringList");
    ASSERT_EQ(sl.size(), 3u);
    EXPECT_EQ(sl[1].get<std::string>(), "two");

    nlohmann::json sp = call("splitString", "a,b,c");
    ASSERT_EQ(sp.size(), 3u);
    EXPECT_EQ(sp[0].get<std::string>(), "a");
    EXPECT_EQ(sp[2].get<std::string>(), "c");
}

TEST_F(LoadedModuleTest, ArgCountFanOut) {
    EXPECT_EQ(call("noArgs").get<std::string>(), "noArgs()");
    EXPECT_EQ(call("oneArg", "x").get<std::string>(), "oneArg(x)");
    EXPECT_EQ(call("twoArgs", "x 7").get<std::string>(), "twoArgs(x, 7)");
    EXPECT_EQ(call("threeArgs", "x 7 true").get<std::string>(),
              "threeArgs(x, 7, true)");
    EXPECT_EQ(call("fourArgs", "x 7 false y").get<std::string>(),
              "fourArgs(x, 7, false, y)");
    EXPECT_EQ(call("fiveArgs", "x 7 true y 9").get<std::string>(),
              "fiveArgs(x, 7, true, y, 9)");
    EXPECT_TRUE(call("echoBool", "true").get<bool>());
    EXPECT_FALSE(call("echoBool", "false").get<bool>());
}

TEST_F(LoadedModuleTest, AsyncEchoWithDelay) {
    auto start = std::chrono::steady_clock::now();
    EXPECT_EQ(call("echoWithDelay", "pong 200").get<std::string>(), "pong");
    auto ms = std::chrono::duration_cast<std::chrono::milliseconds>(
        std::chrono::steady_clock::now() - start).count();
    EXPECT_GE(ms, 200) << "echoWithDelay returned too fast (" << ms << "ms)";
}

// ── Events: subscribe via `watch`, fire via a method call ────────────────────

// Re-emit the event on a cadence while polling the watch log instead of
// sleeping a fixed time and emitting once: emitting is idempotent, so
// this races neither the watcher's subscription nor a slow CI worker —
// whenever the subscription becomes active, a subsequent emit lands.
// The ProcGuard reaps the watcher even if a fatal assertion fires.

TEST_F(LoadedModuleTest, EmitTestEventRoundTrip) {
    const fs::path log = s_d->base / "watch_single.log";
    pid_t w = s_d->spawnBg({"watch", "test_basic_module", "--event", "testEvent"}, log);
    ASSERT_GT(w, 0);
    ProcGuard guard{s_d, w};

    // Give the watcher time to connect and register its subscription
    std::this_thread::sleep_for(std::chrono::milliseconds(500));

    bool got = false;
    for (int i = 0; i < 300 && !got; ++i) {  // up to ~30s
        std::string out;
        s_d->run("call test_basic_module emitTestEvent payload123", &out);
        if (slurp(log).find("payload123") != std::string::npos) { got = true; break; }
        std::this_thread::sleep_for(std::chrono::milliseconds(100));
    }
    EXPECT_TRUE(got) << "testEvent payload not observed.\n--- watch log ---\n"
                     << slurp(log);
}

TEST_F(LoadedModuleTest, EmitMultiArgEvent) {
    const fs::path log = s_d->base / "watch_multi.log";
    pid_t w = s_d->spawnBg({"watch", "test_basic_module", "--event", "multiArgEvent"}, log);
    ASSERT_GT(w, 0);
    ProcGuard guard{s_d, w};

    // Give the watcher time to connect and register its subscription
    std::this_thread::sleep_for(std::chrono::milliseconds(500));

    bool got = false;
    for (int i = 0; i < 300 && !got; ++i) {  // up to ~30s
        std::string out;
        s_d->run("call test_basic_module emitMultiArgEvent label 42", &out);
        const std::string l = slurp(log);
        if (l.find("label") != std::string::npos && l.find("42") != std::string::npos) {
            got = true; break;
        }
        std::this_thread::sleep_for(std::chrono::milliseconds(100));
    }
    EXPECT_TRUE(got) << "multiArgEvent not observed.\n--- watch log ---\n" << slurp(log);
}

// ── Concurrency: many independent clients hitting one daemon at once ─────────
// Each thread is its own `logosctl call` process. Worker threads do NO
// gtest assertions (not thread-safe) — they record (ok, detail) into
// private slots; the main thread asserts after join.

TEST_F(LoadedModuleTest, ConcurrentEchoFromManyClients) {
    constexpr int N = 12;
    std::vector<std::thread> ts;
    std::vector<int> ok(N, 0);
    std::vector<std::string> detail(N);

    for (int i = 0; i < N; ++i) {
        ts.emplace_back([&, i] {
            const std::string tok = "tok" + std::to_string(i);
            std::string out;
            int rc = s_d->run("call test_basic_module echo " + tok, &out);
            std::string got;
            try {
                got = lastJsonObject(out)["result"].get<std::string>();
            } catch (...) {}
            ok[i] = (rc == 0 && got == tok) ? 1 : 0;
            if (!ok[i]) detail[i] = "rc=" + std::to_string(rc) +
                                    " got='" + got + "' want='" + tok + "'\n" + out;
        });
    }
    for (auto& t : ts) t.join();

    for (int i = 0; i < N; ++i)
        EXPECT_EQ(ok[i], 1) << "client " << i << ": " << detail[i];
}

TEST_F(LoadedModuleTest, ConcurrentMixedMethodsFromManyClients) {
    constexpr int N = 16;
    std::vector<std::thread> ts;
    std::vector<int> ok(N, 0);
    std::vector<std::string> detail(N);

    for (int i = 0; i < N; ++i) {
        ts.emplace_back([&, i] {
            std::string out;
            int rc = -1;
            bool good = false;
            try {
                switch (i % 4) {
                case 0: {  // addInts(i, i) == 2*i
                    rc = s_d->run("call test_basic_module addInts " +
                                  std::to_string(i) + " " + std::to_string(i), &out);
                    good = lastJsonObject(out)["result"].get<int>() == 2 * i;
                    break;
                }
                case 1: {  // echoInt(i) == i
                    rc = s_d->run("call test_basic_module echoInt " + std::to_string(i), &out);
                    good = lastJsonObject(out)["result"].get<int>() == i;
                    break;
                }
                case 2: {  // returnString() == "test_basic_module"
                    rc = s_d->run("call test_basic_module returnString", &out);
                    good = lastJsonObject(out)["result"].get<std::string>() == "test_basic_module";
                    break;
                }
                default: {  // stringLength("xxxx..i..") == i
                    rc = s_d->run("call test_basic_module stringLength " +
                                  std::string(static_cast<size_t>(i), 'x'), &out);
                    good = lastJsonObject(out)["result"].get<int>() == i;
                    break;
                }
                }
            } catch (...) {}
            ok[i] = (rc == 0 && good) ? 1 : 0;
            if (!ok[i]) detail[i] = "case=" + std::to_string(i % 4) +
                                    " rc=" + std::to_string(rc) + "\n" + out;
        });
    }
    for (auto& t : ts) t.join();

    for (int i = 0; i < N; ++i)
        EXPECT_EQ(ok[i], 1) << "client " << i << ": " << detail[i];
}

// ═══════════════════════════════════════════════════════════════════════════
// Socket lifecycle — the node must not leave unix-socket files behind
//
// The reported symptom was dozens of stale /tmp/logos_* files: the module
// host died instantly on SIGTERM, so QCoreApplication::exec() never returned
// and QLocalServer's destructor — the only thing that unlinks the socket —
// never ran. Every clean shutdown leaked one file per module.
//
// Two halves, because they fail independently:
//   * a graceful stop unlinks everything it bound (the shutdown handler);
//   * whatever a *hard* kill leaves behind is reaped at the next boot (the
//     reaper), which is the only path available for SIGKILL / crashes.
//
// Both run in a private $TMPDIR so the assertions describe this node's
// sockets and not a developer box's accumulated leftovers.
// ═══════════════════════════════════════════════════════════════════════════

class SocketLifecycleTest : public ::testing::Test {
protected:
    LogosctlDaemon d;

    void SetUp() override {
        std::string why;
        if (!d.envReady(why)) GTEST_SKIP() << why;
        d.socketDir = shortSocketDir(
            ::testing::UnitTest::GetInstance()->current_test_info()->name());
        if (d.socketDir.empty())
            GTEST_SKIP() << "no temp directory short enough for AF_UNIX sun_path";
        std::error_code ec;
        fs::remove_all(d.socketDir, ec);
        fs::create_directories(d.socketDir, ec);
        if (ec) GTEST_SKIP() << "cannot create " << d.socketDir << ": " << ec.message();
    }

    void TearDown() override {
        d.shutdown();
        std::error_code ec;
        fs::remove_all(d.socketDir, ec);
    }
};

TEST_F(SocketLifecycleTest, NoSocketsSurviveGracefulStop)
{
    d.start("sockets_stop");
    ASSERT_TRUE(d.waitReady()) << slurp(d.daemonLog);

    // Load a module so the tally covers a logos_host child socket too — that
    // subprocess is a separate binary with its own shutdown path, and it is
    // where the bulk of the reported leak came from.
    std::string out;
    ASSERT_EQ(d.run("load-module test_basic_module", &out), 0) << out;

    const auto live = socketNames(d.socketDir);
    // core_service + capability_module + test_basic_module.
    ASSERT_GE(live.size(), 2u)
        << "expected the running node to have bound sockets in " << d.socketDir
        << "; found " << live.size() << ". Without this the test would pass "
        << "vacuously.\n" << slurp(d.daemonLog);

    ASSERT_EQ(d.run("stop", &out), 0) << out;

    // The daemon acks `stop` before its children have finished unwinding, so
    // give the module hosts a bounded moment to run their destructors.
    std::vector<std::string> remaining;
    for (int i = 0; i < 100; ++i) {
        remaining = socketNames(d.socketDir);
        if (remaining.empty()) break;
        std::this_thread::sleep_for(std::chrono::milliseconds(100));
    }

    std::string leaked;
    for (const auto& n : remaining) leaked += "\n  " + n;
    EXPECT_TRUE(remaining.empty())
        << "sockets survived a graceful stop:" << leaked << "\n"
        << slurp(d.daemonLog);
}

TEST_F(SocketLifecycleTest, BootReapsStaleSocketsButSparesLiveOnesAndFiles)
{
    fs::create_directories(d.socketDir);

    // A *stale* socket: bound, then the listener closed. The path stays on
    // disk and connect() is refused — exactly what a SIGKILLed node leaves.
    const fs::path stale = d.socketDir / "logos_stale_aaaaaaaaaaaa";
    const int staleFd = bindListen(stale);
    ASSERT_GE(staleFd, 0) << "could not bind " << stale;
    ::close(staleFd);
    ASSERT_TRUE(fs::exists(stale));

    // A *live* socket owned by this test process, held open for the duration.
    // Reaping it would mean the reaper can kill a co-resident node's endpoints.
    const fs::path live = d.socketDir / "logos_live_bbbbbbbbbbbb";
    const int liveFd = bindListen(live);
    ASSERT_GE(liveFd, 0) << "could not bind " << live;

    // A regular file that merely shares the prefix. A glob-based cleanup would
    // delete it; the real one only ever unlinks S_ISSOCK inodes. (Not
    // hypothetical: a multi-hundred-MB logos_*.lgx sits in the temp dir on a
    // dev box.)
    const fs::path plain = d.socketDir / "logos_execution_zone-1.0.0.lgx";
    { std::ofstream f(plain); f << "not a socket"; }
    ASSERT_TRUE(fs::exists(plain));

    d.start("sockets_reap");
    const bool ready = d.waitReady();
    ::close(liveFd);
    ASSERT_TRUE(ready) << slurp(d.daemonLog);

    EXPECT_FALSE(fs::exists(stale))
        << "a stale socket survived the boot reaper: " << stale << "\n"
        << slurp(d.daemonLog);
    EXPECT_TRUE(fs::exists(live))
        << "the reaper unlinked a LIVE socket — a co-resident node would lose "
        << "its endpoint: " << live;
    ASSERT_TRUE(fs::exists(plain))
        << "the reaper deleted a regular file sharing the prefix: " << plain;
    EXPECT_EQ(slurp(plain), "not a socket") << "regular file was modified";
}

// ═══════════════════════════════════════════════════════════════════════════
// Deny-by-default inter-module access enforcement (`access_policy`)
// ═══════════════════════════════════════════════════════════════════════════
//
// The end-to-end proof, on a REAL daemon: same binaries, same modules, same
// call — the only variable between the fixtures below is whether the session's
// `access_policy` was set to the deny-by-default document. logosctl takes it
// from the daemon config rather than from a flag (`logoscore` spells the same
// document `--access-policy enforce`; see test_integration_logoscore.cpp).
//
// The probe is capability_module.requestModule(caller, target), which is the
// gate every inter-module call passes through: no token minted ⇒ the call can
// never proceed. Driving it directly (rather than through a module that calls
// out) keeps the assertion on the gate itself, with no module-side retry or
// timeout policy in the way.
//
// The (caller, target) pairs come from logos-test-modules' declared metadata:
//   test_ipc_new_api_module   declares  [test_basic_module, test_extlib_module]
//   test_basic_module declares  []            ← so basic -> extlib is UNdeclared
//
// Both directions matter, and the DECLARED one carries the weight: an
// implementation that refused everything would satisfy the "denied" half on
// its own.
namespace {

// requestModule is a two-arg call returning the minted token, or "" on refusal.
// Returns nullopt if the client call itself failed (a broken daemon, not a
// policy decision) so the tests can tell those apart.
std::optional<std::string> requestModuleToken(const LogosctlDaemon& d,
                                              const std::string& caller,
                                              const std::string& target,
                                              std::string* raw)
{
    std::string out;
    const std::string cmd =
        "call capability_module requestModule " + caller + " " + target;
    const int rc = d.run(cmd, &out, /*timeoutSecs=*/20);
    if (raw) *raw = out;
    if (rc != 0) return std::nullopt;
    nlohmann::json env = lastJsonObject(out);
    if (env.value("status", std::string{}) != "ok") return std::nullopt;
    const nlohmann::json result = env.value("result", nlohmann::json{});
    if (result.is_string()) return result.get<std::string>();
    if (result.is_null()) return std::string{};
    return std::nullopt;
}

// True when the daemon log carries an access-policy refusal naming BOTH
// modules. Matched structurally (a line that says it denied, mentioning caller
// and target) rather than by exact text: capability_module has more than one
// implementation in this tree and they quote the names differently ('x' vs
// "x"). What must not vary is that both names are on the line.
bool logDeniesPair(const std::string& log,
                   const std::string& caller,
                   const std::string& target)
{
    std::istringstream in(log);
    std::string line;
    while (std::getline(in, line)) {
        if (line.find("denies") == std::string::npos) continue;
        const auto c = line.find(caller);
        const auto t = line.find(target);
        // Ordered caller-then-target: "denies A -> B" and "denies B -> A" are
        // different claims, and only the first is the one under test.
        if (c != std::string::npos && t != std::string::npos && c < t) return true;
    }
    return false;
}

// The bare deny-by-default document — the same text `logoscore
// --access-policy enforce` expands to (src/daemon/access_policy_arg.h). `mode`
// is the runtime's only switch; with no explicit `restrictions` the runtime
// derives them from the declared dependency graph.
constexpr const char* kEnforceDoc =
    R"({"version":1,"mode":"enforce","restrictions":{}})";

// Bring up a daemon with the three modules loaded. `policyDoc` empty ⇒ no
// access_policy in the session config at all (today's default).
class AccessPolicyFixture : public ::testing::Test {
protected:
    LogosctlDaemon d;

    void bootWith(const std::string& policyDoc) {
        std::string why;
        if (!d.envReady(why)) GTEST_SKIP() << why;
        if (!policyDoc.empty()) {
            // A JSON document carried as a YAML string, exactly as
            // docs/logosctl.md tells operators to write it.
            d.extraConfig = std::string("access_policy: '") + policyDoc + "'\n";
        }
        d.start(::testing::UnitTest::GetInstance()->current_test_info()->name());
        ASSERT_TRUE(d.waitReady())
            << "daemon did not become reachable.\n--- daemon log ---\n"
            << slurp(d.daemonLog);

        // test_ipc_new_api_module declares both others, so one load pulls all three.
        std::string out;
        if (d.run("load-module test_ipc_new_api_module", &out, /*timeoutSecs=*/30) != 0)
            GTEST_SKIP() << "test_ipc_new_api_module not available in this modules dir:\n"
                         << out;
        ASSERT_EQ(d.run("list-modules --loaded", &out), 0) << out;
        for (const char* m : {"test_ipc_new_api_module", "test_basic_module", "test_extlib_module"})
            ASSERT_NE(out.find(m), std::string::npos)
                << m << " must be loaded before probing the gate.\n" << out
                << "\n--- daemon log ---\n" << slurp(d.daemonLog);
    }

    void TearDown() override { d.shutdown(); }
};

} // namespace

// ── Policy unset: unchanged behaviour ───────────────────────────────────────

TEST_F(AccessPolicyFixture, NoPolicy_UndeclaredPairStillMintsAToken) {
    bootWith("");
    if (::testing::Test::IsSkipped() || ::testing::Test::HasFatalFailure()) return;

    std::string raw;
    // test_basic_module never declared test_extlib_module. Without a policy
    // this is unrestricted, and it must STAY unrestricted — several modules in
    // this tree call targets they never declared.
    auto token = requestModuleToken(d, "test_basic_module", "test_extlib_module", &raw);
    ASSERT_TRUE(token.has_value()) << "requestModule call failed outright:\n" << raw;
    EXPECT_FALSE(token->empty())
        << "an undeclared pair must still be minted with no access policy — "
           "this is the pre-existing behaviour the default must preserve.\n"
        << raw << "\n--- daemon log ---\n" << slurp(d.daemonLog);

    // Nothing was denied, so nothing may be logged as denied either.
    EXPECT_FALSE(logDeniesPair(slurp(d.daemonLog), "test_basic_module", "test_extlib_module"))
        << "no policy is installed — nothing should be denied.\n"
        << slurp(d.daemonLog);
}

// ── Policy armed: deny-by-default, both directions ──────────────────────────

TEST_F(AccessPolicyFixture, EnforcePolicy_RefusesUndeclaredPairAndLogsBothNames) {
    bootWith(kEnforceDoc);
    if (::testing::Test::IsSkipped() || ::testing::Test::HasFatalFailure()) return;

    std::string raw;
    auto token = requestModuleToken(d, "test_basic_module", "test_extlib_module", &raw);
    ASSERT_TRUE(token.has_value()) << "requestModule call failed outright:\n" << raw;
    EXPECT_TRUE(token->empty())
        << "an undeclared pair must be REFUSED under an enforce policy.\n"
        << raw << "\n--- daemon log ---\n" << slurp(d.daemonLog);

    // A silent denial is the failure mode this codebase has been debugged for
    // twice: it presents as a call returning empty. The refusal must name BOTH
    // modules in the log.
    const std::string log = slurp(d.daemonLog);
    EXPECT_TRUE(logDeniesPair(log, "test_basic_module", "test_extlib_module"))
        << "the refusal must be logged with both module names.\n" << log;
}

TEST_F(AccessPolicyFixture, EnforcePolicy_StillAllowsADeclaredPair) {
    bootWith(kEnforceDoc);
    if (::testing::Test::IsSkipped() || ::testing::Test::HasFatalFailure()) return;

    // The half that matters: enforcement that refused everything would pass
    // the test above and break every real deployment. test_ipc_new_api_module DECLARED
    // test_basic_module, so it must still be minted a token.
    std::string raw;
    auto token = requestModuleToken(d, "test_ipc_new_api_module", "test_basic_module", &raw);
    ASSERT_TRUE(token.has_value()) << "requestModule call failed outright:\n" << raw;
    EXPECT_FALSE(token->empty())
        << "a DECLARED caller must still be allowed under enforce — otherwise "
           "the policy just breaks everything.\n"
        << raw << "\n--- daemon log ---\n" << slurp(d.daemonLog);

    // …and the same daemon still refuses the undeclared pair, so the allow
    // above is not "enforcement quietly failed to arm".
    auto denied = requestModuleToken(d, "test_basic_module", "test_extlib_module", &raw);
    ASSERT_TRUE(denied.has_value()) << raw;
    EXPECT_TRUE(denied->empty())
        << "control: the undeclared pair must be refused on this same daemon.\n"
        << raw << "\n--- daemon log ---\n" << slurp(d.daemonLog);
}

// ═══════════════════════════════════════════════════════════════════════════
// Shutdown reply — the answer has to outlive the daemon that sent it
//
// `daemon stop` is the one call whose reply races its own delivery. The
// daemon answers, then leaves its event loop; the answer only reaches the
// wire when the loop next services that socket's write notifier. Lose that
// order and the client sits out its full RPC deadline, sees nothing, and
// reports RPC_FAILED — exit 3 — for a shutdown that worked perfectly.
//
// That is what took down the "Stop the daemon" step of
// doctests/logosctl-daemon.test.yaml on a loaded macOS runner: one failure in
// nine otherwise identical shutdowns in the same job.
//
// The race is invisible at the shipped grace period — 265 consecutive stops
// on the released binary never lost a reply, on either side of the PR it was
// first blamed on, which is why this reached CI in the first place.
// $LOGOSCTL_SHUTDOWN_GRACE_MS collapses that margin to nothing, which is the
// same window a stalled main thread opens up, and makes the bug reproducible
// on demand. Measured through this fixture on an idle macOS box: the pre-fix
// daemon lost 6 replies in 100 stops, the fixed one none in 120.
//
// If the daemon half ever regresses, expect this to fail as `daemon stop`
// exiting 3 with "the daemon (pid N) is still running 15s later" rather than
// as a lostReplies count. The daemon here is this process's own child, so it
// lingers as a zombie until reaped and the client's kill(pid, 0) confirmation
// sees it as alive — an artifact of the harness, not of the product, where no
// client is ever the daemon's parent.
//
// Not mirrored into test_integration_logoscore.cpp: both front-ends drive the
// same CoreServiceImpl::shutdown and the same RpcClient::shutdown, so a second
// copy would retest the same two functions through a tool that is on its way
// out.
// ═══════════════════════════════════════════════════════════════════════════

namespace {

// How many stop cycles to run. A race can only be guarded statistically, so
// this number is an explicit purchase: at the 6%-per-cycle loss rate measured
// through this fixture, 60 cycles catches a regression 97.6% of the time and
// costs about 30 seconds. Raise it with $LOGOSCTL_STOP_CYCLES when chasing
// something rarer — 100 cycles buys 99.8% for another 20 seconds.
int stopCycles()
{
    if (const char* v = std::getenv("LOGOSCTL_STOP_CYCLES")) {
        const int n = std::atoi(v);
        if (n > 0) return n;
    }
    return 60;
}

// The daemon here is this process's own child, so kill(pid, 0) — what
// logosctl::processAlive asks, and the right question for a client that is
// unrelated to the daemon — reports a zombie as alive. Reap it instead.
bool waitForChildExit(pid_t p, int timeoutMs)
{
    if (p <= 0) return true;
    const auto deadline = std::chrono::steady_clock::now()
                        + std::chrono::milliseconds(timeoutMs);
    for (;;) {
        int st = 0;
        const pid_t r = ::waitpid(p, &st, WNOHANG);
        if (r == p) return true;
        if (r < 0 && errno == ECHILD) return true;
        if (std::chrono::steady_clock::now() >= deadline) return false;
        std::this_thread::sleep_for(std::chrono::milliseconds(50));
    }
}

} // namespace

TEST(ShutdownReplyTest, StopSucceedsWithNoGracePeriod)
{
    {
        LogosctlDaemon probe;
        std::string why;
        if (!probe.envReady(why)) GTEST_SKIP() << why;
    }

    const int cycles = stopCycles();
    int reportedFailure = 0;
    int lostReplies     = 0;
    int survived        = 0;

    for (int i = 0; i < cycles; ++i) {
        LogosctlDaemon d;
        std::string why;
        ASSERT_TRUE(d.envReady(why)) << why;
        // Zero grace: quit the instant the answer has been handed over. The
        // daemon must still get it out.
        d.extraEnv["LOGOSCTL_SHUTDOWN_GRACE_MS"] = "0";
        d.start("stopreply_" + std::to_string(i));
        ASSERT_TRUE(d.waitReady())
            << "cycle " << i << ": daemon never became reachable\n"
            << slurp(d.daemonLog);

        const pid_t daemonPid = d.pid;

        std::string out;
        const int rc = d.run("daemon stop", &out, /*timeoutSecs=*/60);
        const nlohmann::json j = lastJsonObject(out);

        if (rc != 0) ++reportedFailure;
        EXPECT_EQ(rc, 0)
            << "cycle " << i << ": `daemon stop` exited " << rc << "\n" << out
            << "\n--- daemon log ---\n" << slurp(d.daemonLog);
        EXPECT_EQ(j.value("status", std::string{}), "ok")
            << "cycle " << i << ": " << out;

        // The other half of the contract, and the reason "treat silence as
        // success" is not on its own an acceptable fix: a stop that reports
        // ok must correspond to a daemon that is actually gone.
        const bool gone = waitForChildExit(daemonPid, 15000);
        if (!gone) ++survived;
        EXPECT_TRUE(gone)
            << "cycle " << i << ": daemon pid " << daemonPid
            << " still running after a successful-looking stop\n"
            << slurp(d.daemonLog);
        if (gone) d.pid = -1;   // reaped above; don't let killGroup wait again

        // `confirmed_by` is stamped only when the client had to fall back to
        // watching the daemon die because no reply ever arrived. At zero grace
        // that fallback is the safety net, not the mechanism.
        if (j.contains("confirmed_by")) ++lostReplies;

        d.shutdown();
    }

    EXPECT_EQ(reportedFailure, 0)
        << reportedFailure << "/" << cycles << " stops reported failure";
    EXPECT_EQ(survived, 0)
        << survived << "/" << cycles << " daemons outlived their own stop";
    EXPECT_EQ(lostReplies, 0)
        << lostReplies << "/" << cycles << " shutdown replies were lost and had to be "
           "confirmed by watching the process exit. The client covered for it and the "
           "command still succeeded, but the daemon is leaving its event loop before "
           "its answer is on the wire.";
}