Files
logos-cpp-sdk/cpp/logos_module_context.h
Dario LipicarandClaude Opus 5 667990f28c feat(sdk): aboutToUnload — a module's chance to finish before teardown (#143)
* feat(sdk): aboutToUnload — a module's chance to finish before teardown

A module could not flush state or close handles on the way out: the host
stopped it, its destructors ran, and anything mid-flight was gone. This gives
LogosModuleContext the Qt Creator contract for exactly that problem.

    enum class LogosShutdown { Synchronous, Asynchronous };

    virtual LogosShutdown aboutToUnload() { return LogosShutdown::Synchronous; }
    void unloadFinished() const;   // any thread

Default Synchronous, so no existing module changes behaviour. A module with work
to finish returns Asynchronous and calls unloadFinished() when done; the host
waits, but only for a bounded grace period.

unloadFinished() is a NO-OP outside a framework context, and after the deadline
has passed. That matters more than it reads: a module needs no special case for
being torn down under a deadline it already missed.

Two SFINAE pairs mirror the existing maybeSet* helpers. maybeAboutToUnload
reports Synchronous for an impl that never inherited LogosModuleContext, which
is exactly right -- it has no hook, so there is nothing to wait for.

Both names join the reserved set beside onContextReady: an impl overriding
aboutToUnload is talking to the framework, not publishing API, and leaking
either would generate a consumer wrapper for a lifecycle hook (LogosShutdown
has no LIDL type to return anyway).

The cdylib backend emits the two optional C ABI exports. The completion
callback is installed BEFORE the impl is asked to unload, and that ordering is
the correctness of the whole async path: an impl that finishes INLINE would
otherwise signal into a slot that is still empty, and the host would wait out
its entire grace period for a module already done. There is a test for it,
because nothing about reading the code makes that failure visible.

294/294, 4 new. Requires logos-protocol#62; flake.lock pins that branch.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* chore(deps): track logos-protocol master now that the teardown ABI has landed

logos-co/logos-protocol#62 merged as 9664ae2. The lock pointed at the PR branch
while it was open.

The narHash is unchanged across the move (sha256-JTREoJn2kjQmYyYHg2RQb4...), so
the merged tree is byte-identical to the branch this was built and tested
against.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(generator): guard the teardown emission on protocol 0.5

The emitted exports named logos_module_unload_done_cb unconditionally, so a
module built with this generator against an older logos-protocol failed to
compile on a typedef it never asked for:

    error: 'logos_module_unload_done_cb' was not declared in this scope

in generated code the author never wrote and cannot see. That is what this PR's
doc-tests hit -- new generator, older protocol pin.

logos-protocol#63 gives the surface a MINOR (0.5) so it is detectable, and both
the statics and the exports now sit behind

    #if defined(LOGOS_PROTOCOL_VERSION_MINOR) && LOGOS_PROTOCOL_VERSION_MINOR >= 5

the same way the 0.3 trust-root surface is guarded a few lines below. A module
built against 0.4 simply has no teardown entry point, which is the same state as
a module that never overrode the hook -- and the glue that would call it is
generated alongside, so nothing goes looking for the missing symbol.

Both halves need the guard, not just the exports: the typedef is what an older
header lacks, and it is the statics that name it. The test asserts both.

295/295. flake.lock tracks protocol master (0d2a3c0), where 0.5 landed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-08-20 20:54:49 -03:00

434 lines
20 KiB
C++

#ifndef LOGOS_MODULE_CONTEXT_H
#define LOGOS_MODULE_CONTEXT_H
#include <functional>
#include <string>
#include <type_traits>
#include <utility>
// ---------------------------------------------------------------------------
// `logos_events:` — Qt-`signals:`-style declaration of events the module
// can emit. The macro expands to `public:` so the compiler treats the
// declarations as ordinary public-method signatures (never called from
// outside the impl, but harmless to leave public — mirrors Qt's
// `#define signals public`). The cpp-generator's impl_header_parser
// recognises the raw `logos_events:` token before preprocessing and
// emits typed method bodies for each declaration in a sidecar
// `<name>_events_cdylib.cpp` that calls `emitEventImpl_()` underneath.
// (The file was `<name>_events.cpp` while the bodies marshalled into a
// QVariantList for a Qt provider object; the cdylib flavour marshals
// into nlohmann::json and is the only one emitted now.)
//
// class MyImpl : public LogosModuleContext {
// public:
// void doStuff() { userLoggedIn("alice", 12345); } // typed emit
// logos_events:
// void userLoggedIn(const std::string& userId, int64_t timestamp);
// };
// ---------------------------------------------------------------------------
#ifndef logos_events
#define logos_events public
#endif
// ---------------------------------------------------------------------------
// LogosModuleContext — opt-in mixin for codegen-generated modules
//
// The Logos runtime stamps three properties onto every module before the
// first method is dispatched (they are assembled into the module's
// ModuleDescriptor in `logos-liblogos/src/logos_core/module_manager.cpp`;
// the path this comment used to name,
// `src/runtimes/runtime_qt/host/module_initializer.cpp`, no longer exists):
//
// - modulePath — directory the module's plugin file lives in
// - instanceId — short ID the host assigns to this instance
// (the basename of the persistence directory)
// - instancePersistencePath — per-instance, host-owned data directory
// (e.g. `<basecamp>/module_data/<name>/<id>/`)
//
// Universal (codegen-generated) modules used to have no path to these
// values short of being handed the full LogosAPI — too much surface for
// what's almost always a one-line lookup. This mixin confines the
// exposure to the three getters below; the generated C-ABI export TU
// (`<name>_module_impl.cpp`) copies the values in via
// `_logosCoreSetContext_`, then fires `onContextReady()` so the impl can
// react in one well-defined place.
//
// Usage from a module impl:
//
// class MyModuleImpl : public LogosModuleContext {
// public:
// // ... your plain public methods; the generator derives the
// // module's contract from this header ...
// protected:
// void onContextReady() override {
// // instancePersistencePath() / instanceId() / modulePath()
// // are now populated; do one-time per-instance setup here.
// }
// };
//
// Impls that don't inherit from LogosModuleContext are unaffected — the
// codegen's `if constexpr (std::is_base_of_v<...>)` branch is compiled
// away, so there's no per-module cost to making the override always
// emitted.
// ---------------------------------------------------------------------------
// Per-module aggregate of dependency wrappers. Each module's codegen
// emits `struct LogosModules { ... };` at global scope in its own
// `generated_code/logos_sdk.h` (one accessor per `metadata.json#
// dependencies` entry — nothing else; apps that need to manage the
// core itself reach for liblogos' C API instead). Forward-declared
// here so the SDK header stays decoupled from per-module codegen —
// the impl's translation unit makes the type complete via its own
// `#include "logos_sdk.h"`, at which point the inline
// `LogosModuleContext::modules()` body below compiles.
struct LogosModules;
// How a module answers aboutToUnload().
//
// Synchronous — the module is already quiescent; the host may proceed to tear
// it down as soon as the call returns.
// Asynchronous — the module has work to finish first. The host waits, up to a
// bounded grace period, until the module calls unloadFinished().
//
// Modelled on Qt Creator's IPlugin::aboutToShutdown()/ShutdownFlag, which
// solves the same problem: a plugin that cannot finish synchronously needs a
// way to say so, and a way to say when it is done.
enum class LogosShutdown {
Synchronous,
Asynchronous,
};
class LogosModuleContext {
public:
virtual ~LogosModuleContext() = default;
// Directory the module's plugin file lives in. Useful for loading
// resources bundled next to the plugin (icons, qml/, schema files…).
const std::string& modulePath() const { return m_modulePath; }
// This module's own registry name — the name other modules address it by,
// and the `origin` it authenticates as. Needed by any BY-NAME call: the
// typed wrappers bake their origin in at codegen time, but a dynamic call
// has to state it, and a wrong origin authenticates as nobody and fails far
// from the call site. Empty outside a framework-provisioned context, like
// the getters below.
const std::string& moduleName() const { return m_moduleName; }
// Short ID the host assigns to this instance. Stable across restarts
// for the same on-disk persistence directory; multiple side-by-side
// instances of the same module get distinct IDs.
const std::string& instanceId() const { return m_instanceId; }
// Per-instance writable data directory the host owns the lifecycle
// of. Wiped when the module is uninstalled; survives upgrades. The
// canonical place for module-private state (config files, caches,
// small databases). Empty when the module is loaded outside a
// host that provisions persistence (e.g. unit tests using the
// impl directly), so always null-check before using.
const std::string& instancePersistencePath() const { return m_instancePersistencePath; }
// True once the framework has populated the three getters above.
// Flipped inside `_logosCoreSetContext_` *before* the
// `onContextReady()` hook fires, so derived impls can use this as
// a guard from helper methods that may run earlier in the impl's
// life (e.g. during construction in tests that bypass the
// framework). Stays false when the impl is constructed outside a
// framework-provisioned context, matching the empty-string
// fallback for the path getters.
bool isContextReady() const { return m_contextReady; }
// Typed access to this module's per-build `LogosModules` aggregate,
// which the codegen emits in `generated_code/logos_sdk.h`. It owns
// one strongly-typed client wrapper per entry in `metadata.json`'s
// `dependencies` list — nothing else. An impl can call those
// declared deps' methods without ever touching the raw `LogosAPI`:
//
// #include "logos_sdk.h" // generated at build time
//
// void MyModuleImpl::doWork() {
// modules().some_dep.someMethod(arg);
// }
//
// The pointer is set by the generated C-ABI export TU, which
// default-constructs the `LogosModules` on first use (each dep
// wrapper bakes in its target + this module's origin, so no
// `LogosAPI` is involved). The
// return type is forward-declared above so this header stays
// decoupled from per-module codegen; call sites need to have
// `logos_sdk.h` included (which defines `LogosModules` as a
// concrete `struct` in their translation unit) for the inline
// body below to compile. Calling before the framework has
// populated the pointer (e.g. from a unit test bypassing the
// provider) is undefined.
LogosModules& modules() const {
return *static_cast<LogosModules*>(m_logosModulesPtr);
}
// Framework-only entry point — invoked by the generated glue once the
// host has delivered the context (`logos_module_set_context`). The
// leading-underscore-trailing-underscore name signals "do not call
// from user code"; a friend declaration would be cleaner but would
// require the generator to spell out a specific provider class
// name per module, which we deliberately avoid coupling here.
void _logosCoreSetContext_(std::string modulePath,
std::string instanceId,
std::string instancePersistencePath) {
m_modulePath = std::move(modulePath);
m_instanceId = std::move(instanceId);
m_instancePersistencePath = std::move(instancePersistencePath);
// Flip BEFORE invoking the hook so derived impls' onContextReady
// overrides — and anything they call out to — see a "true"
// isContextReady() as expected.
m_contextReady = true;
onContextReady();
}
// Framework-only — sets moduleName(). Separate from
// `_logosCoreSetContext_` on purpose: that signature is called by every
// generated provider, so widening it would break each one until
// regenerated, for a value the generator knows statically anyway. Called
// BEFORE the context setter, so moduleName() is already populated when
// onContextReady() fires.
void _logosCoreSetModuleName_(std::string moduleName) {
m_moduleName = std::move(moduleName);
}
// Framework-only — sets the typed `LogosModules` pointer that
// `logos<T>()` dereferences. Untyped (void*) at this layer because
// the SDK header is shared by every module; the codegen-generated
// provider does the static_cast once it has the concrete type.
void _logosCoreSetLogosModulesPtr_(void* ptr) {
m_logosModulesPtr = ptr;
}
// Framework-only — installs the callback that the codegen-emitted
// bodies of `logos_events:` methods invoke. The `void*` carries an
// `nlohmann::json*` constructed inside the .cpp (it was a
// `QVariantList*` under the retired Qt provider glue); keeping the
// signature untyped here lets impl headers stay pure C++. The
// generated C-ABI export TU plugs in a lambda that casts the
// pointer back to nlohmann::json, dumps it, and forwards through the
// `logos_module_emit_cb` the host installed. (It used to cast to
// QVariantList and call `LogosProviderBase::emitEvent(QString,
// QVariantList)`, back when the impl was wrapped directly in a Qt
// provider object.)
void _logosCoreSetEmitEvent_(std::function<void(const std::string&, void*)> cb) {
m_emitEventCallback = std::move(cb);
}
// Framework-only — installs the callback `unloadFinished()` fires. Left
// empty outside a framework context, which is what makes unloadFinished()
// a no-op there rather than a crash.
void _logosCoreSetUnloadFinished_(std::function<void()> cb) {
m_unloadFinishedCallback = std::move(cb);
}
// Framework-only — drives the hook. Named apart from aboutToUnload() so
// the protected override stays the only thing an author sees, and so the
// host has an entry point without making the hook itself public.
LogosShutdown _logosCoreAboutToUnload_() { return aboutToUnload(); }
protected:
// Invoked from `<name>_events_cdylib.cpp` (codegen-emitted method
// bodies) to dispatch a typed event. `args` is the address of a
// stack-local `nlohmann::json` array constructed by the generated
// body; the callback the export TU installs casts it back and
// forwards. Kept `void*` so this header stays Qt- AND json-free.
// No-op when called outside a framework context (the callback
// stays default-constructed and empty) — same fallback shape as
// the property getters above.
void emitEventImpl_(const std::string& eventName, void* args) const {
if (m_emitEventCallback)
m_emitEventCallback(eventName, args);
}
protected:
// Hook for derived impls. Fires exactly once, after the three
// getters above become readable, before any method dispatch. The
// default is a no-op; override to wire one-time setup that depends
// on the persistence path. Do NOT do work in the constructor that
// needs these values — the constructor runs before the framework
// hands the context over.
virtual void onContextReady() {}
// Hook for derived impls, fired when the host is about to tear this module
// down — on an explicit unload and on application shutdown alike. Flush
// state, close handles, cancel timers here; the destructor still runs
// afterwards, but by then the framework context is gone.
//
// Return Synchronous (the default) when there is nothing to wait for. A
// module that needs to finish work returns Asynchronous and calls
// unloadFinished() when it is done — from any thread. The host waits, but
// only for a bounded grace period, after which it proceeds anyway: a hung
// module delays shutdown, it does not prevent it. Treat the deadline as
// real rather than as a courtesy.
//
// Returning Asynchronous and never calling unloadFinished() is a bug that
// costs every teardown of this module the full grace period. Returning
// Synchronous while work is still in flight is the other bug, and quieter.
//
// NOT part of the module's contract: this is framework plumbing, so the
// generator's reserved-name filter keeps it out of the derived .lidl and
// no consumer can call it.
virtual LogosShutdown aboutToUnload() { return LogosShutdown::Synchronous; }
// Signal that the Asynchronous teardown begun in aboutToUnload() has
// finished. Safe from any thread, and safe to call when the host is not
// listening (outside a framework context, or after the grace period
// elapsed) — a no-op then rather than an error, so a module needs no
// special case for being torn down under a deadline it missed.
//
// Calling it more than once is harmless; the host acts on the first.
void unloadFinished() const {
if (m_unloadFinishedCallback)
m_unloadFinishedCallback();
}
private:
std::string m_moduleName;
std::string m_modulePath;
std::string m_instanceId;
std::string m_instancePersistencePath;
// Tracks whether the framework has called `_logosCoreSetContext_`
// at least once. Read by `isContextReady()`.
bool m_contextReady = false;
// Type-erased so the SDK header doesn't need the per-module
// LogosModules definition. Reinterpreted via the typed `logos<T>()`
// accessor above. Stays null when the impl is constructed outside
// a framework-provisioned context (e.g. lgpd CLI / unit tests),
// matching the empty-string fallback for the other getters.
void* m_logosModulesPtr = nullptr;
// Set by the generated glue via the SFINAE'd
// _logos_codegen_::maybeSetEmitEvent helper below. Default-empty
// when the impl is constructed outside a framework-provisioned
// context, in which case `emitEventImpl_` becomes a no-op.
std::function<void(const std::string&, void*)> m_emitEventCallback;
// Installed by the host before it calls _logosCoreAboutToUnload_. Empty
// outside a framework context; see unloadFinished().
std::function<void()> m_unloadFinishedCallback;
};
// ---------------------------------------------------------------------------
// _logos_codegen_::maybeSetContext — codegen helper, do not call directly.
//
// The generated glue always wants to "set the
// context if the impl inherits from LogosModuleContext, otherwise do
// nothing." Doing this with `if constexpr` inside the override fails to
// compile for non-inheriting impls, because the discarded `static_cast`
// branch is still syntactically parsed and type-checked. Tag-dispatching
// through two function templates side-steps that — overload resolution
// instantiates exactly one of the two, and the unused overload is
// never analysed against the impl type. Backward compatible: existing
// universal modules that don't inherit pay zero runtime cost (the
// no-op overload inlines away) and zero compile cost beyond the
// template instantiation.
// ---------------------------------------------------------------------------
namespace _logos_codegen_ {
template<class T>
inline auto maybeSetModuleName(T& impl, std::string moduleName)
-> std::enable_if_t<std::is_base_of_v<LogosModuleContext, T>>
{
static_cast<LogosModuleContext&>(impl)._logosCoreSetModuleName_(std::move(moduleName));
}
template<class T>
inline auto maybeSetModuleName(T&, std::string)
-> std::enable_if_t<!std::is_base_of_v<LogosModuleContext, T>>
{
}
template<class T>
inline auto maybeSetContext(T& impl,
std::string modulePath,
std::string instanceId,
std::string instancePersistencePath)
-> std::enable_if_t<std::is_base_of_v<LogosModuleContext, T>>
{
static_cast<LogosModuleContext&>(impl)._logosCoreSetContext_(
std::move(modulePath),
std::move(instanceId),
std::move(instancePersistencePath));
}
template<class T>
inline auto maybeSetContext(T&,
std::string,
std::string,
std::string)
-> std::enable_if_t<!std::is_base_of_v<LogosModuleContext, T>>
{
// Module impl didn't opt into LogosModuleContext; nothing to do.
}
// Sets the (untyped) `LogosModules` pointer the generated glue
// constructs. Same tag-dispatch trick as maybeSetContext —
// the static_cast must be invisible to non-inheriting impls or their
// compile would break.
template<class T>
inline auto maybeSetLogosModules(T& impl, void* ptr)
-> std::enable_if_t<std::is_base_of_v<LogosModuleContext, T>>
{
static_cast<LogosModuleContext&>(impl)._logosCoreSetLogosModulesPtr_(ptr);
}
template<class T>
inline auto maybeSetLogosModules(T&, void*)
-> std::enable_if_t<!std::is_base_of_v<LogosModuleContext, T>>
{
// Module impl didn't opt into LogosModuleContext; nothing to do.
}
// Sets the typed-event callback that codegen-emitted
// `<name>_events_cdylib.cpp` bodies dispatch through. Same tag-dispatch
// trick as the two above — impls that don't inherit LogosModuleContext
// fall through to the no-op overload and compile unchanged.
template<class T>
inline auto maybeSetEmitEvent(T& impl, std::function<void(const std::string&, void*)> cb)
-> std::enable_if_t<std::is_base_of_v<LogosModuleContext, T>>
{
static_cast<LogosModuleContext&>(impl)._logosCoreSetEmitEvent_(std::move(cb));
}
template<class T>
inline auto maybeSetEmitEvent(T&, std::function<void(const std::string&, void*)>)
-> std::enable_if_t<!std::is_base_of_v<LogosModuleContext, T>>
{
// Module impl didn't opt into LogosModuleContext; nothing to do.
}
// Teardown, for an impl that opted into LogosModuleContext. Same tag-dispatch
// as the setters above: an impl that did not inherit the context reports
// Synchronous, which is exactly right -- it has no hook, so there is nothing to
// wait for and teardown proceeds immediately.
template<class T>
inline auto maybeSetUnloadFinished(T& impl, std::function<void()> cb)
-> std::enable_if_t<std::is_base_of_v<LogosModuleContext, T>>
{
static_cast<LogosModuleContext&>(impl)._logosCoreSetUnloadFinished_(std::move(cb));
}
template<class T>
inline auto maybeSetUnloadFinished(T&, std::function<void()>)
-> std::enable_if_t<!std::is_base_of_v<LogosModuleContext, T>>
{
}
template<class T>
inline auto maybeAboutToUnload(T& impl)
-> std::enable_if_t<std::is_base_of_v<LogosModuleContext, T>, LogosShutdown>
{
return static_cast<LogosModuleContext&>(impl)._logosCoreAboutToUnload_();
}
template<class T>
inline auto maybeAboutToUnload(T&)
-> std::enable_if_t<!std::is_base_of_v<LogosModuleContext, T>, LogosShutdown>
{
return LogosShutdown::Synchronous;
}
} // namespace _logos_codegen_
#endif // LOGOS_MODULE_CONTEXT_H