mirror of https://github.com/embarklabs/embark.git
de8f2170ba
In https://github.com/embarklabs/embark/pull/2330#discussion_r389906144 we've changed the `solc` plugin to read its `pluginConfig` from `embark.config`. This was done under the assumption that the `embark.config` is always properly populated with a dedicated `pluginConfig`. In our testing environment we pass `Embark` objects to plugins, while in reality, we pass `Plugin` instances. These two are different in nature, so relying on `embark.config` inside the plugin seemed the most pragmatic way forward without introducing a bigger refactoring in the testing APIs. Unfortunately it turned out that `embark.config` isn't populated with a `pluginConfig` which essentially caused it to break apps. This commit reverts that change done in the mentioned PR and patches the Embark testing API to behave like a `Plugin` while still being an `Embark` instance. |
||
---|---|---|
.. | ||
accounts-manager | ||
basic-pipeline | ||
coverage | ||
debugger | ||
deploy-tracker | ||
embarkjs | ||
ens | ||
ethereum-blockchain-client | ||
ganache | ||
geth | ||
graph | ||
ipfs | ||
mocha-tests | ||
nethermind | ||
parity | ||
plugin-cmd | ||
profiler | ||
quorum | ||
rpc-manager | ||
scaffolding | ||
scripts-runner | ||
snark | ||
solc | ||
solidity | ||
solidity-tests | ||
specialconfigs | ||
suggestions | ||
swarm | ||
transaction-logger | ||
transaction-tracker | ||
vyper | ||
web3 | ||
whisper-geth | ||
whisper-parity | ||
.gitignore |