embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
embark/packages
History
Pascal Precht 3ce666b165 fix(cockpit/console): ensure console for processes is rendered 
Prior to this commit, `Console` would only be rendered when Embark's API returns
at least one registered process from `/embark-api/processes`.
`Console` itself would then add another processes "embark" resulting in two tabs
with console output. This used to work fine because Embark always registered
at least a blockchain process.

In cd934f8157 however, this has changed.
With Ganache being the default blockchain, there's no longer a processes registered for this
service, resulting in an empty list for `processes` inside Cockpit, causing `Console` not to render
at all. Which also means the `embark` process logs aren't rendered either.

This commit removes the requirement of `processes` being non-empty so that embark process
logs are always shown.

It also fixes `Console` to updates its own `processes` state when its properties change.
This is needed because it's no longer guarded by `DataWrapper`, which previously ensured
`Console` is only rendered when there are processes.

Kudos to @jrainville for helping me cracking this nut.
 		2020-04-02 14:03:23 -04:00
..
cockpit fix(cockpit/console): ensure console for processes is rendered 2020-04-02 14:03:23 -04:00
core chore(prerelease): 5.3.0-nightly.15 2020-03-26 00:15:45 +00:00
embark chore(prerelease): 5.3.0-nightly.15 2020-03-26 00:15:45 +00:00
embarkjs chore(prerelease): 5.3.0-nightly.15 2020-03-26 00:15:45 +00:00
plugins fix(plugins/solc): don't read pluginConfig from plugin.config 2020-04-02 10:55:58 +02:00
stack chore(prerelease): 5.3.0-nightly.15 2020-03-26 00:15:45 +00:00
utils fix(plugins/solc): don't read pluginConfig from plugin.config 2020-04-02 10:55:58 +02:00
.yarnrc
…