embarklabs
/
embark
mirror of https://github.com/embarklabs/embark.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(@embark/library-manager): add a check/warning for `"1.0.0-beta"` web3 version in installAll 

A check is already in place in `package/embark-web3` but `installAll` of the
library manager needs the same.
This commit is contained in:
Michael Bradley, Jr 2019-08-08 19:29:53 -05:00 committed by Michael Bradley
parent beebbe6e58
commit 6dd0628a86
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/embark-library-manager/src/index.js
View File

@ -28,6 +28,12 @@ class LibraryManager {
let web3VersionInConfig = this.contractsConfig.versions["web3"]; let web3VersionInConfig = this.contractsConfig.versions["web3"];
let ipfsApiVersion = this.storageConfig.versions["ipfs-api"]; let ipfsApiVersion = this.storageConfig.versions["ipfs-api"];
if (web3VersionInConfig === "1.0.0-beta") {
const embarkWeb3Version = this.embark.config.package.dependencies["web3"];
web3VersionInConfig = embarkWeb3Version;
this.embark.logger.warn(`web3 version in embark.json is 1.0.0-beta, using ${embarkWeb3Version} instead, please update your project's embark.json`);
}
this.versions['solc'] = solcVersionInConfig; this.versions['solc'] = solcVersionInConfig;
this.versions['web3'] = web3VersionInConfig; this.versions['web3'] = web3VersionInConfig;
this.versions['ipfs-api'] = ipfsApiVersion; this.versions['ipfs-api'] = ipfsApiVersion;