From 6dd0628a866fb053d002fe51cea22507dc4d4221 Mon Sep 17 00:00:00 2001 From: "Michael Bradley, Jr" Date: Thu, 8 Aug 2019 19:29:53 -0500 Subject: [PATCH] fix(@embark/library-manager): add a check/warning for `"1.0.0-beta"` web3 version in installAll A check is already in place in `package/embark-web3` but `installAll` of the library manager needs the same. --- packages/embark-library-manager/src/index.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/embark-library-manager/src/index.js b/packages/embark-library-manager/src/index.js index 279984dcf..83b81883a 100644 --- a/packages/embark-library-manager/src/index.js +++ b/packages/embark-library-manager/src/index.js @@ -28,6 +28,12 @@ class LibraryManager { let web3VersionInConfig = this.contractsConfig.versions["web3"]; let ipfsApiVersion = this.storageConfig.versions["ipfs-api"]; + if (web3VersionInConfig === "1.0.0-beta") { + const embarkWeb3Version = this.embark.config.package.dependencies["web3"]; + web3VersionInConfig = embarkWeb3Version; + this.embark.logger.warn(`web3 version in embark.json is 1.0.0-beta, using ${embarkWeb3Version} instead, please update your project's embark.json`); + } + this.versions['solc'] = solcVersionInConfig; this.versions['web3'] = web3VersionInConfig; this.versions['ipfs-api'] = ipfsApiVersion;