Calum Lind
98add5fecd
[Lint] Fix issues raised by minify script
2016-11-28 12:58:27 +00:00
Calum Lind
5e1603317a
Revert "Rename version.py to calc_version.py to fix buildd error"
...
This reverts commit 943a9ded00
.
2016-11-26 19:35:53 +00:00
Calum Lind
943a9ded00
Rename version.py to calc_version.py to fix buildd error
...
- There is a version.py included with buildd that is conflicting
with the deluge one. Rather than messing with sys.path it is
simplest to rename version.py to calc_version.py
2016-11-26 17:51:07 +00:00
Calum Lind
04370b38ec
Revert "[Setup] Fix buildd error with version.py import"
...
This reverts commit 3aff57600f
.
2016-11-26 17:10:13 +00:00
Calum Lind
3aff57600f
[Setup] Fix buildd error with version.py import
...
- The deb buildd command also has a version.py so need to use relative import
to specify that we really mean deluge supplied version.py.
2016-11-26 16:36:31 +00:00
Calum Lind
874249655d
[Tests] Replace isort test with flake8-isort
...
* Move the known_third_party back to setup.cfg with comments.
2016-11-25 12:43:50 +00:00
Calum Lind
7ebd69218f
[Common] Fix is_ipv6 when using ipaddress module
...
* The ipaddress module require unicode string for 'packed' addresses.
* Also include minor corrections to the tests.
2016-11-23 11:04:12 +00:00
bendikro
0edebda1c7
[WebUI] Log correct http address if listening on IPv6
2016-11-22 22:07:03 +00:00
Calum Lind
7283e8b668
[Core] Deprecate prioritize_first_last for prioritize_first_last_pieces
2016-11-22 20:45:58 +00:00
Calum Lind
f3f380553a
[Core] Fix KeyError if only file_priorities in options
2016-11-22 20:45:57 +00:00
Calum Lind
4a9d2d2129
[Core] Decorate methods deprecated
2016-11-22 20:45:57 +00:00
Calum Lind
cf343c21a8
[Base] Add new deprecated decorator
2016-11-22 20:45:57 +00:00
Calum Lind
179de3b0ff
[ #495 ] Deprecate core.set_torrent_* for core.set_torrent_options
2016-11-22 20:45:57 +00:00
Calum Lind
720d113a9a
[GTKUI] Fix typo in About dialog if-statement
2016-11-21 21:47:07 +00:00
Calum Lind
59c9584fe0
[GTKUI] Revert use of non-existent mainwindow.get_window method
2016-11-19 10:36:51 +00:00
Calum Lind
674610ef7d
[GTKUI] Use get_window for GdkWindow instead of attribute
2016-11-19 10:32:31 +00:00
Calum Lind
b8135617ae
Revert "[GTKUI] Add MainWindow.get_window() and replace window attr usage"
...
Made a mistake with types of window, get_window actually refers to GdkWindow
rather than GtkWindow... The use of self.window.window is confusing and is
still deprecated in Gtk3 so will fix that in following commit.
This reverts commit ccfe6b3c80
.
2016-11-19 10:27:34 +00:00
Calum Lind
6ac296118d
[GTKUI] Replace decode_string with decode(utf-8)
...
* We know that GTK widgets will return utf-8 encoded so no need to decode_string.
2016-11-17 12:33:23 +00:00
Calum Lind
ecf9822ac0
[Docs] Fix example and param notation in reST docstrings
...
* For future parsing into other docstring styles.
2016-11-17 12:33:23 +00:00
Calum Lind
c1249a2f3a
[GTKUI] Switch to non-deprecated GTK methods
2016-11-17 12:33:23 +00:00
Calum Lind
36cbfa8c61
[Lint] Fix files to pass Flake8 v3.2.0
2016-11-17 12:19:41 +00:00
Calum Lind
2657cc3921
[Lint] Quote cleanup
2016-11-17 10:19:59 +00:00
Calum Lind
441861786b
[GTKUI] Add decode_string to column name comparison
...
* Strings from GTK are returned utf8 encoded so require decoding if
comparing with unicode strings passed around in python code.
2016-11-11 22:22:50 +00:00
Calum Lind
0cdf0230e9
[GTKUI] Refactor gtk imports and code
...
* Where possible use 'from gtk import ...', i.e. if repeated often or under 10 individual imports.
* Remove osx_check to not show svg. It's only an issue on Windows so should work fine...
* Rearrange and deduplicate code into d.u.g.common for getting pixbuf from files.
* Use 'from gtk.gdk import...' to make it cleaner to apply GTK3 changes in future.
* Move generic icon code from torrent_data_funcs to common.
* Fix pylint import warnings and add WindowsError to pylintrc file.
2016-11-11 22:21:51 +00:00
Calum Lind
c8e6a4476d
[GTKUI] Another update of methods to latest GTK2 API 2.24
...
* These updates make the code more compatible with GTK3
2016-11-11 14:08:25 +00:00
Calum Lind
ccfe6b3c80
[GTKUI] Add MainWindow.get_window() and replace window attr usage
...
* In GTK3 the use of `window` attribute is no longer valid so need to
use get_window(). This updates MainWindow to follow the same convention.
2016-11-11 14:08:25 +00:00
Calum Lind
86549eb3ee
[GTKUI] Cleanup references to MainWindow
2016-11-11 14:08:25 +00:00
Calum Lind
243004c551
[GTKUI] Remove About dialog unneeded url_hook
...
* This is removed in Gtk3 and clicking url in Gtk2 still works.
2016-11-11 14:08:25 +00:00
Calum Lind
8ba8aec277
[GTKUI] Listview use lambda func for set_default_sort_func
...
* gi complains about `None` value being passed to set_default_sort_func
so for compatibility use lamba func that does nothing.
There is an unanswered question on SO about how to set the default func to None in gi:
http://stackoverflow.com/questions/20940324/how-to-remove-the-default-sort-function-from-a-treesortable
2016-11-11 14:08:25 +00:00
Calum Lind
a5b07aa4ef
[GTKUI] Update methods to latest GTK2 API 2.24
2016-11-11 14:08:24 +00:00
Calum Lind
c619674cf9
[GTKUI] Import gobject module names directly
2016-11-11 14:08:24 +00:00
Calum Lind
52d591c83b
[GTKUI] Remove unneeded pygtk requires check
2016-11-11 14:08:24 +00:00
Calum Lind
4313974f07
[Lang] Add fallback dll for Windows libintl
2016-11-11 14:08:24 +00:00
Calum Lind
bde13515e6
[Common] Only attempt dbus import on non-Win/OSX
2016-11-11 14:08:24 +00:00
Calum Lind
93ab2445a1
[GTKUI] Update version string in ui files
2016-11-09 15:01:44 +00:00
Calum Lind
eea3cb0553
[GTKUI] Tweak spacing of main window tabs
2016-11-08 21:09:01 +00:00
Calum Lind
6bd3c6fa88
[ #2922 ] [Core] Fix using incorrect type for peer_tos in lt 1.1
2016-11-08 20:25:16 +00:00
Calum Lind
b6e2ec3a3c
[Core] Remove redundant utf8 encoding
...
* Should only be encoding in config.py and this is already occurs.
2016-11-08 20:16:59 +00:00
Calum Lind
bbe9de9463
[Core] Disable apply_settings for enc policy until fix can be found
2016-11-06 00:14:07 +00:00
Calum Lind
2bdbcf9a39
[ #2922 ] Fix interfaces and outgoing ports for lt 1.1
2016-11-05 23:30:01 +00:00
Calum Lind
fd80ed75fe
[ #2922 ] Fix proxy settings and torrent status for lt 1.1
2016-11-05 15:49:39 +00:00
Calum Lind
0890cc1a33
[ #2922 ] Fix session.apply_sessings alert_mask
2016-11-05 11:30:31 +00:00
Calum Lind
e31acfc31c
[GTKUI] Restart application when switching modes
2016-11-04 23:54:46 +00:00
Calum Lind
d0d070aaf0
[Lint] Fix flake8
2016-11-04 23:54:23 +00:00
Calum Lind
1e41891943
[Oops] Bugfix for previous commit: e37c817
2016-11-04 18:07:59 +00:00
Calum Lind
e37c817151
[Lint] Refactor flake8 noqa's and add msg numbers
...
From pep8-naming:
* N802: function name should be lowercase
* N803: argument name should be lowercase
2016-11-04 18:03:21 +00:00
Calum Lind
af6b277d28
[Lint] Add flake8-quotes to tox and fix bad quotes
2016-11-04 00:10:23 +00:00
Calum Lind
3a2ff0c188
[Lint] Convert all python double quotes to single quotes
...
* A rather disruptive change but for a few reasons such as easier to read,
easier type, keep consistent and javascript code uses single quotes.
* There are a few exceptions for the automated process:
* Any double quotes in comments
* Triple double quotes for docstrings
* Strings containing single quotes are left e.g. "they're"
* To deal with merge conflicts from feature branches it is best to follow
these steps for each commit:
* Create a patch: `git format-patch -1 <sha1>`
* Edit the patch and replace double quotes with single except those in
comments or strings containing an unescaped apostrophe.
* Check the patch `git apply --check <patchfile>` and fix any remaining
issues if it outputs an error.
* Apply the patch `git am < <patchfile>`
2016-11-03 21:45:45 +00:00
Calum Lind
d4a8a38586
[Core] Refactor out duplicate prefsmgr log lines
2016-11-03 12:05:55 +00:00
Calum Lind
a87ce825ad
[Core] Remove old geoip.dat code and fix log line
2016-11-03 11:37:20 +00:00