Calum Lind
0ba87b424c
Revert "[#2848|Core] Fix incorrect share ratio in torrent status"
...
This reverts commit 7b87a93862
.
After further discussion in the ticket this change is undesired.
> I wrongly assumed that private trackers will count how many bytes you
> download but they don't, they track how many parts(or chunks?) you
> have, when you announce it. So using total_done is fine, no change
> needed.
> Checking for private flag and using total_wanted_done for public
> enables users to be a bit more selfish. They can start a torrent,
> let it run for a bit then deselect the files they don't want and
> only upload enough to make up for what they wanted to download. This
> means they may upload less than they downloaded, hurting the swarm.
> So I personally don't think this would be a good change.
> Overall my suggestion is to close this as not a bug.
2017-10-29 12:36:15 +00:00
Calum Lind
53f818e176
[ #3070 ] Fix httpdownloader error with missing content-disposition filename
...
The parsing of the content-disposition in httpdownloader was not able to
handle missing parameters e.g. "Content-Disposition: attachment" and would
result in an IndexError. Added a test for this use-case.
Fixed the issue using the cgi.parse_header to extract the parameters.
2017-10-29 12:32:32 +00:00
Calum Lind
00dcd60d56
[Lint] Fix flake8 issues with l as var
2017-10-29 11:39:52 +00:00
Calum Lind
1730230244
[#3124|GTKUI] Fix comparing Name str if value is None
...
The original fix was not correct as the strcoll function cannot
accept None only strings. This fix ensures that the value is an
empty string if None for comparison.
2017-10-29 11:16:13 +00:00
Calum Lind
0728c03c1c
[#3066|Core] Add rather than replace dht bootstrap nodes in lt
2017-10-29 10:36:45 +00:00
Calum Lind
354372b2ea
[Notifications] Remove duplicate heading on prefs page
...
The heading is provided by prefs add_page so remove from glade file.
2017-10-16 21:57:08 +01:00
DjLegolas
d169aca8bd
[Notifications]Fix no text in tab list
...
The tab in the Preferences window is created and clickable - only the
text is missing.
2017-10-16 14:15:17 +03:00
Calum Lind
26720ca4c2
[AutoAdd] Fix handling deferred torrents
...
* The changes to core api now return a deferred instead of torrent_id
so need to update autoadd to use callbacks.
* Minor refactor to save one indentation level and reuse fail callback.
* Add exception handler for any errors from label plugin.
2017-10-14 21:39:30 +01:00
DjLegolas
510a8b50b2
[AutoAdd] Update gtkui from libglade to gtkbuilder
2017-10-14 21:30:45 +01:00
DjLegolas
d190f149d1
[WebUi] Update gtkui from libglade to gtkbuilder
2017-10-14 20:13:53 +01:00
DjLegolas
24a31b1194
[Notifications] Update gtkui from libglade to gtkbuilder
2017-10-14 20:13:53 +01:00
DjLegolas
470490769f
[Extractor] Update gtkui from libglade to gtkbuilder
2017-10-14 20:13:53 +01:00
DjLegolas
1259eca8ad
[Execute] Update gtkui from libglade to gtkbuilder
2017-10-14 20:13:53 +01:00
DjLegolas
f0316d3e31
[Blocklist] Update gtkui from libglade to gtkbuilder
2017-10-14 20:13:53 +01:00
bendikro
9b580a87fa
[GKTUI] Fix high priority files tab trigger
2017-10-14 20:06:14 +01:00
Calum Lind
4bee1ce811
[Travis] Use current Trusty image
...
The issue with virtualenv site-packages was fixed : travis-ci/travis-cookbooks#878
2017-10-14 20:00:14 +01:00
Calum Lind
e3f537770f
[UI] Fix setting gettext to unicode for Py2 compat
2017-07-05 12:18:35 +01:00
Calum Lind
9b92bc2baf
[#3076|UI] Add ngettext and alias _n for plural translations
...
* Fixes use of _n() in console rm command
2017-07-05 09:46:12 +01:00
Calum Lind
51b99caf24
[Common] Add decode_string (deprecated) for compatibility
2017-06-29 15:28:52 +01:00
Calum Lind
850fd34522
[ #3084 ] Fix error changing ownership on torrents
2017-06-29 15:07:11 +01:00
Calum Lind
9164dafe69
[ #3083 ] Fix missing common.utf8_encoded for backward compatibility
2017-06-29 14:42:16 +01:00
Calum Lind
33e9545cd4
[ #3079 ] Fix config parsing for json objects
...
* If a curly brace was used in a string then find_json_ojects would
fail to find objects correctly. To fix this ignore double-quoted entries.
2017-06-28 10:32:45 +01:00
Calum Lind
7b87a93862
[#2848|Core] Fix incorrect share ratio in torrent status
...
* Use total_wanted_done to increase the accuracy of the calculated ratio.
2017-06-27 19:02:15 +01:00
Calum Lind
51bde704b5
[Packaging] Simplify release script using sdist
...
* setup.py sdist now creates a pristine tar which can be used for release.
* Uses the version currently checked-out in git.
* Removed unneeded lines in manifest.
2017-06-27 18:12:51 +01:00
Calum Lind
3f13c24362
Update MANIFEST for wanted/unwanted files
2017-06-27 15:12:13 +01:00
Calum Lind
6837d83f5b
Fix setup.py requiring gen_web_gettext
2017-06-27 15:11:19 +01:00
Calum Lind
3c1d7da698
[Packaging] Apply fixes to OSX app scripts
...
* Fix path to dist dir
* Rename dylib with new soversion for lt 1.1.x
* Create Info.plist with version and year automatically
2017-06-27 14:00:06 +01:00
Calum Lind
d6731b8cee
[#3078|GTKUI] Apply workaround for showing the OSX menu
...
Commenting out the remove_accelerator fixes showing the menubar correctly.
2017-06-27 09:16:51 +01:00
Calum Lind
fe80703f95
[Packaging] Fix py2app build
2017-06-27 09:16:51 +01:00
Calum Lind
1808ac506a
[GTKUI] Restore removed os_check for systray icon
...
status_icon_new_from_icon_name does not work on OSX
2017-06-27 09:16:51 +01:00
Calum Lind
3174c7534d
[Core] Ensure tracker error message is decoded
2017-06-27 09:16:51 +01:00
Calum Lind
065729a389
[OSX] Fix converting mac_ver to string
2017-06-27 09:16:51 +01:00
Calum Lind
d250e0a486
[Packaging] Ensure sdist tarball contains correct files
2017-06-25 19:22:13 +01:00
Calum Lind
3f1ff54887
[Packaging] Fix using wrong commit id
2017-06-25 19:22:13 +01:00
Calum Lind
0424543e36
Update author details
2017-06-25 19:22:13 +01:00
Calum Lind
d0cb45808c
Exclude test and plugin files from build dir
2017-06-25 19:22:13 +01:00
Calum Lind
0cc0882ac9
[WebUI] Refactor out AuthError for NotAuthorizedError
2017-06-23 12:19:39 +01:00
Calum Lind
a7c4228ce7
Update systemd service files
...
- Add man page link
- Ensure deluge-web is not daemonised
2017-06-23 10:12:07 +01:00
Calum Lind
ce3a8c0c17
[Travis] Pin to older trusty build
2017-06-17 04:00:22 +01:00
Calum Lind
ace531e8ae
[WebUI] Fix testing array after removing torrents
2017-06-17 03:49:30 +01:00
Calum Lind
2c66a4c29e
[#2707|WebUI] Ensure var test for getSelectedRecords value
...
* Fixes potential for TypeError undefined in browser console.
2017-06-17 03:47:48 +01:00
Calum Lind
6e66452cf3
[GTKUI] Add a prefix space for seed rank `k` unit
2017-06-17 03:29:16 +01:00
Calum Lind
cb646f3a4f
Update changelog and gettext
2017-06-16 19:15:05 +01:00
Calum Lind
32d5392776
[#2499|GTKUI] Add key shortcuts for changing queue position
...
- Ctrl+Alt+[Shift]+{Up|Down}
2017-06-16 16:56:33 +01:00
Calum Lind
03ca4cfa46
[#2354|GTKUI] Fix alt-f conflict between Tabs and Menu
2017-06-16 14:41:54 +01:00
Calum Lind
fb4307f748
Revert "[ #2341 ] Use common.resource_filename in plugins"
...
Using common.resource_filename broke plugins so need to find a better solution for non-ascii dirs.
This reverts commit bdb3b509ad
.
2017-06-16 14:23:10 +01:00
Calum Lind
3893d3e214
Revert "[Plugins] Replace pkg_resources for abspath and decode path"
...
This reverts commit 85364dc8ab
.
2017-06-16 11:15:19 +01:00
Calum Lind
2b90f309a6
[WebUI] Refactor host connect methods
2017-06-16 08:03:42 +01:00
Calum Lind
fb71d049b1
[#3068|WebUI] Fix not connecting to default daemon
2017-06-16 07:45:26 +01:00
Calum Lind
89e245e2d3
[#3058|GTKUI] Fix unable to add user to daemon
2017-06-16 01:18:34 +01:00