From 809d7edc110022235672950830e3ebbeebded114 Mon Sep 17 00:00:00 2001 From: Aaryamann Challani <43716372+rymnc@users.noreply.github.com> Date: Tue, 21 May 2024 21:30:07 +0530 Subject: [PATCH] fix(ci): remove unused jobs (#2) * fix(ci): remove unused jobs * fix: remove verify in pr template * fix: readme fixes --- .github/PULL_REQUEST_TEMPLATE.md | 1 - .../workflows/add-issue-to-project-board.yml | 18 ------- .github/workflows/add-pr-to-project-board.yml | 18 ------- .github/workflows/ci.yml | 49 ------------------- README.md | 2 +- certora/certora.conf | 8 --- certora/specs/Foo.spec | 9 ---- package.json | 1 - 8 files changed, 1 insertion(+), 105 deletions(-) delete mode 100644 .github/workflows/add-issue-to-project-board.yml delete mode 100644 .github/workflows/add-pr-to-project-board.yml delete mode 100644 certora/certora.conf delete mode 100644 certora/specs/Foo.spec diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b575162..b656768 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,4 +8,3 @@ Ensure you completed **all of the steps** below before submitting your pull requ - [ ] Added natspec comments? - [ ] Ran `pnpm adorno`? -- [ ] Ran `pnpm verify`? diff --git a/.github/workflows/add-issue-to-project-board.yml b/.github/workflows/add-issue-to-project-board.yml deleted file mode 100644 index 896f2e7..0000000 --- a/.github/workflows/add-issue-to-project-board.yml +++ /dev/null @@ -1,18 +0,0 @@ -name: Add issue to task board - -on: - issues: - types: - - opened - -jobs: - add-to-project: - name: Add to task board - runs-on: ubuntu-latest - steps: - - uses: actions/add-to-project@v0.5.0 - with: - # You can target a project in a different organization - # to the issue - project-url: https://github.com/orgs/vacp2p/projects/10 - github-token: ${{ secrets.ADD_TO_VAC_BOARD_PAT }} diff --git a/.github/workflows/add-pr-to-project-board.yml b/.github/workflows/add-pr-to-project-board.yml deleted file mode 100644 index e5812cc..0000000 --- a/.github/workflows/add-pr-to-project-board.yml +++ /dev/null @@ -1,18 +0,0 @@ -name: Add PR task board - -on: - pull_request: - types: - - opened - -jobs: - add-to-project: - name: Add to task board - runs-on: ubuntu-latest - steps: - - uses: actions/add-to-project@v0.5.0 - with: - # You can target a project in a different organization - # to the issue - project-url: https://github.com/orgs/vacp2p/projects/10 - github-token: ${{ secrets.ADD_TO_VAC_BOARD_PAT }} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b65bfd4..e2a88e0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,7 +1,6 @@ name: "CI" env: - API_KEY_ALCHEMY: ${{ secrets.API_KEY_ALCHEMY }} FOUNDRY_PROFILE: "ci" on: @@ -121,51 +120,3 @@ jobs: run: | echo "## Coverage result" >> $GITHUB_STEP_SUMMARY echo "✅ Uploaded to Codecov" >> $GITHUB_STEP_SUMMARY - verify: - needs: ["lint", "build"] - runs-on: ubuntu-latest - - steps: - - uses: actions/checkout@v3 - with: - submodules: recursive - - - name: Install Python - uses: actions/setup-python@v2 - with: { python-version: 3.9 } - - - name: Install Java - uses: actions/setup-java@v1 - with: { java-version: "11", java-package: jre } - - - name: Install Certora CLI - run: pip3 install certora-cli==5.0.5 - - - name: Install Solidity - run: | - wget https://github.com/ethereum/solidity/releases/download/v0.8.19/solc-static-linux - chmod +x solc-static-linux - sudo mv solc-static-linux /usr/local/bin/solc - - - name: "Install Pnpm" - uses: "pnpm/action-setup@v2" - with: - version: "8" - - - name: "Install Node.js" - uses: "actions/setup-node@v3" - with: - cache: "pnpm" - node-version: "lts/*" - - - name: "Install the Node.js dependencies" - run: "pnpm install" - - - name: Verify rules - run: "pnpm verify" - env: - CERTORAKEY: ${{ secrets.CERTORAKEY }} - - strategy: - fail-fast: false - max-parallel: 16 diff --git a/README.md b/README.md index 2fb91ea..030cffd 100644 --- a/README.md +++ b/README.md @@ -8,8 +8,8 @@ [license-badge]: https://img.shields.io/badge/License-MIT-blue.svg Waku's RLNv2 contracts, which include - -- LazyIMT, which allows the root of the chain to be accessible on-chain. +- LazyIMT, which allows the root of the chain to be accessible on-chain. ## What's Inside diff --git a/certora/certora.conf b/certora/certora.conf deleted file mode 100644 index 72883d7..0000000 --- a/certora/certora.conf +++ /dev/null @@ -1,8 +0,0 @@ -{ - "files": ["src/Foo.sol"], - "msg": "Verifying Foo.sol", - "rule_sanity": "basic", - "verify": "Foo:certora/specs/Foo.spec", - "wait_for_results": "all", -} - diff --git a/certora/specs/Foo.spec b/certora/specs/Foo.spec deleted file mode 100644 index ed4bc13..0000000 --- a/certora/specs/Foo.spec +++ /dev/null @@ -1,9 +0,0 @@ -methods { - function id(uint256) external returns (uint256) envfree; -} - -rule checkIdOutputIsAlwaysEqualToInput { - uint256 input; - - assert id(input) == input; -} diff --git a/package.json b/package.json index 3891007..eb496a3 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,6 @@ "scripts": { "clean": "rm -rf cache out", "lint": "pnpm lint:sol && pnpm prettier:check", - "verify": "certoraRun certora/certora.conf", "lint:sol": "forge fmt --check && pnpm solhint {script,src,test,certora}/**/*.sol", "prettier:check": "prettier --check **/*.{json,md,yml} --ignore-path=.prettierignore", "prettier:write": "prettier --write **/*.{json,md,yml} --ignore-path=.prettierignore",