bug fixes for nwaku 2436 and 2286 (#26)

This commit is contained in:
fbarbu15 2024-03-22 15:55:06 +02:00 committed by GitHub
parent 82d7ffd3fe
commit 17ba9baf45
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 6 additions and 6 deletions

View File

@ -127,7 +127,7 @@ class StepsFilter:
{"requestId": request_id, "contentFilters": content_topic_list, "pubsubTopic": pubsub_topic} {"requestId": request_id, "contentFilters": content_topic_list, "pubsubTopic": pubsub_topic}
) )
assert filter_sub_response["requestId"] == request_id assert filter_sub_response["requestId"] == request_id
assert filter_sub_response["statusDesc"] in ["OK", ""] # until https://github.com/waku-org/nwaku/issues/2286 is fixed assert filter_sub_response["statusDesc"] in ["OK"]
@allure.step @allure.step
def subscribe_optional_filter_nodes(self, content_topic_list, pubsub_topic=None): def subscribe_optional_filter_nodes(self, content_topic_list, pubsub_topic=None):
@ -168,7 +168,7 @@ class StepsFilter:
else: else:
assert delete_sub_response["requestId"] == subscription["requestId"] assert delete_sub_response["requestId"] == subscription["requestId"]
if status is None: if status is None:
assert delete_sub_response["statusDesc"] in ["OK", ""] # until https://github.com/waku-org/nwaku/issues/2286 is fixed assert delete_sub_response["statusDesc"] in ["OK"]
else: else:
assert status in delete_sub_response["statusDesc"] assert status in delete_sub_response["statusDesc"]
@ -178,7 +178,7 @@ class StepsFilter:
node = self.node2 node = self.node2
delete_sub_response = node.delete_all_filter_subscriptions(request_id) delete_sub_response = node.delete_all_filter_subscriptions(request_id)
assert delete_sub_response["requestId"] == request_id["requestId"] assert delete_sub_response["requestId"] == request_id["requestId"]
assert delete_sub_response["statusDesc"] in ["OK", ""] # until https://github.com/waku-org/nwaku/issues/2286 is fixed assert delete_sub_response["statusDesc"] in ["OK"]
@allure.step @allure.step
def ping_filter_subscriptions(self, request_id, node=None): def ping_filter_subscriptions(self, request_id, node=None):
@ -186,7 +186,7 @@ class StepsFilter:
node = self.node2 node = self.node2
ping_sub_response = node.ping_filter_subscriptions(request_id) ping_sub_response = node.ping_filter_subscriptions(request_id)
assert ping_sub_response["requestId"] == request_id assert ping_sub_response["requestId"] == request_id
assert ping_sub_response["statusDesc"] in ["OK", ""] # until https://github.com/waku-org/nwaku/issues/2286 is fixed assert ping_sub_response["statusDesc"] in ["OK"]
def ping_without_filter_subscription(self, node=None): def ping_without_filter_subscription(self, node=None):
try: try:

View File

@ -42,7 +42,7 @@ class TestFilterGetMessages(StepsFilter):
def test_filter_get_message_with_meta(self): def test_filter_get_message_with_meta(self):
self.check_published_message_reaches_filter_peer(self.create_message(meta=to_base64(self.test_payload))) self.check_published_message_reaches_filter_peer(self.create_message(meta=to_base64(self.test_payload)))
@pytest.mark.xfail(reason="Bug reported: https://github.com/waku-org/nwaku/issues/2436") @pytest.mark.xfail("go-waku" in NODE_2, reason="Bug reported: https://github.com/waku-org/go-waku/issues/1068")
def test_filter_get_message_with_ephemeral(self): def test_filter_get_message_with_ephemeral(self):
failed_ephemeral = [] failed_ephemeral = []
for ephemeral in [True, False]: for ephemeral in [True, False]:

View File

@ -168,7 +168,7 @@ class TestRelayPublish(StepsRelay):
except Exception as ex: except Exception as ex:
assert "Bad Request" in str(ex) assert "Bad Request" in str(ex)
@pytest.mark.xfail(reason="Bug reported: https://github.com/waku-org/nwaku/issues/2436") @pytest.mark.xfail("go-waku" in NODE_2, reason="Bug reported: https://github.com/waku-org/go-waku/issues/1068")
def test_publish_with_ephemeral(self): def test_publish_with_ephemeral(self):
failed_ephemeral = [] failed_ephemeral = []
for ephemeral in [True, False]: for ephemeral in [True, False]: