From 17c7e821f5e20a168c02ebb54b692a544bc74b2d Mon Sep 17 00:00:00 2001
From: NagyZoltanPeter <113987313+NagyZoltanPeter@users.noreply.github.com>
Date: Fri, 26 Jul 2024 11:57:32 +0200
Subject: [PATCH] Fix review findings, clarifications.
---
standards/core/lightpush.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/standards/core/lightpush.md b/standards/core/lightpush.md
index 75585e1..7394574 100644
--- a/standards/core/lightpush.md
+++ b/standards/core/lightpush.md
@@ -36,9 +36,9 @@ message LightPushRequest {
message LightPushResponse {
string request_id = 1;
- uint32 status_code = 10; // non zero in case of failure, see appendix
+ uint32 status_code = 10; // has value 200 in case of success, see appendix
optional string status_desc = 11;
- optional uint32 relay_peer_count = 12; // number of peers, message is successfully relayed to
+ optional uint32 relay_peer_count = 12; // number of peers, the message is successfully relayed to
}
```
@@ -47,7 +47,7 @@ message LightPushResponse {
Nodes that respond to `LightPushRequest` SHOULD
- either relay the encapsulated message via [11/WAKU2-RELAY](https://rfc.vac.dev/waku/standards/core/11/relay) protocol on the specified `pubsub_topic`
- or perform another requested service.
- `Services beyond [11/WAKU2-RELAY](https://rfc.vac.dev/waku/standards/core/11/relay) are as yet underdefined.`
+ `Services beyond [11/WAKU2-RELAY](https://rfc.vac.dev/waku/standards/core/11/relay) are yet to be defined.`
Depending on the network configuration, the lightpush client may not need to provide `pubsub_topic` ([WAKU2-RELAY-SHARDING](https://github.com/waku-org/specs/blob/master/standards/core/relay-sharding.md)).