From 81d03558b1fa87d0d74260a4d333e14fb5518681 Mon Sep 17 00:00:00 2001 From: Ivan Folgueira Bande <128452529+Ivansete-status@users.noreply.github.com> Date: Wed, 19 Apr 2023 14:02:54 +0200 Subject: [PATCH] Adding more detail in an error produced by 'parsePeerInfo' (#1687) * Adding more detail in an error produced by 'parsePeerInfo' * utils/peers.nim: casting to 'string' in a more idiomatic/convenient way --- waku/v2/utils/peers.nim | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/waku/v2/utils/peers.nim b/waku/v2/utils/peers.nim index e7fa1f057..1f0384f91 100644 --- a/waku/v2/utils/peers.nim +++ b/waku/v2/utils/peers.nim @@ -119,7 +119,7 @@ proc parsePeerInfo*(peer: RemotePeerInfo|string): if peer is RemotePeerInfo: return ok(cast[RemotePeerInfo](peer)) - let multiAddr = ? MultiAddress.init(cast[string](peer)) + let multiAddr = ? MultiAddress.init($peer) .mapErr(proc(err: string): string = "MultiAddress.init [" & err & "]") @@ -136,12 +136,12 @@ proc parsePeerInfo*(peer: RemotePeerInfo|string): let p2pPartStr = p2pPart.toString()[] if not p2pPartStr.contains("/"): - let msg = "Error in parsePeerInfo: p2p part should contain / [" & - p2pPartStr & "]" + let msg = "Error in parsePeerInfo: p2p part should contain / [p2pPartStr:" & + p2pPartStr & "] [peer:" & $peer & "]" return err(msg) let peerId = ? PeerID.init(p2pPartStr.split("/")[^1]) - .mapErr(proc (e:cstring):string = cast[string](e)) + .mapErr(proc (e:cstring):string = $e) if not wireAddr.validWireAddr(): return err("Error in parsePeerInfo: Invalid node multiaddress")