waku-org
/
nwaku
mirror of https://github.com/waku-org/nwaku.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: libwaku.nim: unsubscribe -> unsubscribeAll to make it build properly (#2082) 

* libwaku.nim: unsubscribe -> unsubscribeAll to make it build properly

We introduced a change in the next PR
https://github.com/waku-org/nwaku/pull/1983/
that made the `libwaku` to stop building properly
(make libwaku) because a signature change in the
`unsubscribe` proc of waku/waku_relay/protocol.nim.

This commit is a temporary workaround to make it work,
and not block any ongoing PR tests,
although not exactly as it is expected because we are
unsubscribing from all topics.

* ci.yml: adds library/** to force tests when changes under that folder
This commit is contained in:
Ivan Folgueira Bande 2023-09-26 16:32:51 +02:00 committed by GitHub
parent 6cb9a8da86
commit 3264a4f587
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/workflows/ci.yml vendored
View File

@ -33,6 +33,7 @@ jobs:
- 'vendor/**' - 'vendor/**'
- 'Makefile' - 'Makefile'
- 'waku.nimble' - 'waku.nimble'
- 'library/**'
v2: v2:
- 'waku/**' - 'waku/**'

3
library/waku_thread/inter_thread_communication/requests/protocols/relay_request.nim
View File

@ -99,7 +99,8 @@ proc process*(self: ptr RelayRequest,
node.wakuRelay.subscribe($self.pubsubTopic, self.relayEventCallback) node.wakuRelay.subscribe($self.pubsubTopic, self.relayEventCallback)
of UNSUBSCRIBE: of UNSUBSCRIBE:
node.wakuRelay.unsubscribe($self.pubsubTopic) # TODO: properly perform 'unsubscribe'
node.wakuRelay.unsubscribeAll($self.pubsubTopic)
of PUBLISH: of PUBLISH:
let numPeers = await node.wakuRelay.publish($self.pubsubTopic, let numPeers = await node.wakuRelay.publish($self.pubsubTopic,