refactor: move app.nim and networks_config.nim to waku/factory (#2608)

apps/networkmonitor/networkmonitor.nim

@@ -30,7 +30,7 @@ import
   ../../waku/waku_relay,
   ../../waku/waku_rln_relay,
   ../../waku/factory/builder,
-  ../wakunode2/networks_config,
+  ../../waku/factory/networks_config,
   ./networkmonitor_metrics,
   ./networkmonitor_config,
   ./networkmonitor_utils

apps/wakunode2/wakunode2.nim

@@ -17,8 +17,8 @@ import
   ../../tools/rln_db_inspector/rln_db_inspector,
   ../../waku/common/logging,
   ../../waku/factory/external_config,
-  ./networks_config,
-  ./app
+  ../../waku/factory/networks_config,
+  ../../waku/factory/app
 
 logScope:
   topics = "wakunode main"

library/waku_thread/inter_thread_communication/requests/node_lifecycle_request.nim

@@ -22,7 +22,7 @@ import
   ../../../../waku/waku_store,
   ../../../../waku/factory/builder,
   ../../../../waku/factory/node_factory,
-  ../../../apps/wakunode2/networks_config,
+  ../../../../waku/factory/networks_config,
   ../../../events/[json_message_event, json_base_event],
   ../../../alloc,
   ../../config

tests/wakunode2/test_app.nim

@@ -11,7 +11,7 @@ import
   libp2p/switch
 import ../testlib/common, ../testlib/wakucore, ../testlib/wakunode
 
-include ../../apps/wakunode2/app
+include ../../waku/factory/app
 
 suite "Wakunode2 - App":
   test "compilation version should be reported":

waku/factory/app.nim

@@ -155,7 +155,7 @@ proc init*(T: type App, conf: WakuNodeConf): Result[App, string] =
 
 ## Setup DiscoveryV5
 
-proc setupDiscoveryV5*(app: App): WakuDiscoveryV5 =
+proc setupDiscoveryV5(app: App): WakuDiscoveryV5 =
   let dynamicBootstrapEnrs =
     app.dynamicBootstrapNodes.filterIt(it.hasUdpPort()).mapIt(it.enr.get())