waku-org/js-waku
1
0
Fork 0
mirror of https://github.com/waku-org/js-waku.git synced 2025-02-24 18:18:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve logging for connection manager (#1303)

Browse Source 
* merge: master

* fix: CI

* use: js script instead of shell script to run precheck and mocha

* improve logging when dial fails

* use hashmap for errors instead of redeclaring variable
This commit is contained in:
Danish Arora 2023-05-11 13:35:58 +05:30 committed by GitHub
parent cc0b375018
commit f4e31019e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/core/src/lib/connection_manager.ts
View File

@ -19,6 +19,7 @@ export class ConnectionManager {
private options: ConnectionManagerOptions; private options: ConnectionManagerOptions;
private libp2pComponents: Libp2p; private libp2pComponents: Libp2p;
private dialAttemptsForPeer: Map<string, number> = new Map(); private dialAttemptsForPeer: Map<string, number> = new Map();
private dialErrorsForPeer: Map<string, any> = new Map();
public static create( public static create(
peerId: string, peerId: string,
@ -102,9 +103,10 @@ export class ConnectionManager {
this.dialAttemptsForPeer.delete(peerId.toString()); this.dialAttemptsForPeer.delete(peerId.toString());
return; return;
} catch (error) { } catch (error: any) {
log(` this.dialErrorsForPeer.set(peerId.toString(), error);
Error dialing peer ${peerId.toString()}`); log(`Error dialing peer ${peerId.toString()} - ${error.errors}`);
dialAttempt = this.dialAttemptsForPeer.get(peerId.toString()) ?? 1; dialAttempt = this.dialAttemptsForPeer.get(peerId.toString()) ?? 1;
this.dialAttemptsForPeer.set(peerId.toString(), dialAttempt + 1); this.dialAttemptsForPeer.set(peerId.toString(), dialAttempt + 1);
@ -115,7 +117,13 @@ export class ConnectionManager {
} }
try { try {
log(`Deleting undialable peer ${peerId.toString()} from peer store`); log(
`Deleting undialable peer ${peerId.toString()} from peer store. Error: ${JSON.stringify(
this.dialErrorsForPeer.get(peerId.toString()).errors[0]
)}
}`
);
this.dialErrorsForPeer.delete(peerId.toString());
return await this.libp2pComponents.peerStore.delete(peerId); return await this.libp2pComponents.peerStore.delete(peerId);
} catch (error) { } catch (error) {
throw `Error deleting undialable peer ${peerId.toString()} from peer store - ${error}`; throw `Error deleting undialable peer ${peerId.toString()} from peer store - ${error}`;