waku-org/js-waku
1
0
Fork 0
mirror of https://github.com/waku-org/js-waku.git synced 2025-02-18 07:16:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: make createSubscription private, and shorten error handling

Browse Source
This commit is contained in:
danisharora099 2024-07-30 15:51:38 +05:30
parent 6b749c91df
commit c4aa41124c
No known key found for this signature in database
GPG Key ID: FBD2BF500037F135
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/sdk/src/protocols/filter.ts
View File

@ -496,15 +496,7 @@ class FilterSDK extends BaseProtocolSDK implements IFilterSDK {
): Promise<SubscribeResult> {
const uniquePubsubTopics = this.getUniquePubsubTopics(decoders);
//TODO: check error codes
if (uniquePubsubTopics.length === 0) {
return {
subscription: null,
error: ProtocolError.INVALID_DECODER_TOPICS
};
}
if (uniquePubsubTopics.length > 1) {
if (uniquePubsubTopics.length !== 1) {
return {
subscription: null,
error: ProtocolError.INVALID_DECODER_TOPICS
@ -546,7 +538,7 @@ class FilterSDK extends BaseProtocolSDK implements IFilterSDK {
* @param pubsubTopicShardInfo The pubsub topic to subscribe to.
* @returns The subscription object.
*/
public async createSubscription(
private async createSubscription(
pubsubTopicShardInfo: ShardingParams | PubsubTopic,
options?: ProtocolUseOptions
): Promise<CreateSubscriptionResult> {