Merge #126

126: Ensure that listeners are added only when waku is initialised r=D4nte a=D4nte

this removes the `Reached max listeners` error.

Co-authored-by: Franck Royer <franck@status.im>

web-chat/src/App.tsx

@@ -2,7 +2,8 @@ import { multiaddr } from 'multiaddr';
 import PeerId from 'peer-id';
 import { useEffect, useState } from 'react';
 import './App.css';
-import { ChatMessage } from 'waku/chat_message';
+import { ChatMessage } from './ChatMessage';
+import { ChatMessage as WakuChatMessage } from 'waku/chat_message';
 import { WakuMessage } from 'waku/waku_message';
 import { RelayDefaultTopic } from 'waku/waku_relay';
 import { StoreCodec } from 'waku/waku_store';
@@ -45,15 +46,16 @@ const themes = {
 export const ChatContentTopic = 'dingpu';
 
 export default function App() {
-  let [stateMessages, setMessages] = useState<ChatMessage[]>([]);
+  let [newMessages, setNewMessages] = useState<ChatMessage[]>([]);
+  let [archivedMessages, setArchivedMessages] = useState<ChatMessage[]>([]);
   let [stateWaku, setWaku] = useState<Waku | undefined>(undefined);
   let [nick, setNick] = useState<string>(generate());
 
   useEffect(() => {
-    const handleNewMessages = (event: { data: Uint8Array }) => {
+    const handleRelayMessage = (event: { data: Uint8Array }) => {
       const chatMsg = decodeWakuMessage(event.data);
       if (chatMsg) {
-        copyAppendReplace([chatMsg], stateMessages, setMessages);
+        setNewMessages([chatMsg]);
       }
     };
 
@@ -73,8 +75,11 @@ export default function App() {
           const messages = response
             .map((wakuMsg) => wakuMsg.payload)
             .filter((payload) => !!payload)
-            .map((payload) => ChatMessage.decode(payload as Uint8Array));
+            .map((payload) => WakuChatMessage.decode(payload as Uint8Array))
-          copyMergeUniqueReplace(messages, stateMessages, setMessages);
+            .map((wakuChatMessage) =>
+              ChatMessage.fromWakuChatMessage(wakuChatMessage)
+            );
+          setArchivedMessages(messages);
         }
       }
     };
@@ -84,7 +89,7 @@ export default function App() {
         .then(() => console.log('Waku init done'))
         .catch((e) => console.log('Waku init failed ', e));
     } else {
-      stateWaku.libp2p.pubsub.on(RelayDefaultTopic, handleNewMessages);
+      stateWaku.libp2p.pubsub.on(RelayDefaultTopic, handleRelayMessage);
 
       stateWaku.libp2p.peerStore.on(
         'change:protocols',
@@ -95,7 +100,7 @@ export default function App() {
       return () => {
         stateWaku?.libp2p.pubsub.removeListener(
           RelayDefaultTopic,
-          handleNewMessages
+          handleRelayMessage
         );
         stateWaku?.libp2p.peerStore.removeListener(
           'change:protocols',
@@ -103,7 +108,7 @@ export default function App() {
         );
       };
     }
-  }, [stateWaku, stateMessages]);
+  }, [stateWaku]);
 
   return (
     <div
@@ -114,7 +119,8 @@ export default function App() {
         <ThemeProvider theme={themes}>
           <Room
             nick={nick}
-            lines={stateMessages}
+            newMessages={newMessages}
+            archivedMessages={archivedMessages}
             commandHandler={(input: string) => {
               const { command, response } = handleCommand(
                 input,
@@ -122,9 +128,9 @@ export default function App() {
                 setNick
               );
               const commandMessages = response.map((msg) => {
-                return new ChatMessage(new Date(), command, msg);
+                return new ChatMessage(new Date(), new Date(), command, msg);
               });
-              copyAppendReplace(commandMessages, stateMessages, setMessages);
+              setNewMessages(commandMessages);
             }}
           />
         </ThemeProvider>
@@ -162,37 +168,7 @@ function decodeWakuMessage(data: Uint8Array): null | ChatMessage {
   if (!wakuMsg.payload) {
     return null;
   }
-  return ChatMessage.decode(wakuMsg.payload);
+  return ChatMessage.fromWakuChatMessage(
-}
+    WakuChatMessage.decode(wakuMsg.payload)
-
-function copyAppendReplace<T>(
-  newValues: Array<T>,
-  currentValues: Array<T>,
-  setter: (val: Array<T>) => void
-) {
-  const copy = currentValues.slice();
-  setter(copy.concat(newValues));
-}
-
-function copyMergeUniqueReplace(
-  newValues: ChatMessage[],
-  currentValues: ChatMessage[],
-  setter: (val: ChatMessage[]) => void
-) {
-  const copy = currentValues.slice();
-  newValues.forEach((msg) => {
-    if (!copy.find(isEqual.bind({}, msg))) {
-      copy.push(msg);
-    }
-  });
-  copy.sort((a, b) => a.timestamp.valueOf() - b.timestamp.valueOf());
-  setter(copy);
-}
-
-function isEqual(lhs: ChatMessage, rhs: ChatMessage): boolean {
-  return (
-    lhs.nick === rhs.nick &&
-    lhs.message === rhs.message &&
-    lhs.timestamp.toString() === rhs.timestamp.toString()
   );
 }

web-chat/src/ChatList.tsx

@@ -1,5 +1,5 @@
-import { useEffect, useRef } from 'react';
+import { useEffect, useRef, useState } from 'react';
-import { ChatMessage } from 'waku/chat_message';
+import { ChatMessage } from './ChatMessage';
 import {
   Message,
   MessageText,
@@ -8,19 +8,45 @@ import {
 } from '@livechat/ui-kit';
 
 interface Props {
-  messages: ChatMessage[];
+  archivedMessages: ChatMessage[];
+  newMessages: ChatMessage[];
 }
 
 export default function ChatList(props: Props) {
-  const messages = props.messages;
+  const [messages, setMessages] = useState<ChatMessage[]>([]);
+  let updatedMessages;
 
-  const messagesGroupedBySender = groupMessagesBySender(props.messages).map(
+  if (IsThereNewMessages(props.newMessages, messages)) {
+    updatedMessages = messages.slice().concat(props.newMessages);
+    if (IsThereNewMessages(props.archivedMessages, updatedMessages)) {
+      updatedMessages = copyMergeUniqueReplace(
+        props.archivedMessages,
+        updatedMessages
+      );
+    }
+  } else {
+    if (IsThereNewMessages(props.archivedMessages, messages)) {
+      updatedMessages = copyMergeUniqueReplace(
+        props.archivedMessages,
+        messages
+      );
+    }
+  }
+
+  if (updatedMessages) {
+    setMessages(updatedMessages);
+  }
+
+  const messagesGroupedBySender = groupMessagesBySender(messages).map(
     (currentMessageGroup) => (
       <MessageGroup onlyFirstWithMeta>
         {currentMessageGroup.map((currentMessage) => (
           <Message
-            // We assume that the same user is not sending two messages in the same second
+            key={
-            key={currentMessage.timestamp.toString() + currentMessage.nick}
+              currentMessage.receivedTimestampMs.valueOf() +
+              currentMessage.nick +
+              currentMessage.message
+            }
             authorName={currentMessage.nick}
             date={formatDisplayDate(currentMessage)}
           >
@@ -34,7 +60,7 @@ export default function ChatList(props: Props) {
   return (
     <MessageList active containScrollInSubtree>
       {messagesGroupedBySender}
-      <AlwaysScrollToBottom messages={messages} />
+      <AlwaysScrollToBottom newMessages={props.newMessages} />
     </MessageList>
   );
 }
@@ -58,7 +84,7 @@ function groupMessagesBySender(messageArray: ChatMessage[]): ChatMessage[][] {
 }
 
 function formatDisplayDate(message: ChatMessage): string {
-  return message.timestamp.toLocaleString([], {
+  return message.sentTimestamp.toLocaleString([], {
     month: 'short',
     day: 'numeric',
     hour: 'numeric',
@@ -67,14 +93,48 @@ function formatDisplayDate(message: ChatMessage): string {
   });
 }
 
-const AlwaysScrollToBottom = (props: Props) => {
+const AlwaysScrollToBottom = (props: { newMessages: ChatMessage[] }) => {
   const elementRef = useRef<HTMLDivElement>();
 
   useEffect(() => {
     // @ts-ignore
     elementRef.current.scrollIntoView();
-  }, [props.messages]);
+  }, [props.newMessages]);
 
   // @ts-ignore
   return <div ref={elementRef} />;
 };
+
+function IsThereNewMessages(
+  newValues: ChatMessage[],
+  currentValues: ChatMessage[]
+): boolean {
+  if (newValues.length === 0) return false;
+  if (currentValues.length === 0) return true;
+
+  return !newValues.find((newMsg) =>
+    currentValues.find(isEqual.bind({}, newMsg))
+  );
+}
+
+function copyMergeUniqueReplace(
+  newValues: ChatMessage[],
+  currentValues: ChatMessage[]
+) {
+  const copy = currentValues.slice();
+  newValues.forEach((msg) => {
+    if (!copy.find(isEqual.bind({}, msg))) {
+      copy.push(msg);
+    }
+  });
+  copy.sort((a, b) => a.sentTimestamp.valueOf() - b.sentTimestamp.valueOf());
+  return copy;
+}
+
+function isEqual(lhs: ChatMessage, rhs: ChatMessage): boolean {
+  return (
+    lhs.nick === rhs.nick &&
+    lhs.message === rhs.message &&
+    lhs.sentTimestamp.toString() === rhs.sentTimestamp.toString()
+  );
+}

web-chat/src/ChatMessage.ts

@@ -0,0 +1,19 @@
+import { ChatMessage as WakuChatMessage } from 'waku/chat_message';
+
+export class ChatMessage {
+  constructor(
+    public receivedTimestampMs: Date,
+    public sentTimestamp: Date,
+    public nick: string,
+    public message: string
+  ) {}
+
+  static fromWakuChatMessage(wakuChatMessage: WakuChatMessage): ChatMessage {
+    return new ChatMessage(
+      new Date(),
+      wakuChatMessage.timestamp,
+      wakuChatMessage.nick,
+      wakuChatMessage.message
+    );
+  }
+}

web-chat/src/MessageInput.tsx

@@ -10,8 +10,7 @@ import {
 } from '@livechat/ui-kit';
 
 interface Props {
-  messageHandler: (msg: string) => void;
+  sendMessage: ((msg: string) => Promise<void>) | undefined;
-  sendMessage: (() => Promise<void>) | undefined;
 }
 
 export default function MessageInput(props: Props) {
@@ -20,14 +19,13 @@ export default function MessageInput(props: Props) {
 
   const sendMessage = async () => {
     if (props.sendMessage) {
-      await props.sendMessage();
+      await props.sendMessage(inputText);
       setInputText('');
     }
   };
 
   const messageHandler = (event: ChangeEvent<HTMLInputElement>) => {
     setInputText(event.target.value);
-    props.messageHandler(event.target.value);
   };
 
   const keyPressHandler = async (event: KeyboardEvent<HTMLInputElement>) => {

web-chat/src/Room.tsx

@@ -1,5 +1,5 @@
-import { useState } from 'react';
+import { ChatMessage } from './ChatMessage';
-import { ChatMessage } from 'waku/chat_message';
+import { ChatMessage as WakuChatMessage } from 'waku/chat_message';
 import { WakuMessage } from 'waku/waku_message';
 import { ChatContentTopic } from './App';
 import ChatList from './ChatList';
@@ -8,13 +8,13 @@ import { useWaku } from './WakuContext';
 import { TitleBar } from '@livechat/ui-kit';
 
 interface Props {
-  lines: ChatMessage[];
+  newMessages: ChatMessage[];
+  archivedMessages: ChatMessage[];
   commandHandler: (cmd: string) => void;
   nick: string;
 }
 
 export default function Room(props: Props) {
-  let [messageToSend, setMessageToSend] = useState<string>('');
   const { waku } = useWaku();
 
   return (
@@ -23,12 +23,14 @@ export default function Room(props: Props) {
       style={{ height: '98vh', display: 'flex', flexDirection: 'column' }}
     >
       <TitleBar title="Waku v2 chat app" />
-      <ChatList messages={props.lines} />
+      <ChatList
+        newMessages={props.newMessages}
+        archivedMessages={props.archivedMessages}
+      />
       <MessageInput
-        messageHandler={setMessageToSend}
         sendMessage={
           waku
-            ? async () => {
+            ? async (messageToSend) => {
                 return handleMessage(
                   messageToSend,
                   props.nick,
@@ -52,7 +54,7 @@ async function handleMessage(
   if (message.startsWith('/')) {
     commandHandler(message);
   } else {
-    const chatMessage = new ChatMessage(new Date(), nick, message);
+    const chatMessage = new WakuChatMessage(new Date(), nick, message);
     const wakuMsg = WakuMessage.fromBytes(
       chatMessage.encode(),
       ChatContentTopic

web-chat/src/command.ts

@@ -78,6 +78,32 @@ function peers(waku: Waku | undefined): string[] {
   return response;
 }
 
+function connections(waku: Waku | undefined): string[] {
+  if (!waku) {
+    return ['Waku node is starting'];
+  }
+  let response: string[] = [];
+  waku.libp2p.connections.forEach(
+    (
+      connections: import('libp2p-interfaces/src/connection/connection')[],
+      peerId
+    ) => {
+      response.push(peerId + ':');
+      let strConnections = '  connections: [';
+      connections.forEach((connection) => {
+        strConnections += JSON.stringify(connection.stat);
+        strConnections += '; ' + JSON.stringify(connection.streams);
+      });
+      strConnections += ']';
+      response.push(strConnections);
+    }
+  );
+  if (response.length === 0) {
+    response.push('Not connected to any peer.');
+  }
+  return response;
+}
+
 export default function handleCommand(
   input: string,
   waku: Waku | undefined,
@@ -102,6 +128,9 @@ export default function handleCommand(
     case '/peers':
       peers(waku).map((str) => response.push(str));
       break;
+    case '/connections':
+      connections(waku).map((str) => response.push(str));
+      break;
     default:
       response.push(`Unknown Command '${command}'`);
   }