waku-org
/
js-waku
mirror of https://github.com/waku-org/js-waku.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: supress websocket warning in tests (#1797)

This commit is contained in:
Sasha 2024-01-17 15:37:09 +01:00 committed by GitHub
parent 00bd51a42e
commit 7a8ef875dd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/sdk/src/create.ts
View File

@ -212,8 +212,7 @@ export async function defaultLibp2p(
options?: Partial<CreateLibp2pOptions>, options?: Partial<CreateLibp2pOptions>,
userAgent?: string userAgent?: string
): Promise<Libp2p> { ): Promise<Libp2p> {
// Log the info log unless we are running tests or the user has disabled it if (!options?.hideWebSocketInfo && process.env.NODE_ENV !== "test") {
if (!options?.hideWebSocketInfo || process.env.NODE_ENV !== "test") {
/* eslint-disable no-console */ /* eslint-disable no-console */
console.info( console.info(
"%cIgnore WebSocket connection failures", "%cIgnore WebSocket connection failures",

19
packages/tests/tests/create.optional.spec.ts
View File

@ -14,18 +14,27 @@ describe("Create node", () => {
afterEach(async () => { afterEach(async () => {
consoleInfoSpy.restore(); consoleInfoSpy.restore();
sinon.restore();
await tearDownNodes([], waku); await tearDownNodes([], waku);
}); });
it("should log info about WebSocket failures to console when hideWebSocketInfo disabled", async () => { it("should log info about WebSocket failures to console when hideWebSocketInfo disabled and NODE_ENV is not test", async () => {
sinon.stub(process.env, "NODE_ENV").value("undefined");
waku = await createLightNode(); waku = await createLightNode();
expect(consoleInfoSpy.callCount).to.be.equal(2); expect(consoleInfoSpy.callCount).to.be.equal(2);
}); });
it("should not log info about WebSocket failures to console when hideWebSocketInfo enabled", async () => { [
waku = await createLightNode({ ["test", false],
libp2p: { hideWebSocketInfo: true } ["test", true],
[undefined, true]
].map(([env, hideWebSocketInfo]) => {
it(`should not log info about WebSocket failures to console when NODE_ENV=${env} and hideWebSocketInfo=${hideWebSocketInfo}`, async () => {
sinon.stub(process.env, "NODE_ENV").value(env);
waku = await createLightNode({
libp2p: { hideWebSocketInfo: !!hideWebSocketInfo }
});
expect(consoleInfoSpy.callCount).to.be.equal(0);
}); });
expect(consoleInfoSpy.callCount).to.be.equal(0);
}); });
}); });