waku-org/js-waku
1
0
Fork 0
mirror of https://github.com/waku-org/js-waku.git synced 2025-02-04 08:34:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge #893

Browse Source 
893: fix: do not throw on lack of response r=fryorcraken a=fryorcraken

Expected proto3 behaviour, just no message returned.

Co-authored-by: fryorcraken.eth <git@fryorcraken.xyz>
This commit is contained in:
status-bors-ng[bot] 2022-08-17 16:19:20 +00:00 committed by GitHub
commit 67811662d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/waku_store/index.ts
View File

@ -216,7 +216,7 @@ export class WakuStore {
const reply = historyRpcQuery.decode(bytes);
if (!reply.response) {
throw "History response misses response field";
dbg("No message returned from store: `response` field missing");
}
const response = reply.response as protoV2Beta4.HistoryResponse;
@ -227,7 +227,7 @@ export class WakuStore {
if (!response.messages || !response.messages.length) {
// No messages left (or stored)
console.log("No messages present in HistoryRPC response");
dbg("No message returned from store: `messages` array empty");
return messages;
}
@ -265,8 +265,8 @@ export class WakuStore {
cursor = response.pagingInfo?.cursor;
if (cursor === undefined) {
// If the server does not return cursor then there is an issue,
// Need to abort or we end up in an infinite loop
console.log("No cursor returned by peer.");
// Need to abort, or we end up in an infinite loop
dbg("Store response does not contain a cursor, stopping pagination");
return messages;
}
}