waku-org
/
go-multiaddr
mirror of https://github.com/waku-org/go-multiaddr.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix CodeToVarint []byte size 

We were missing a logarithm... CodeToVarint would previously allocate
more bytes than necessary (exponentially) for the varint slice. This bug
was silent but deserves to be fixed nonetheless.
This commit is contained in:
mwnx 2018-06-16 18:06:48 +02:00
parent ae494b7f0c
commit 7bf24dca81
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
protocols.go
View File

@ -4,6 +4,7 @@ import (
"encoding/binary" "encoding/binary"
"fmt" "fmt"
"strings" "strings"
"math/bits"
) )
// Protocol is a Multiaddr protocol description structure. // Protocol is a Multiaddr protocol description structure.
@ -117,7 +118,7 @@ func ProtocolsWithString(s string) ([]Protocol, error) {
// CodeToVarint converts an integer to a varint-encoded []byte // CodeToVarint converts an integer to a varint-encoded []byte
func CodeToVarint(num int) []byte { func CodeToVarint(num int) []byte {
buf := make([]byte, (num/7)+1) // varint package is uint64 buf := make([]byte, bits.Len(uint(num))/7 + 1)
n := binary.PutUvarint(buf, uint64(num)) n := binary.PutUvarint(buf, uint64(num))
return buf[:n] return buf[:n]
} }