From 405ec84a77cdf1cfd1dfa6c89ea2097ee65b64da Mon Sep 17 00:00:00 2001 From: Sanaz Taheri Boshrooyeh <35961250+staheri14@users.noreply.github.com> Date: Thu, 29 Apr 2021 10:24:52 -0700 Subject: [PATCH] Add pubsub topic to store json rpc api (#359) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * adds pubsub topic field * integrates pubsub topic in the examples * Update content/docs/rfcs/16/README.md Co-authored-by: Oskar Thorén * fixes a spacing issue Co-authored-by: Oskar Thorén --- content/docs/rfcs/16/README.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/content/docs/rfcs/16/README.md b/content/docs/rfcs/16/README.md index 0c9546c1..bffe9aa3 100644 --- a/content/docs/rfcs/16/README.md +++ b/content/docs/rfcs/16/README.md @@ -218,6 +218,7 @@ The `get_waku_v2_store_v1_messages` method retrieves historical messages on spec | Field | Type | Inclusion | Description | | ----: | :---: | :---: |----------- | +| `pubsubTopic` | `String` | mandatory | The pubsub topic on which a [`WakuMessage`](#WakuMessage) is published | | `contentFilters` | `Array`[[`ContentFilter`](#contentfilter)] | mandatory | Array of content filters to query for historical messages | | `pagingOptions` | [`PagingOptions`](#PagingOptions) | optional | Pagination information | @@ -451,7 +452,7 @@ This method is part of the `store` API and the specific resources to retrieve ar #### Request -```curl -d '{"jsonrpc":"2.0","id":"id","method":"get_waku_v2_store_v1_messages", "params":[["/waku/2/default-content/proto"]]}' --header "Content-Type: application/json" http://localhost:8545``` +```curl -d '{"jsonrpc":"2.0","id":"id","method":"get_waku_v2_store_v1_messages", "params":["", ["/waku/2/default-content/proto"]]}' --header "Content-Type: application/json" http://localhost:8545``` ```jsonrpc { @@ -459,6 +460,7 @@ This method is part of the `store` API and the specific resources to retrieve ar "id": "id", "method": "get_waku_v2_store_v1_messages", "params": [ + "", [ {"contentTopic": "/waku/2/default-content/proto"} ] @@ -508,7 +510,7 @@ This method is part of the `store` API and the specific resources to retrieve ar #### Request -```curl -d '{"jsonrpc":"2.0","id":"id","method":"get_waku_v2_store_v1_messages", "params":[["/waku/2/default-content/proto"],{"pageSize":2,"forward":false}]}' --header "Content-Type: application/json" http://localhost:8545``` +```curl -d '{"jsonrpc":"2.0","id":"id","method":"get_waku_v2_store_v1_messages", "params":[ "", ["/waku/2/default-content/proto"],{"pageSize":2,"forward":false}]}' --header "Content-Type: application/json" http://localhost:8545``` ```jsonrpc { @@ -516,6 +518,7 @@ This method is part of the `store` API and the specific resources to retrieve ar "id": "id", "method": "get_waku_v2_store_v1_messages", "params": [ + "", [ {"contentTopic": "/waku/2/default-content/proto"} ], @@ -569,7 +572,7 @@ This method is part of the `store` API and the specific resources to retrieve ar #### Request -```curl -d '{"jsonrpc":"2.0","id":"id","method":"get_waku_v2_store_v1_messages", "params":[["/waku/2/default-content/proto"],{"pageSize":2,"cursor":{"digest":"abcdef","receivedTime":1605887187.00},"forward":false}]}' --header "Content-Type: application/json" http://localhost:8545``` +```curl -d '{"jsonrpc":"2.0","id":"id","method":"get_waku_v2_store_v1_messages", "params":[ "", ["/waku/2/default-content/proto"],{"pageSize":2,"cursor":{"digest":"abcdef","receivedTime":1605887187.00},"forward":false}]}' --header "Content-Type: application/json" http://localhost:8545``` ```jsonrpc { @@ -577,6 +580,7 @@ This method is part of the `store` API and the specific resources to retrieve ar "id": "id", "method": "get_waku_v2_store_v1_messages", "params": [ + "", [ {"contentTopic": "/waku/2/default-content/proto"} ],