From 3c3bcc833a4d59e9433ceeadcdebb4a2de5e53ff Mon Sep 17 00:00:00 2001 From: Dean Eigenmann <7621705+decanus@users.noreply.github.com> Date: Thu, 24 Sep 2020 04:12:55 +0200 Subject: [PATCH] fix/filter-sync-with-code (#188) * Update waku-filter.md * Update wordlist.txt * Update waku-filter.md * Update waku-filter.md --- specs/waku/v2/waku-filter.md | 16 +++++++++++++++- wordlist.txt | 1 + 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/specs/waku/v2/waku-filter.md b/specs/waku/v2/waku-filter.md index 6e995207..5e6b14d3 100644 --- a/specs/waku/v2/waku-filter.md +++ b/specs/waku/v2/waku-filter.md @@ -15,7 +15,7 @@ Filter spec. ### Content filtering -**Protocol identifier***: `/vac/waku/filter/2.0.0-alpha5` +**Protocol identifier***: `/vac/waku/filter/2.0.0-alpha6` Content filtering is a way to do [message-based filtering](https://en.wikipedia.org/wiki/Publish%E2%80%93subscribe_pattern#Message_filtering). @@ -66,8 +66,22 @@ message FilterRequest { message MessagePush { repeated WakuMessage messages = 1; } + +message FilterRPC { + string request_id = 1; + FilterRequest request = 2; + MessagePush push = 3; +} ``` +##### FilterRPC + +A node MUST send all Filter messages (`FilterRequest`, `MessagePush`) wrapped inside a +`FilterRPC` this allows the node handler to determine how to handle a message as the Waku +Filter protocol is not a request response based protocol but instead a push based system. + +The `request_id` MUST be a uniquely generated string. + ##### FilterRequest TODO Specify mechanism for telling it won't honor (normal-no service-spam case) diff --git a/wordlist.txt b/wordlist.txt index 86494162..11509008 100644 --- a/wordlist.txt +++ b/wordlist.txt @@ -54,6 +54,7 @@ FilterRequest filterRequest FilterResponse filterResponse +FilterRPC FloodSub GCM github