vacp2p/nim-libp2p
1
0
Fork 0
mirror of https://github.com/vacp2p/nim-libp2p.git synced 2025-03-01 16:40:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(pubsub): do not raise exceptions on publish (#1244)

Browse Source
This commit is contained in:
richΛrd 2025-02-06 21:30:21 -04:00 committed by GitHub
parent a4f0a638e7
commit 78a4344054
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libp2p/protocols/pubsub/floodsub.nim
View File

@ -194,7 +194,7 @@ method init*(f: FloodSub) =
method publish*( method publish*(
f: FloodSub, topic: string, data: seq[byte] f: FloodSub, topic: string, data: seq[byte]
): Future[int] {.async: (raises: [LPError]).} = ): Future[int] {.async: (raises: []).} =
# base returns always 0 # base returns always 0
discard await procCall PubSub(f).publish(topic, data) discard await procCall PubSub(f).publish(topic, data)

2
libp2p/protocols/pubsub/gossipsub.nim
View File

@ -705,7 +705,7 @@ method onTopicSubscription*(g: GossipSub, topic: string, subscribed: bool) =
method publish*( method publish*(
g: GossipSub, topic: string, data: seq[byte] g: GossipSub, topic: string, data: seq[byte]
): Future[int] {.async: (raises: [LPError]).} = ): Future[int] {.async: (raises: []).} =
logScope: logScope:
topic topic

2
libp2p/protocols/pubsub/pubsub.nim
View File

@ -555,7 +555,7 @@ proc subscribe*(p: PubSub, topic: string, handler: TopicHandler) {.public.} =
method publish*( method publish*(
p: PubSub, topic: string, data: seq[byte] p: PubSub, topic: string, data: seq[byte]
): Future[int] {.base, async: (raises: [LPError]), public.} = ): Future[int] {.base, async: (raises: []), public.} =
## publish to a ``topic`` ## publish to a ``topic``
## ##
## The return value is the number of neighbours that we attempted to send the ## The return value is the number of neighbours that we attempted to send the

8
libp2p/protocols/pubsub/rpc/message.nim
View File

@ -65,7 +65,10 @@ proc init*(
topic: string, topic: string,
seqno: Option[uint64], seqno: Option[uint64],
sign: bool = true, sign: bool = true,
): Message {.gcsafe, raises: [LPError].} = ): Message {.gcsafe, raises: [].} =
if sign and peer.isNone():
doAssert(false, "Cannot sign message without peer info")
var msg = Message(data: data, topic: topic) var msg = Message(data: data, topic: topic)
# order matters, we want to include seqno in the signature # order matters, we want to include seqno in the signature
@ -81,9 +84,6 @@ proc init*(
.expect("Invalid private key!") .expect("Invalid private key!")
.getBytes() .getBytes()
.expect("Couldn't get public key bytes!") .expect("Couldn't get public key bytes!")
else:
if sign:
raise (ref LPError)(msg: "Cannot sign message without peer info")
msg msg