Fix/misc (#116)

* only check for payload size

* only subscribe if connection succeeded

* fix failing test

* check that the strem is active before openning

* msg type should not be > than 0x7

* fix tests

* check max against enum val

libp2p/muxers/mplex/coder.nim

@@ -26,6 +26,11 @@ type
     msgType: MessageType
     data: seq[byte]
 
+  InvalidMplexMsgType = object of CatchableError
+
+proc newInvalidMplexMsgType*(): ref InvalidMplexMsgType =
+  newException(InvalidMplexMsgType, "invalid message type")
+
 proc readMplexVarint(conn: Connection): Future[uint64] {.async, gcsafe.} =
   var
     varint: uint
@@ -41,27 +46,31 @@ proc readMplexVarint(conn: Connection): Future[uint64] {.async, gcsafe.} =
         break
     if res != VarintStatus.Success:
       raise newInvalidVarintException()
-    if varint.int > DefaultReadSize:
-      raise newInvalidVarintSizeException()
     return varint
   except LPStreamIncompleteError as exc:
     trace "unable to read varint", exc = exc.msg
     raise exc
 
 proc readMsg*(conn: Connection): Future[Msg] {.async, gcsafe.} =
-  let headerVarint = await conn.readMplexVarint()
+  let header = await conn.readMplexVarint()
-  trace "read header varint", varint = headerVarint
+  trace "read header varint", varint = header
 
   let dataLenVarint = await conn.readMplexVarint()
   trace "read data len varint", varint = dataLenVarint
 
+  if dataLenVarint.int > DefaultReadSize:
+    raise newInvalidVarintSizeException()
+
   var data: seq[byte] = newSeq[byte](dataLenVarint.int)
   if dataLenVarint.int > 0:
     await conn.readExactly(addr data[0], dataLenVarint.int)
     trace "read data", data = data.len
 
-  let header = headerVarint
+  let msgType = header and 0x7
-  result = (uint64(header shr 3), MessageType(header and 0x7), data)
+  if msgType.int > ord(MessageType.ResetOut):
+    raise newInvalidMplexMsgType()
+
+  result = (uint64(header shr 3), MessageType(msgType), data)
 
 proc writeMsg*(conn: Connection,
                id: uint64,

libp2p/muxers/mplex/lpchannel.nim

@@ -158,11 +158,12 @@ method readUntil*(s: LPChannel,
   await s.tryCleanup()
 
 template writePrefix: untyped =
-  if s.isLazy and not s.isOpen:
-    await s.open()
   if s.closedLocal or s.isReset:
     raise newLPStreamEOFError()
 
+  if s.isLazy and not s.isOpen:
+    await s.open()
+
 method write*(s: LPChannel, pbytes: pointer, nbytes: int) {.async.} =
   writePrefix()
   await procCall write(BufferStream(s), pbytes, nbytes)

libp2p/muxers/mplex/mplex.nim

@@ -11,7 +11,7 @@
 ## Timeouts and message limits are still missing
 ## they need to be added ASAP
 
-import tables, sequtils, options
+import tables, sequtils
 import chronos, chronicles
 import ../muxer,
        ../../connection,

libp2p/switch.nim

@@ -237,7 +237,9 @@ proc internalConnect(s: Switch,
   else:
     trace "Reusing existing connection"
 
-  await s.subscribeToPeer(peer)
+  if not isNil(conn):
+    await s.subscribeToPeer(peer)
+
   result = conn
 
 proc connect*(s: Switch, peer: PeerInfo) {.async.} =
@@ -323,6 +325,7 @@ proc subscribeToPeer(s: Switch, peerInfo: PeerInfo) {.async, gcsafe.} =
       await s.pubSub.get().subscribeToPeer(conn)
     except CatchableError as exc:
       warn "unable to initiate pubsub", exc = exc.msg
+    finally:
       s.dialedPubSubPeers.excl(peerInfo.id)
 
 proc subscribe*(s: Switch, topic: string,

tests/testinterop.nim

@@ -390,6 +390,7 @@ suite "Interop":
         inc(count2)
 
       result = 10 == (await wait(testFuture, 10.secs))
+      await stream.close()
       await nativeNode.stop()
       await allFutures(awaiters)
       await daemonNode.close()