vacp2p
/
nim-libp2p
mirror of https://github.com/vacp2p/nim-libp2p.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix validation according to specification (#410)

This commit is contained in:
Giovanni Petrantoni 2020-10-21 12:25:42 +09:00 committed by GitHub
parent 5c19668b2d
commit 27b9bf436e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libp2p/protocols/pubsub/floodsub.nim
View File

@ -85,9 +85,13 @@ method rpcHandler*(f: FloodSub,
# g.anonymize needs no evaluation when receiving messages # g.anonymize needs no evaluation when receiving messages
# as we have a "lax" policy and allow signed messages # as we have a "lax" policy and allow signed messages
if (await f.validate(msg)) == ValidationResult.Reject: let validation = await f.validate(msg)
trace "Dropping message due to failed validation", msgId, peer case validation
of ValidationResult.Reject, ValidationResult.Ignore:
debug "Dropping message due to ignored validation", msgId, peer
continue continue
of ValidationResult.Accept:
discard
var toSendPeers = initHashSet[PubSubPeer]() var toSendPeers = initHashSet[PubSubPeer]()
for t in msg.topicIDs: # for every topic in the message for t in msg.topicIDs: # for every topic in the message

9
libp2p/protocols/pubsub/gossipsub.nim
View File

@ -1062,10 +1062,17 @@ method rpcHandler*(g: GossipSub,
# g.anonymize needs no evaluation when receiving messages # g.anonymize needs no evaluation when receiving messages
# as we have a "lax" policy and allow signed messages # as we have a "lax" policy and allow signed messages
if (await g.validate(msg)) == ValidationResult.Reject: let validation = await g.validate(msg)
case validation
of ValidationResult.Reject:
debug "Dropping message due to failed validation", msgId, peer debug "Dropping message due to failed validation", msgId, peer
g.punishPeer(peer, msg) g.punishPeer(peer, msg)
continue continue
of ValidationResult.Ignore:
debug "Dropping message due to ignored validation", msgId, peer
continue
of ValidationResult.Accept:
discard
var toSendPeers = initHashSet[PubSubPeer]() var toSendPeers = initHashSet[PubSubPeer]()
for t in msg.topicIDs: # for every topic in the message for t in msg.topicIDs: # for every topic in the message

8
libp2p/protocols/pubsub/gossipsub10.nim
View File

@ -464,9 +464,13 @@ method rpcHandler*(g: GossipSub,
# g.anonymize needs no evaluation when receiving messages # g.anonymize needs no evaluation when receiving messages
# as we have a "lax" policy and allow signed messages # as we have a "lax" policy and allow signed messages
if (await g.validate(msg)) == ValidationResult.Reject: let validation = await g.validate(msg)
trace "Dropping message due to failed validation", msgId, peer case validation
of ValidationResult.Reject, ValidationResult.Ignore:
debug "Dropping message due to ignored validation", msgId, peer
continue continue
of ValidationResult.Accept:
discard
var toSendPeers = initHashSet[PubSubPeer]() var toSendPeers = initHashSet[PubSubPeer]()
for t in msg.topicIDs: # for every topic in the message for t in msg.topicIDs: # for every topic in the message