170685f9c6
gossipsub fixes ( #276 )
...
* graft up to D peers
* fix logging so it's clear who is grafting/pruning who
* clear fanout when grafting
2020-07-16 21:26:57 +02:00
c76152f2c1
Simplify send ( #271 )
...
* PubSubPeer.send single message
* gossipsub: simplify send further
2020-07-16 12:06:57 +02:00
f35b8999b3
some light cleanup for pub/gossip sub ( #273 )
...
* move peer table out to its own file
* move peer table
* cleanup `==` and add one to peerinfo
* add peertable
* missed equality check
2020-07-15 13:18:55 -06:00
b832668768
Minprotobuf refactoring 2 ( #269 )
...
* Protobuf refactoring stage II.
* Remove NoError.
* Change trace level for invalid message.
2020-07-15 10:25:39 +02:00
9eb5828a42
Fix #266 . ( #270 )
...
* Fix security issue #266 .
* Add more tests.
* Fix PeerID tests should not use RSA-512 keys.
* Fix crypto tests to use vectors with 2048+ bits.
* Disable 4096bit RSA key generation for CI debug runs.
2020-07-15 10:24:04 +02:00
d7bab37119
Fix gossip messages seqno according to spec ( #253 )
...
* Fix gossip messages seqno according to spec
* Add peers back to gossipsub table, slow down heartbeat
* Revert "Add peers back to gossipsub table, slow down heartbeat"
This reverts commit 01e2e62172a7793bb17f0eb8314e2faeb2682173.
* make seqno a threadvar, remove from peerinfo
* seqno refactor, into pubsub
2020-07-14 21:51:33 -06:00
b8b0a2b4bc
CI: build binaries with TRACE & JSON logs ( #268 )
...
Also: remove unused imports.
2020-07-14 02:02:16 +02:00
c6c2d99907
one more log fix
2020-07-13 20:19:20 +02:00
76853f064a
json logging again
2020-07-13 19:59:49 +02:00
6620b7a00b
more comment fixes
2020-07-13 19:30:18 +02:00
0d4c74b33a
comment log that can't be json-serialized
2020-07-13 18:36:49 +02:00
061c54d3c6
logging fixes
2020-07-13 17:26:05 +02:00
87e58c1c8d
metrics: one more pubsub peers fix
2020-07-13 16:16:46 +02:00
c7895ccc52
metrics: fix pubsub_peers add metric
2020-07-13 16:15:27 +02:00
fcda0f6ce1
PubSubPeer tables refactor ( #263 )
...
* refactor peer tables
* tests fixing
* override PubSubPeer equality
* fix pubsubpeer comparison
2020-07-13 15:32:38 +02:00
efb952f18b
[WIP] Minprotobuf refactoring ( #259 )
...
* Minprotobuf initial commit
* Fix noise.
* Add signed integers support.
Add checks for field number value.
Remove some casts.
* Fix compile errors.
* Fix comments and constants.
2020-07-13 14:43:07 +02:00
181cf73ca7
Drain buffer ( #264 )
...
* drain lpchannel on reset
* move drainBuffer to bufferstream
2020-07-12 18:37:10 +02:00
bec9a0658f
Cleanup rpc handler ( #261 )
...
* more cleanup
* fix tests
* merging master
* remove `withLock` as it conflicts with stdlib
* wip
* more fanout ttl
Co-authored-by: Giovanni Petrantoni <giovanni@fragcolor.xyz>
2020-07-09 17:54:16 -06:00
4c815d75e7
More gossip cleanup ( #257 )
...
* more cleanup
* correct pubsub peer count
* close the stream first
* handle cancelation
* fix tests
* fix fanout ttl
* merging master
* remove `withLock` as it conflicts with stdlib
* fix trace build
Co-authored-by: Giovanni Petrantoni <giovanni@fragcolor.xyz>
2020-07-09 14:21:47 -06:00
c720e042fc
clean up mesh handling logic ( #260 )
...
* gossipsub is a function of subscription messages only
* graft/prune work with mesh, get filled up from gossipsub
* fix race conditions with await
* fix exception unsafety when grafting/pruning
* fix allowing up to DHi peers in mesh on incoming graft
* fix metrics in several places
2020-07-09 11:16:46 -06:00
9a3684c221
init from concrete key type ( #252 )
2020-07-09 02:59:09 -06:00
45c089ff0d
noise updates ( #255 )
...
* clear secrets explicitly
* simplify keygen
* avoid some trivial memory allocations
* fix little endian encoding of nonce
2020-07-09 02:53:19 -06:00
4e12d0d97a
nil check peer before disconnect
2020-07-09 17:20:45 +09:00
f9e0a1f069
CI fix handleDisconnect (pubsub)
2020-07-09 13:56:59 +09:00
9b8b159abb
Remove other spurious getStacktrace in pubsub traces
2020-07-09 13:19:34 +09:00
4bcb567d47
fix gossip tests
2020-07-09 12:34:36 +09:00
4698f41a91
Remove stacktrace logging from pubsub connect
2020-07-09 12:23:03 +09:00
fec507e755
Add peers back to gossipsub table, slow down heartbeat ( #256 )
...
* Add peers back to gossipsub table, slow down heartbeat
* exclude on unsub from mesh and fanout
2020-07-08 11:06:26 -06:00
a52763cc6d
fix publishing ( #250 )
...
* use var semantics to optimize table access
* wip... lvalues don't work properly sadly...
* big publish refactor, replenish and balance
* fix internal tests
* use g.peers for fanout (todo: don't include flood peers)
* exclude non gossip from fanout
* internal test fixes
* fix flood tests
* fix test's trypublish
* test interop fixes
* make sure to not remove peers from gossip table
* restore old replenishFanout
* cleanups
* Cleanup resources (#246 )
* consolidate reading in lpstream
* remove debug echo
* tune log level
* add channel cleanup and cancelation handling
* cancelation handling
* cancelation handling
* cancelation handling
* cancelation handling
* cleanup and cancelation handling
* cancelation handling
* cancelation
* tests
* rename isConnected to connected
* remove testing trace
* comment out debug stacktraces
* explicit raises
* restore trace vs debug in gossip
* improve fanout replenish behavior further
* cleanup stale peers more eaguerly
* synchronize connection cleanup and small refactor
* close client first and call parent second
* disconnect failed peers on publish
* check for publish result
* fix tests
* fix tests
* always call close
Co-authored-by: Giovanni Petrantoni <giovanni@fragcolor.xyz>
2020-07-07 18:33:05 -06:00
775cab414a
Remove SHA1 from crypto and crypto tests. ( #251 )
...
* Remove SHA1 from crypto and crypto tests.
* Simplify RSA comparison procedure.
Refactor some procedures in crypto.nim.
2020-07-07 15:48:15 +02:00
d522537b19
reuse single RNG instance for all crypto key generation ( #249 )
...
* reuse single RNG instance for all crypto key generation
* use foolproof rng
* initRng -> newRng (because it's ref)
* fix test
* imports/exports, chat fix
* fix rsa
* imports and exports
* work around threadvar issue
* fixup
* mac workaround test
2020-07-07 13:14:11 +02:00
b49c619ca8
export public field types ( #248 )
...
* export public field types
* one more
2020-07-01 09:22:29 +02:00
ec00c7fc50
Peer resultification and defect only ( #245 )
...
* Peer resultification and defect only
* Fixing some tests
* test fixes
* Rename peer into peerid
* better result error message in identify
* further merge fixes
2020-07-01 08:25:09 +02:00
c788a6a3c0
Cleanup resources ( #246 )
...
* consolidate reading in lpstream
* remove debug echo
* tune log level
* add channel cleanup and cancelation handling
* cancelation handling
* cancelation handling
* cancelation handling
* cancelation handling
* cleanup and cancelation handling
* cancelation handling
* cancelation
* tests
* rename isConnected to connected
* remove testing trace
* comment out debug stacktraces
* explicit raises
2020-06-29 09:15:31 -06:00
aa6756dfe0
allow message id provider to be specified ( #243 )
...
* don't send public key in message when not signing (information leak)
* don't run rebalance if there are peers in gossip (see #242 )
* don't crash randomly on bad peer id from remote
2020-06-28 09:56:38 -06:00
902880ef1f
consolidate reading in lpstream ( #241 )
...
* consolidate reading in lpstream
* remove debug echo
* throw if not enough bytes where read
* tune log level
* set eof flag
* test readExactly to fail on not enough bytes
2020-06-27 11:33:34 -06:00
7a95f1844b
Concurrent dials ( #238 )
...
* count published messages
* don't call `switch.dial` in `subscribeToPeer`
* add secureconn constructor
* close in the correct order
* concurent dial lock and track in/out conns better
* make tests pass
* add todo comment
* disconect peers that open too many connections
* wip
* do connection and muxer tracking in one place
* prevent nil pointer in observers
* drop connections when peers is over max
* prevent channel leaks
* don't use closure to handle channel
2020-06-24 09:08:44 -06:00
ee6e545878
multistream select make sure to not report NA ( #235 )
...
* multistream select make sure to not report NA but rather empty string if all fails
Also re-enable tests
* avoid using bad constructs, make multistream.select flow crystal clear
2020-06-22 15:38:48 -06:00
6331b04cb4
secp: requiresInit updates ( #237 )
...
* secp: requiresInit updates
* fix
2020-06-22 19:03:15 +02:00
b99fd88deb
logging fixes
2020-06-21 11:14:19 +02:00
7852c6dd0f
Noise and eth2/nbc fixes ( #226 )
...
* Remove noise padding payload (spec removed it)
* add log scope in secure
* avoid defect array out of range in switch secure when "na"
* improve identify traces
* wip noise fixes
* noise protobuf adjustments (trying)
* add more debugging messages/traces, improve their actual contents
* re-enable ID check in noise
* bump go daemon tag version
* bump go daemon tag version
* enable noise in daemonapi
* interop testing, (both secio and noise will be tested)
* azure cache bump (p2pd)
* CI changes
- Travis: use Go 1.14
- azure-pipelines.yml: big cleanup
- Azure: bump cache keys
- build 64-bit p2pd on 32-bit Windows
- install both Mingw-w64 architectures
* noise logging fixes
* alternate testing between noise and secio
* increase timeout to avoid VM errors in CI (multistream tests)
* refactor heartbeat management in gossipsub
* remove locking within heartbeat
* refactor heartbeat management in gossipsub
* remove locking within heartbeat
Co-authored-by: Ștefan Talpalaru <stefantalpalaru@yahoo.com>
2020-06-20 19:56:55 +09:00
7a1c1c2ea6
fixing some key not found exceptions ( #231 )
2020-06-19 15:19:07 -06:00
5b28e8c488
Cleanup lpstream, Connection and BufferStream ( #228 )
...
* count published messages
* don't call `switch.dial` in `subscribeToPeer`
* don't use delegation in connection
* move connection out to own file
* don't breakout on reset
* make sure to call close on secured conn
* add lpstream tracing
* don't breackdown by conn id
* fix import
* remove unused lable
* reset connection on exception
* add additional metrics for skipped messages
* check for nil in secure.close
2020-06-19 11:29:43 -06:00
719744f46a
Small fixes ( #230 )
...
* count published messages
* don't call `switch.dial` in `subscribeToPeer`
* make sure sending doesn't fail
* add `contains`
* review comment from prev pr
2020-06-19 11:29:25 -06:00
5f75e5adc6
don't use `switch.dial` in `subscribeToPeer` ( #227 )
...
* count published messages
* don't call `switch.dial` in `subscribeToPeer`
2020-06-17 20:12:32 -06:00
fe828d87d8
count published messages ( #224 )
2020-06-16 22:14:02 -06:00
224c2613e3
Remove noise padding payload (spec removed it) ( #222 )
2020-06-16 17:34:02 -06:00
523eed65ce
metrics: use eth2 name for peers metric ( #223 )
2020-06-16 14:43:45 -06:00
0d81acafa8
Fix multistream select trace proto logging
2020-06-16 12:02:47 +09:00
9d9f793b4f
add metrics for sent messages by topic and peer ( #220 )
2020-06-15 17:39:03 -06:00
3c4c10d871
con't crash on nil ptr
2020-06-15 13:37:25 -06:00
7cb6c81159
Don't modify iterables while iterating them ( #219 )
...
* don't modify iterables while iterating
* assert handlers to properly close connections
2020-06-15 12:30:09 -06:00
9cd47fe816
add a logScope to make tracing less ugly ( #218 )
...
* add a logScope to make tracing less ugly
* don't crash on nil pointer
2020-06-15 12:10:41 -06:00
85b56d0b3a
Observedaddr ( #217 )
...
* send correct observerAddr
* run tests with info log level
* set observedaddr for channels
2020-06-12 19:56:17 -06:00
f97e2deec7
Make methods in FloodSub, GossipSub public ( #216 )
...
Similar to https://github.com/status-im/nim-libp2p/pull/193 but doing it for all
methods to avoid this issue in PubSub in the future. Got hit by this behavior
again in rpcHandler and took me a while to figure out.
See https://github.com/oskarth/nim-private-method-skipping-case/ for minimal
repro
2020-06-12 17:54:12 -06:00
ac04ca6e31
make sure keys exist and more metrics ( #215 )
2020-06-11 20:20:58 -06:00
55a294a5c9
better pubsub metrics ( #214 )
2020-06-11 12:09:34 -06:00
6b196ad7b4
remove pubsub peer on disconnect ( #212 )
...
* remove pubsub peer on disconnect
* make sure lock is aquired
* add $
* count upgrades/dials/disconnects
2020-06-11 08:45:59 -06:00
92579435b6
secio then noise ( #213 )
...
* secio then noise
much fewer peers on witti with noise first
* comment
2020-06-11 08:38:47 +02:00
1afec627c2
proper name for topics so that we can filter dynamically using chronicles ( #210 )
...
* proper name for topics so that we can filter dynamically using chronicles
* lowercase
2020-06-10 10:48:01 +02:00
8d9e231a74
grab agentversion/protoversion ( #211 )
2020-06-09 12:42:52 -06:00
35ff99829e
close streams ( #208 )
...
* close streams
* don't warn on missing proto
2020-06-08 17:42:27 -06:00
ee281310c0
move trace log
2020-06-08 10:40:08 -06:00
82b4ed8f44
use declareCounter rather then gauge for certain metrics
2020-06-07 16:41:23 +09:00
a6a2a81711
Start adding some metrics to pubsub ( #192 )
...
* Start adding some metrics to pubsub
In order to visualize it's functionality
Still WIP
* more metrics
* add per topic metrics
* finishup with requested metrics
* add a metrisServer define to start local server
* PR fixes and cleanup
2020-06-07 09:15:21 +02:00
130c64f33a
don't return nil in dial ( #205 )
...
* dont return nil in dial
* don't crash on pubsub send
2020-06-05 18:17:05 -06:00
2aebae56c0
Don't rely on the side-effects from doAssert
2020-06-05 19:12:10 +03:00
828a80ec8f
Make the MultiAddress.init function used in NBC non-failing
2020-06-05 17:51:22 +03:00
5960d42c50
remove casts from ( #203 )
2020-06-02 20:21:11 -06:00
bb8bff2195
add sparse message propagation tests to gossipsub ( #202 )
...
* add sparce tests to gossipsub
* add send hooks
* remove `all`
2020-06-02 17:53:38 -06:00
285884c20c
Close peers ( #201 )
...
* wip
* exceptions and resource cleanup
* correct peerlifetime on disconnect
* emulate defered
* remove comment
2020-06-02 11:32:42 -06:00
c7298f34f4
additional comments
2020-06-02 09:10:27 -06:00
71640da8f2
remove close from read/write methods
2020-06-02 09:10:27 -06:00
1b4876d26d
emulate `defered`
2020-06-02 09:10:27 -06:00
abf659a01a
more consistent dialing proto selecting logic
2020-06-02 09:10:27 -06:00
86e1c8169c
decorate observers hooks with {.raises: [Defect].}
...
move hooks logic out into standalone procs
License: MIT
Signed-off-by: Dmitriy Ryajov <dryajov@gmail.com>
2020-06-02 09:10:27 -06:00
4df151a3a3
typos
2020-06-02 09:10:27 -06:00
27a7f8c948
move EOF flag after local close and comments
2020-06-02 09:10:27 -06:00
815282a5da
remove all()
2020-06-02 09:10:27 -06:00
293b7da295
typo
2020-06-02 09:10:27 -06:00
6e0eb93d4f
remove readloops
2020-06-02 09:10:27 -06:00
abc12d0fb5
move stram close to a better location
2020-06-02 09:10:27 -06:00
daef00fc7b
don't crash schlesi-dev
2020-06-02 09:10:27 -06:00
640c3bdc45
better exception handling and resource cleanup
2020-06-02 09:10:27 -06:00
7ff76d76b6
better exceptions
2020-06-02 09:10:27 -06:00
95774b2b81
better cleanup
2020-06-02 09:10:27 -06:00
9c2f31262e
wip: try handling child stream exceptions
2020-06-02 09:10:27 -06:00
e3f8f53620
initStream method and better exceptions handling
2020-06-02 09:10:27 -06:00
d3b79b002e
better exceptions and don't fail writes
2020-06-02 09:10:27 -06:00
74f8b5b5f1
resource cleanup
2020-06-02 09:10:27 -06:00
93e5805c01
better exception handling
2020-06-02 09:10:27 -06:00
d83ce4c932
exceptions and resource cleanup
2020-06-02 09:10:27 -06:00
d4bdb42046
gossipsub fixes
2020-06-02 09:10:27 -06:00
9d3cc9647b
fix merge
2020-06-02 09:10:27 -06:00
3d9c0bffba
read from stream
2020-06-02 09:10:27 -06:00
048b1db1ad
revert back allread
2020-06-02 09:10:27 -06:00
8e9716f5c3
remove on transport close cleanup
2020-06-02 09:10:27 -06:00
cf76edb0dd
make noise work again
2020-06-02 09:10:27 -06:00
5158d96eaf
close connection on chronos close
2020-06-02 09:10:27 -06:00
46daed9a38
wip
2020-06-02 09:10:27 -06:00
Jacek Sieka
Dmitriy Ryajov
Eugene Kabanov
Giovanni Petrantoni
Ștefan Talpalaru
Giovanni Petrantoni
Oskar Thorén
Viktor Kirilov
Zahary Karadjov