From f310e7ccdcc167a618cfef41f946ed4827a27aba Mon Sep 17 00:00:00 2001 From: Alex Oberhauser Date: Tue, 9 May 2017 05:38:31 -0400 Subject: [PATCH] Fix for "filterCreationErrorCallback is not a function" Error #552 (#861) --- lib/web3/filter.js | 4 +++- lib/web3/methods/eth.js | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/web3/filter.js b/lib/web3/filter.js index 0eb41be..b8454a4 100644 --- a/lib/web3/filter.js +++ b/lib/web3/filter.js @@ -150,7 +150,9 @@ var Filter = function (requestManager, options, methods, formatter, callback, fi self.callbacks.forEach(function(cb){ cb(error); }); - filterCreationErrorCallback(error); + if (typeof filterCreationErrorCallback === 'function') { + filterCreationErrorCallback(error); + } } else { self.filterId = id; diff --git a/lib/web3/methods/eth.js b/lib/web3/methods/eth.js index 494e8f4..54a0513 100644 --- a/lib/web3/methods/eth.js +++ b/lib/web3/methods/eth.js @@ -335,8 +335,8 @@ Eth.prototype.contract = function (abi) { return factory; }; -Eth.prototype.filter = function (fil, callback) { - return new Filter(this._requestManager, fil, watches.eth(), formatters.outputLogFormatter, callback); +Eth.prototype.filter = function (fil, callback, filterCreationErrorCallback) { + return new Filter(this._requestManager, fil, watches.eth(), formatters.outputLogFormatter, callback, filterCreationErrorCallback); }; Eth.prototype.namereg = function () {