cfc282ff51
Only post peer protocol messages to the channel, bytes must be done directly. This fixes a possible issue where slow responses during handshake could cause keep alive messages to be sent prematurely.
47 lines
1.2 KiB
Go
47 lines
1.2 KiB
Go
package torrent
|
|
|
|
import (
|
|
"bitbucket.org/anacrolix/go.torrent/peer_protocol"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestCancelRequestOptimized(t *testing.T) {
|
|
c := &connection{
|
|
PeerMaxRequests: 1,
|
|
PeerPieces: []bool{false, true},
|
|
post: make(chan peer_protocol.Message),
|
|
write: make(chan []byte),
|
|
}
|
|
if len(c.Requests) != 0 {
|
|
t.FailNow()
|
|
}
|
|
// Keepalive timeout of 0 works because I'm just that good.
|
|
go c.writeOptimizer(0 * time.Millisecond)
|
|
c.Request(newRequest(1, 2, 3))
|
|
if len(c.Requests) != 1 {
|
|
t.Fatal("request was not posted")
|
|
}
|
|
// Posting this message should removing the pending Request.
|
|
if !c.Cancel(newRequest(1, 2, 3)) {
|
|
t.Fatal("request was not found")
|
|
}
|
|
// Check that the write optimization has filtered out the Request message.
|
|
for _, b := range []string{
|
|
// The initial request triggers an Interested message.
|
|
"\x00\x00\x00\x01\x02",
|
|
// Let a keep-alive through to verify there were no pending messages.
|
|
"\x00\x00\x00\x00",
|
|
} {
|
|
bb := string(<-c.write)
|
|
if b != bb {
|
|
t.Fatalf("received message %q is not expected: %q", bb, b)
|
|
}
|
|
}
|
|
close(c.post)
|
|
_, ok := <-c.write
|
|
if ok {
|
|
t.Fatal("write channel didn't close")
|
|
}
|
|
}
|